Re: [Intel-gfx] [PATCH 05/15] drm/i915/guc: Log runtime should consist of both mapping and relay

2018-03-06 Thread Chris Wilson
Quoting Michał Winiarski (2018-02-27 12:52:20) > -static int guc_log_runtime_create(struct intel_guc *guc) > +static int guc_log_map(struct intel_guc *guc) > { > struct drm_i915_private *dev_priv = guc_to_i915(guc); > void *vaddr; > int ret; > > -

Re: [Intel-gfx] [PATCH 05/15] drm/i915/guc: Log runtime should consist of both mapping and relay

2018-03-05 Thread Sagar Arun Kamble
On 3/5/2018 7:44 PM, Michał Winiarski wrote: On Mon, Mar 05, 2018 at 04:01:18PM +0530, Sagar Arun Kamble wrote: On 2/27/2018 6:22 PM, Michał Winiarski wrote: Currently, we're treating relay and mapping of GuC log as a separate concepts. We're also using inconsistent locking, sometimes using

Re: [Intel-gfx] [PATCH 05/15] drm/i915/guc: Log runtime should consist of both mapping and relay

2018-03-05 Thread Michał Winiarski
On Mon, Mar 05, 2018 at 04:01:18PM +0530, Sagar Arun Kamble wrote: > > > On 2/27/2018 6:22 PM, Michał Winiarski wrote: > > Currently, we're treating relay and mapping of GuC log as a separate > > concepts. We're also using inconsistent locking, sometimes using > > relay_lock, sometimes using

Re: [Intel-gfx] [PATCH 05/15] drm/i915/guc: Log runtime should consist of both mapping and relay

2018-03-05 Thread Sagar Arun Kamble
On 2/27/2018 6:22 PM, Michał Winiarski wrote: Currently, we're treating relay and mapping of GuC log as a separate concepts. We're also using inconsistent locking, sometimes using relay_lock, sometimes using struct mutex. Let's correct that. Anything touching the runtime is now serialized

Re: [Intel-gfx] [PATCH 05/15] drm/i915/guc: Log runtime should consist of both mapping and relay

2018-02-27 Thread Michal Wajdeczko
On Tue, 27 Feb 2018 13:52:20 +0100, Michał Winiarski wrote: Currently, we're treating relay and mapping of GuC log as a separate concepts. We're also using inconsistent locking, sometimes using relay_lock, sometimes using struct mutex. Let's correct that. Anything

[Intel-gfx] [PATCH 05/15] drm/i915/guc: Log runtime should consist of both mapping and relay

2018-02-27 Thread Michał Winiarski
Currently, we're treating relay and mapping of GuC log as a separate concepts. We're also using inconsistent locking, sometimes using relay_lock, sometimes using struct mutex. Let's correct that. Anything touching the runtime is now serialized using runtime.lock, while we're still using struct