Re: [Intel-gfx] [PATCH 05/19] drm/i915: Be irqsafe inside reset

2018-05-17 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-05-17 11:27:20) > > On 17/05/2018 08:40, Chris Wilson wrote: > > As we want to be able to call i915_reset_engine and co from a softirq or > > Just by glancing i915_reset_engine looks to heavy weight to ever be > callable from softirq/timer context. There is even a

Re: [Intel-gfx] [PATCH 05/19] drm/i915: Be irqsafe inside reset

2018-05-17 Thread Tvrtko Ursulin
On 17/05/2018 08:40, Chris Wilson wrote: As we want to be able to call i915_reset_engine and co from a softirq or Just by glancing i915_reset_engine looks to heavy weight to ever be callable from softirq/timer context. There is even a flush_workqueue in there. timer context, we need to

[Intel-gfx] [PATCH 05/19] drm/i915: Be irqsafe inside reset

2018-05-17 Thread Chris Wilson
As we want to be able to call i915_reset_engine and co from a softirq or timer context, we need to be irqsafe at all timers. So we have to forgo the simple spin_lock_irq for the full spin_lock_irqsave. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem.c | 6