Re: [Intel-gfx] [PATCH 1/1] drm/i915: Do not use kfree() to free kmem_cache_alloc() return value

Quoting Xidong Wang (2018-04-04 08:37:54) > In eb_lookup_vmas(), the return value of kmem_cache_alloc() is freed > with kfree(). I think the expected paired function is kmem_cahce_free(). > > Signed-off-by: Xidong Wang Thank you for the fix; applied. -Chris

Re: [Intel-gfx] [PATCH 1/1] drm/i915:Do not use kfree() to free kmem_cache_alloc() return value

Hi Xidong, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on v4.16 next-20180403] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [Intel-gfx] [PATCH 1/1] drm/i915:Do not use kfree() to free kmem_cache_alloc() return value

Hi Xidong, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on v4.16 next-20180403] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [Intel-gfx] [PATCH 1/1] drm/i915:Do not use kfree() to free kmem_cache_alloc() return value

Hi Xidong, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on v4.16 next-20180403] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[Intel-gfx] [PATCH 1/1] drm/i915:Do not use kfree() to free kmem_cache_alloc() return value

In eb_lookup_vmas(), lut, the return value of kmem_cache_alloc(), is freed with kfree().I think the expected paired function is kmem_cache_free(). Signed-off-by: Xidong Wang --- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 2 +- 1 file changed, 1 insertion(+), 1

[Intel-gfx] [PATCH 1/1] drm/i915: Do not use kfree() to free kmem_cache_alloc() return value

In eb_lookup_vmas(), the return value of kmem_cache_alloc() is freed with kfree(). I think the expected paired function is kmem_cahce_free(). Signed-off-by: Xidong Wang --- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Intel-gfx] [PATCH 1/1] drm/i915:Do not use kfree() to free kmem_cache_alloc() return value

On Wed, 04 Apr 2018, Xidong Wang wrote: > In eb_lookup_vmas(), lut, the return value of kmem_cache_alloc(), is freed > with kfree().I think the expected paired function is kmem_cache_free(). Agreed. But did you try to compile your patch before sending? Fixes: d1b48c1e7184

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Do not use kfree() to free kmem_cache_alloc() return value

Quoting Xidong Wang (2018-04-04 08:37:54) > In eb_lookup_vmas(), the return value of kmem_cache_alloc() is freed > with kfree(). I think the expected paired function is kmem_cahce_free(). > > Signed-off-by: Xidong Wang That is indeed what it should be doing, Fixes: