Re: [Intel-gfx] [PATCH 1/4] drm/i915/crt: Remove obsolete kerneldoc-esque comment

[Jani Nikula]

On Wed, 14 Feb 2018, Chris Wilson  wrote:
> The code describes what it is doing quite well; and that is now much
> more complex than what the old comment would let you believe.
>
> drivers/gpu/drm/i915/intel_crt.c:486: warning: Function parameter or member 
> 'connector' not described in 'intel_crt_detect_hotplug'
>
> Signed-off-by: Chris Wilson 

Reviewed-by: Jani Nikula 


> ---
>  drivers/gpu/drm/i915/intel_crt.c | 8 
>  1 file changed, 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_crt.c 
> b/drivers/gpu/drm/i915/intel_crt.c
> index d1493ced16f8..391dd69ae0a4 100644
> --- a/drivers/gpu/drm/i915/intel_crt.c
> +++ b/drivers/gpu/drm/i915/intel_crt.c
> @@ -474,14 +474,6 @@ static bool valleyview_crt_detect_hotplug(struct 
> drm_connector *connector)
>   return ret;
>  }
>  
> -/**
> - * Uses CRT_HOTPLUG_EN and CRT_HOTPLUG_STAT to detect CRT presence.
> - *
> - * Not for i915G/i915GM
> - *
> - * \return true if CRT is connected.
> - * \return false if CRT is disconnected.
> - */
>  static bool intel_crt_detect_hotplug(struct drm_connector *connector)
>  {
>   struct drm_device *dev = connector->dev;

-- 
Jani Nikula, Intel Open Source Technology Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 1/4] drm/i915/crt: Remove obsolete kerneldoc-esque comment

[Chris Wilson]

The code describes what it is doing quite well; and that is now much
more complex than what the old comment would let you believe.

drivers/gpu/drm/i915/intel_crt.c:486: warning: Function parameter or member 
'connector' not described in 'intel_crt_detect_hotplug'

Signed-off-by: Chris Wilson 
---
 drivers/gpu/drm/i915/intel_crt.c | 8 
 1 file changed, 8 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_crt.c b/drivers/gpu/drm/i915/intel_crt.c
index d1493ced16f8..391dd69ae0a4 100644
--- a/drivers/gpu/drm/i915/intel_crt.c
+++ b/drivers/gpu/drm/i915/intel_crt.c
@@ -474,14 +474,6 @@ static bool valleyview_crt_detect_hotplug(struct 
drm_connector *connector)
return ret;
 }
 
-/**
- * Uses CRT_HOTPLUG_EN and CRT_HOTPLUG_STAT to detect CRT presence.
- *
- * Not for i915G/i915GM
- *
- * \return true if CRT is connected.
- * \return false if CRT is disconnected.
- */
 static bool intel_crt_detect_hotplug(struct drm_connector *connector)
 {
struct drm_device *dev = connector->dev;
-- 
2.16.1

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx