Re: [Intel-gfx] [PATCH 10/16] drm/i915: Set scaler mode for NV12

Reviewed-by: Shashank Sharma Regards Shashank On 2/21/2018 3:50 PM, Vidya Srinivas wrote: From: Chandra Konduru This patch sets appropriate scaler mode for NV12 format. In this mode, skylake scaler does either chroma-upsampling or

[Intel-gfx] [PATCH 10/16] drm/i915: Set scaler mode for NV12

From: Chandra Konduru This patch sets appropriate scaler mode for NV12 format. In this mode, skylake scaler does either chroma-upsampling or chroma-upsampling and resolution scaling v2: Review comments from Ville addressed NV12 case to be checked first for setting the

Re: [Intel-gfx] [PATCH 10/16] drm/i915: Set scaler mode for NV12

I addressed it with PS_SCALER_MODE_PLANAR (1 << 29) to keep it generic. But as you mentioned that wouldn't be the right way. I need to keep GEN9 and GEN10+ separate. Will fix it in the next push. Thank you. Vidya From: Sharma, Shashank Sent: Thursday, February 15, 2018 12:03 PM To:

Re: [Intel-gfx] [PATCH 10/16] drm/i915: Set scaler mode for NV12

My previous review comments are not addressed on this patch. I made a comment which is about programming bits *29:28* on *PS_CTRL for (GEN>=9) *blindly*. * This is not valid for all GEN9 and above, in fact bit 29:28 as scalar mode is only valid for SKL. Bit 28 is not supported for GLK,

[Intel-gfx] [PATCH 10/16] drm/i915: Set scaler mode for NV12

From: Chandra Konduru This patch sets appropriate scaler mode for NV12 format. In this mode, skylake scaler does either chroma-upsampling or chroma-upsampling and resolution scaling v2: Review comments from Ville addressed NV12 case to be checked first for setting the

[Intel-gfx] [PATCH 10/16] drm/i915: Set scaler mode for NV12

From: Chandra Konduru This patch sets appropriate scaler mode for NV12 format. In this mode, skylake scaler does either chroma-upsampling or chroma-upsampling and resolution scaling v2: Review comments from Ville addressed NV12 case to be checked first for setting the

[Intel-gfx] [PATCH 10/16] drm/i915: Set scaler mode for NV12

From: Chandra Konduru This patch sets appropriate scaler mode for NV12 format. In this mode, skylake scaler does either chroma-upsampling or chroma-upsampling and resolution scaling v2: Review comments from Ville addressed NV12 case to be checked first for setting the

Re: [Intel-gfx] [PATCH 10/16] drm/i915: Set scaler mode for NV12

> -Original Message- > From: Sharma, Shashank > Sent: Thursday, February 8, 2018 2:35 PM > To: Srinivas, Vidya ; intel- > g...@lists.freedesktop.org > Cc: maarten.lankho...@linux.intel.com; Kamath, Sunil > ; Shankar, Uma

Re: [Intel-gfx] [PATCH 10/16] drm/i915: Set scaler mode for NV12

Regards Shashank On 2/6/2018 6:28 PM, Vidya Srinivas wrote: From: Chandra Konduru This patch sets appropriate scaler mode for NV12 format. In this mode, skylake scaler does either chroma-upsampling or chroma-upsampling and resolution scaling v2: Review comments

[Intel-gfx] [PATCH 10/16] drm/i915: Set scaler mode for NV12

From: Chandra Konduru This patch sets appropriate scaler mode for NV12 format. In this mode, skylake scaler does either chroma-upsampling or chroma-upsampling and resolution scaling v2: Review comments from Ville addressed NV12 case to be checked first for setting the

[Intel-gfx] [PATCH 10/16] drm/i915: Set scaler mode for NV12

From: Chandra Konduru This patch sets appropriate scaler mode for NV12 format. In this mode, skylake scaler does either chroma-upsampling or chroma-upsampling and resolution scaling v2: Review comments from Ville addressed NV12 case to be checked first for setting the

[Intel-gfx] [PATCH 10/16] drm/i915: Set scaler mode for NV12

From: Chandra Konduru This patch sets appropriate scaler mode for NV12 format. In this mode, skylake scaler does either chroma-upsampling or chroma-upsampling and resolution scaling v2: Review comments from Ville addressed NV12 case to be checked first for setting the