Re: [Intel-gfx] [PATCH igt] lib/kms: Clear unused fields for getproperty ioctl

[Mika Kuoppala]

Chris Wilson  writes:

> ==24749== Syscall param ioctl(generic) points to uninitialised byte(s)
> ==24749==at 0x6A8ADC7: ioctl (syscall-template.S:84)
> ==24749==by 0x5067687: drmIoctl (in /opt/xorg/lib64/libdrm.so.2.4.0)
> ==24749==by 0x138531: kmstest_set_connector_dpms (igt_kms.c:1022)
> ==24749==by 0x112937: set_dpms (kms_flip.c:263)
> ==24749==by 0x112937: run_test_step (kms_flip.c:776)
> ==24749==by 0x112937: event_loop (kms_flip.c:1138)
> ==24749==by 0x115468: run_test_on_crtc_set (kms_flip.c:1378)
> ==24749==by 0x115468: run_test (kms_flip.c:1450)
> ==24749==by 0xCF: main (kms_flip.c:1673)
> ==24749==  Address 0x1ffefff2a0 is on thread 1's stack
> ==24749==  in frame #2, created by kmstest_set_connector_dpms (igt_kms.c:1012)
>
> Signed-off-by: Chris Wilson 

Reviewed-by: Mika Kuoppala 

> ---
>  lib/igt_kms.c | 7 +++
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 9fe800d1..0c6dbf74 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -1014,11 +1014,10 @@ void kmstest_set_connector_dpms(int fd, 
> drmModeConnector *connector, int mode)
>   bool found_it = false;
>  
>   for (i = 0; i < connector->count_props; i++) {
> - struct drm_mode_get_property prop;
> + struct drm_mode_get_property prop = {
> + .prop_id = connector->props[i],
> + };
>  
> - prop.prop_id = connector->props[i];
> - prop.count_values = 0;
> - prop.count_enum_blobs = 0;
>   if (drmIoctl(fd, DRM_IOCTL_MODE_GETPROPERTY, ))
>   continue;
>  
> -- 
> 2.13.3
>
> ___
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH igt] lib/kms: Clear unused fields for getproperty ioctl

[Chris Wilson]

==24749== Syscall param ioctl(generic) points to uninitialised byte(s)
==24749==at 0x6A8ADC7: ioctl (syscall-template.S:84)
==24749==by 0x5067687: drmIoctl (in /opt/xorg/lib64/libdrm.so.2.4.0)
==24749==by 0x138531: kmstest_set_connector_dpms (igt_kms.c:1022)
==24749==by 0x112937: set_dpms (kms_flip.c:263)
==24749==by 0x112937: run_test_step (kms_flip.c:776)
==24749==by 0x112937: event_loop (kms_flip.c:1138)
==24749==by 0x115468: run_test_on_crtc_set (kms_flip.c:1378)
==24749==by 0x115468: run_test (kms_flip.c:1450)
==24749==by 0xCF: main (kms_flip.c:1673)
==24749==  Address 0x1ffefff2a0 is on thread 1's stack
==24749==  in frame #2, created by kmstest_set_connector_dpms (igt_kms.c:1012)

Signed-off-by: Chris Wilson 
---
 lib/igt_kms.c | 7 +++
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 9fe800d1..0c6dbf74 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -1014,11 +1014,10 @@ void kmstest_set_connector_dpms(int fd, 
drmModeConnector *connector, int mode)
bool found_it = false;
 
for (i = 0; i < connector->count_props; i++) {
-   struct drm_mode_get_property prop;
+   struct drm_mode_get_property prop = {
+   .prop_id = connector->props[i],
+   };
 
-   prop.prop_id = connector->props[i];
-   prop.count_values = 0;
-   prop.count_enum_blobs = 0;
if (drmIoctl(fd, DRM_IOCTL_MODE_GETPROPERTY, ))
continue;
 
-- 
2.13.3

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx