Re: [Intel-gfx] [PATCH v2 2/2] drm/i915: Invalidate the guc ggtt TLB upon insertion

2016-12-01 Thread Tvrtko Ursulin
On 01/12/2016 10:57, Chris Wilson wrote: On Thu, Dec 01, 2016 at 10:49:31AM +, Tvrtko Ursulin wrote: On 01/12/2016 10:26, Chris Wilson wrote: On Thu, Dec 01, 2016 at 10:06:25AM +, Tvrtko Ursulin wrote: On 01/12/2016 09:46, Chris Wilson wrote: Move the GuC invalidation of its ggtt T

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915: Invalidate the guc ggtt TLB upon insertion

2016-12-01 Thread Chris Wilson
On Thu, Dec 01, 2016 at 10:49:31AM +, Tvrtko Ursulin wrote: > > On 01/12/2016 10:26, Chris Wilson wrote: > >On Thu, Dec 01, 2016 at 10:06:25AM +, Tvrtko Ursulin wrote: > >> > >>On 01/12/2016 09:46, Chris Wilson wrote: > >>>Move the GuC invalidation of its ggtt TLB to where we perform the g

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915: Invalidate the guc ggtt TLB upon insertion

2016-12-01 Thread Tvrtko Ursulin
On 01/12/2016 10:26, Chris Wilson wrote: On Thu, Dec 01, 2016 at 10:06:25AM +, Tvrtko Ursulin wrote: On 01/12/2016 09:46, Chris Wilson wrote: Move the GuC invalidation of its ggtt TLB to where we perform the ggtt modification rather than proliferate it into all the callers of the insert (

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915: Invalidate the guc ggtt TLB upon insertion

2016-12-01 Thread Chris Wilson
On Thu, Dec 01, 2016 at 10:06:25AM +, Tvrtko Ursulin wrote: > > On 01/12/2016 09:46, Chris Wilson wrote: > >Move the GuC invalidation of its ggtt TLB to where we perform the ggtt > >modification rather than proliferate it into all the callers of the > >insert (which may or may not in fact have

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915: Invalidate the guc ggtt TLB upon insertion

2016-12-01 Thread Tvrtko Ursulin
On 01/12/2016 09:46, Chris Wilson wrote: Move the GuC invalidation of its ggtt TLB to where we perform the ggtt modification rather than proliferate it into all the callers of the insert (which may or may not in fact have to do the insertion). v2: Just do the guc invalidate unconditionally, (af

[Intel-gfx] [PATCH v2 2/2] drm/i915: Invalidate the guc ggtt TLB upon insertion

2016-12-01 Thread Chris Wilson
Move the GuC invalidation of its ggtt TLB to where we perform the ggtt modification rather than proliferate it into all the callers of the insert (which may or may not in fact have to do the insertion). v2: Just do the guc invalidate unconditionally, (afaict) it has no impact without the guc loade