Re: [Intel-gfx] [PATCH v4 4/9] drm/i915/guc: Update suspend functionality in intel_uc_suspend path

2017-09-21 Thread Michał Winiarski
On Thu, Sep 21, 2017 at 10:25:50PM +0530, Sagar Arun Kamble wrote: [SNIP] > > > + ret = intel_uc_runtime_suspend(dev_priv); > > > + if (ret) > > > + return ret; > > return intel_guc_runtime_suspend(dev_priv); > Did you really mean intel_*guc*_runtime_suspend here or was typo? Typo -

Re: [Intel-gfx] [PATCH v4 4/9] drm/i915/guc: Update suspend functionality in intel_uc_suspend path

2017-09-21 Thread Sagar Arun Kamble
On 9/21/2017 10:16 PM, Michał Winiarski wrote: On Wed, Sep 20, 2017 at 11:08:19PM +0530, Sagar Arun Kamble wrote: With this patch we disable GuC submission in i915_drm_suspend. This will destroy the client which will be setup back again. We also reuse the complete sanitization done via

Re: [Intel-gfx] [PATCH v4 4/9] drm/i915/guc: Update suspend functionality in intel_uc_suspend path

2017-09-21 Thread Michał Winiarski
On Wed, Sep 20, 2017 at 11:08:19PM +0530, Sagar Arun Kamble wrote: > With this patch we disable GuC submission in i915_drm_suspend. This will > destroy the client which will be setup back again. We also reuse the > complete sanitization done via intel_uc_runtime_suspend in this path. > Post drm

[Intel-gfx] [PATCH v4 4/9] drm/i915/guc: Update suspend functionality in intel_uc_suspend path

2017-09-20 Thread Sagar Arun Kamble
With this patch we disable GuC submission in i915_drm_suspend. This will destroy the client which will be setup back again. We also reuse the complete sanitization done via intel_uc_runtime_suspend in this path. Post drm resume this state is recreated by intel_uc_init_hw hence we need not have