Re: [Intel-gfx] [V3] drm/i915: Enable VBT based BL control for DP

2018-02-20 Thread Rodrigo Vivi
On Tue, Feb 20, 2018 at 11:43:57AM +0200, Jani Nikula wrote: > On Tue, 20 Feb 2018, Chris Wilson wrote: > > Quoting Mustaffa, Mustamin B (2018-02-20 08:44:45) > >> Hi Chris, > >> > >> Would you rather for me to use following line instead? > >> > >> + int

Re: [Intel-gfx] [V3] drm/i915: Enable VBT based BL control for DP

2018-02-20 Thread Jani Nikula
On Tue, 20 Feb 2018, Chris Wilson wrote: > Quoting Mustaffa, Mustamin B (2018-02-20 08:44:45) >> Hi Chris, >> >> Would you rather for me to use following line instead? >> >> + int backlight_controller = >>

Re: [Intel-gfx] [V3] drm/i915: Enable VBT based BL control for DP

2018-02-20 Thread Chris Wilson
Quoting Mustaffa, Mustamin B (2018-02-20 08:44:45) > Hi Chris, > > Would you rather for me to use following line instead? > > + int backlight_controller = > intel_dp->attached_connector->panel.backlight.controller; I think so, Jani would be best to answer the question about how

Re: [Intel-gfx] [V3] drm/i915: Enable VBT based BL control for DP

2018-02-20 Thread Mustaffa, Mustamin B
ary 20, 2018 4:39 PM To: Mustaffa, Mustamin B <mustamin.b.musta...@intel.com>; intel-gfx@lists.freedesktop.org Cc: Mustaffa, Mustamin B <mustamin.b.musta...@intel.com> Subject: Re: [Intel-gfx] [V3] drm/i915: Enable VBT based BL control for DP Quoting Mustamin B Mustaffa (2018-02-20 06:

Re: [Intel-gfx] [V3] drm/i915: Enable VBT based BL control for DP

2018-02-20 Thread Chris Wilson
Quoting Mustamin B Mustaffa (2018-02-20 06:52:49) > Currently, BXT_PP is hardcoded with value '0'. > It practically disabled eDP backlight on MRB (BXT) platform. > > This patch will tell which BXT_PP registers (there are two set of > PP_CONTROL in the spec) to be used as defined in VBT (Video

[Intel-gfx] [V3] drm/i915: Enable VBT based BL control for DP

2018-02-19 Thread Mustamin B Mustaffa
Currently, BXT_PP is hardcoded with value '0'. It practically disabled eDP backlight on MRB (BXT) platform. This patch will tell which BXT_PP registers (there are two set of PP_CONTROL in the spec) to be used as defined in VBT (Video Bios Timing table) and this will enabled eDP backlight

[Intel-gfx] [V3] drm/i915: Enable VBT based BL control for DP

2018-02-19 Thread Mustamin B Mustaffa
Currently, BXT_PP is hardcoded with value '0'. It practically disabled eDP backlight on MRB (BXT) platform. This patch will tell which BXT_PP registers (there are two set of PP_CONTROL in the spec) to be used as defined in VBT (Video Bios Timing table) and this will enabled eDP backlight