Re: [Intel-gfx] [PATCH] dim: replace pipe commands with single sed

2018-05-17 Thread Jani Nikula 
On Sat, 12 May 2018, Daniel Vetter  wrote:
> On Wed, May 09, 2018 at 04:32:53PM -0700, Lucas De Marchi wrote:
>> Now CC the right mailing list.  The way dim sets up the repository you
>> can't have individual git configs, e.g. to  set a different
>> sendemail.to for dim-tools :(
>> 
>> Lucas De Marchi
>> 
>> On Wed, May 9, 2018 at 2:28 PM, Lucas De Marchi
>>  wrote:
>> > A single sed can do the job of taking the second line after a match and
>> > it looks simpler.
>> >
>> > Signed-off-by: Lucas De Marchi 
>> > ---
>> >
>> > I noticed this while reviewing "[PATCH 2/4] dim: shut up sed broken pipe
>> > noise in apply-pull".
>
> Reviewed-by: Daniel Vetter 

Thanks, pushed.

>
>> >
>> >  dim | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/dim b/dim
>> > index 6b684ba5308c..f7cf255db3e1 100755
>> > --- a/dim
>> > +++ b/dim
>> > @@ -924,7 +924,7 @@ function dim_apply_pull
>> >
>> > cat > $file
>> >
>> > -   pull_branch=$(sed -e '0,/[gG]it repository at:$/d' $file | head -n 
>> > 2 | tail -n 1)
>> > +   pull_branch=$(sed -ne '/[gG]it repository at:$/{n;n;p}' $file)
>> >
>> > if [[ -z "$pull_branch" ]] ; then
>> > echoerr "no pull request found"
>> > --
>> > 2.17.0
>> >
>> > ___
>> > Intel-gfx mailing list
>> > Intel-gfx@lists.freedesktop.org
>> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>> 
>> 
>> 
>> -- 
>> Lucas De Marchi

-- 
Jani Nikula, Intel Open Source Technology Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] dim: replace pipe commands with single sed

2018-05-12 Thread Daniel Vetter 
On Wed, May 09, 2018 at 04:32:53PM -0700, Lucas De Marchi wrote:
> Now CC the right mailing list.  The way dim sets up the repository you
> can't have individual git configs, e.g. to  set a different
> sendemail.to for dim-tools :(
> 
> Lucas De Marchi
> 
> On Wed, May 9, 2018 at 2:28 PM, Lucas De Marchi
>  wrote:
> > A single sed can do the job of taking the second line after a match and
> > it looks simpler.
> >
> > Signed-off-by: Lucas De Marchi 
> > ---
> >
> > I noticed this while reviewing "[PATCH 2/4] dim: shut up sed broken pipe
> > noise in apply-pull".

Reviewed-by: Daniel Vetter 

> >
> >  dim | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/dim b/dim
> > index 6b684ba5308c..f7cf255db3e1 100755
> > --- a/dim
> > +++ b/dim
> > @@ -924,7 +924,7 @@ function dim_apply_pull
> >
> > cat > $file
> >
> > -   pull_branch=$(sed -e '0,/[gG]it repository at:$/d' $file | head -n 
> > 2 | tail -n 1)
> > +   pull_branch=$(sed -ne '/[gG]it repository at:$/{n;n;p}' $file)
> >
> > if [[ -z "$pull_branch" ]] ; then
> > echoerr "no pull request found"
> > --
> > 2.17.0
> >
> > ___
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
> 
> 
> -- 
> Lucas De Marchi

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] dim: replace pipe commands with single sed

2018-05-09 Thread Lucas De Marchi 
Now CC the right mailing list.  The way dim sets up the repository you
can't have individual git configs, e.g. to  set a different
sendemail.to for dim-tools :(

Lucas De Marchi

On Wed, May 9, 2018 at 2:28 PM, Lucas De Marchi
 wrote:
> A single sed can do the job of taking the second line after a match and
> it looks simpler.
>
> Signed-off-by: Lucas De Marchi 
> ---
>
> I noticed this while reviewing "[PATCH 2/4] dim: shut up sed broken pipe
> noise in apply-pull".
>
>  dim | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dim b/dim
> index 6b684ba5308c..f7cf255db3e1 100755
> --- a/dim
> +++ b/dim
> @@ -924,7 +924,7 @@ function dim_apply_pull
>
> cat > $file
>
> -   pull_branch=$(sed -e '0,/[gG]it repository at:$/d' $file | head -n 2 
> | tail -n 1)
> +   pull_branch=$(sed -ne '/[gG]it repository at:$/{n;n;p}' $file)
>
> if [[ -z "$pull_branch" ]] ; then
> echoerr "no pull request found"
> --
> 2.17.0
>
> ___
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Lucas De Marchi
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx