Re: [Intel-gfx] [PATCH] drm/i915/cnl: document WaVFUnitClockGatingDisable

[Rodrigo Vivi]

On Mon, Mar 05, 2018 at 05:40:01PM -0800, Rafael Antognolli wrote:
> On Mon, Mar 05, 2018 at 05:20:00PM -0800, Rodrigo Vivi wrote:
> > No functional change. WA is already properly applied.
> > but in different databases it has different names.
> > Let's document all of them to avoid future confusion.
> 
> Works for me.
> 
> Reviewed-by: Rafael Antognolli 

thanks, pushed.

> 
> > Cc: Rafael Antognolli 
> > Signed-off-by: Rodrigo Vivi 
> > ---
> >  drivers/gpu/drm/i915/intel_pm.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_pm.c 
> > b/drivers/gpu/drm/i915/intel_pm.c
> > index be01012bb65f..c0253e42a280 100644
> > --- a/drivers/gpu/drm/i915/intel_pm.c
> > +++ b/drivers/gpu/drm/i915/intel_pm.c
> > @@ -8528,6 +8528,7 @@ static void cnl_init_clock_gating(struct 
> > drm_i915_private *dev_priv)
> > I915_WRITE(SUBSLICE_UNIT_LEVEL_CLKGATE, val);
> >  
> > /* WaDisableVFclkgate:cnl */
> > +   /* WaVFUnitClockGatingDisable:cnl */
> > val = I915_READ(UNSLICE_UNIT_LEVEL_CLKGATE);
> > val |= VFUNIT_CLKGATE_DIS;
> > I915_WRITE(UNSLICE_UNIT_LEVEL_CLKGATE, val);
> > -- 
> > 2.13.6
> > 
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915/cnl: document WaVFUnitClockGatingDisable

[Rafael Antognolli]

On Mon, Mar 05, 2018 at 05:20:00PM -0800, Rodrigo Vivi wrote:
> No functional change. WA is already properly applied.
> but in different databases it has different names.
> Let's document all of them to avoid future confusion.

Works for me.

Reviewed-by: Rafael Antognolli 

> Cc: Rafael Antognolli 
> Signed-off-by: Rodrigo Vivi 
> ---
>  drivers/gpu/drm/i915/intel_pm.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index be01012bb65f..c0253e42a280 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -8528,6 +8528,7 @@ static void cnl_init_clock_gating(struct 
> drm_i915_private *dev_priv)
>   I915_WRITE(SUBSLICE_UNIT_LEVEL_CLKGATE, val);
>  
>   /* WaDisableVFclkgate:cnl */
> + /* WaVFUnitClockGatingDisable:cnl */
>   val = I915_READ(UNSLICE_UNIT_LEVEL_CLKGATE);
>   val |= VFUNIT_CLKGATE_DIS;
>   I915_WRITE(UNSLICE_UNIT_LEVEL_CLKGATE, val);
> -- 
> 2.13.6
> 
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx