Re: [Intel-gfx] [PATCH] drm/i915/dp: Link train Fallback on eDP only if fallback link BW can fit panel's native mode

2018-08-20 Thread Wilson
I believe this is the patch discussed here: https://bugs.freedesktop.org/show_bug.cgi?id=105338 In which case Tested-By: Alexander Wilson On 8/17/18 4:36 PM, Manasi Navare wrote: > Thanks Lyude. > > So based on the imitial comments from Jani N, the recommendation was to > disconnect >

Re: [Intel-gfx] [PATCH] drm/i915/dp: Link train Fallback on eDP only if fallback link BW can fit panel's native mode

2018-08-17 Thread Manasi Navare
Thanks Lyude. So based on the imitial comments from Jani N, the recommendation was to disconnect downclock_mode from drrs_init so that user can set downclock mode independently from drrs mode. Jani, So we would need following changes: * Set the panel->downclock_mode in edp_init_connector()

Re: [Intel-gfx] [PATCH] drm/i915/dp: Link train Fallback on eDP only if fallback link BW can fit panel's native mode

2018-08-17 Thread Lyude Paul
On Fri, 2018-08-17 at 13:40 -0700, Manasi Navare wrote: > On Fri, Aug 17, 2018 at 04:32:09PM -0400, Lyude Paul wrote: > > After reading the discussion so far on this patch, this sounds correct! One > > nit > > pick below though: > > > > On Wed, 2018-05-16 at 19:21 -0700, Manasi Navare wrote: > >

Re: [Intel-gfx] [PATCH] drm/i915/dp: Link train Fallback on eDP only if fallback link BW can fit panel's native mode

2018-08-17 Thread Manasi Navare
On Fri, Aug 17, 2018 at 04:32:09PM -0400, Lyude Paul wrote: > After reading the discussion so far on this patch, this sounds correct! One > nit > pick below though: > > On Wed, 2018-05-16 at 19:21 -0700, Manasi Navare wrote: > > This patch fixes the original commit c0cfb10d9e1de49

Re: [Intel-gfx] [PATCH] drm/i915/dp: Link train Fallback on eDP only if fallback link BW can fit panel's native mode

2018-08-17 Thread Lyude Paul
After reading the discussion so far on this patch, this sounds correct! One nit pick below though: On Wed, 2018-05-16 at 19:21 -0700, Manasi Navare wrote: > This patch fixes the original commit c0cfb10d9e1de49 ("drm/i915/edp: > Do not do link training fallback or prune modes on EDP") that causes

Re: [Intel-gfx] [PATCH] drm/i915/dp: Link train Fallback on eDP only if fallback link BW can fit panel's native mode

2018-05-18 Thread Lucas De Marchi
On Thu, May 17, 2018 at 12:28 AM, Jani Nikula wrote: > On Wed, 16 May 2018, Manasi Navare wrote: >> This patch fixes the original commit c0cfb10d9e1de49 ("drm/i915/edp: >> Do not do link training fallback or prune modes on EDP") that causes

Re: [Intel-gfx] [PATCH] drm/i915/dp: Link train Fallback on eDP only if fallback link BW can fit panel's native mode

2018-05-17 Thread Manasi Navare
On Thu, May 17, 2018 at 10:28:02AM +0300, Jani Nikula wrote: > On Wed, 16 May 2018, Manasi Navare wrote: > > This patch fixes the original commit c0cfb10d9e1de49 ("drm/i915/edp: > > Do not do link training fallback or prune modes on EDP") that causes > > a blank screen

Re: [Intel-gfx] [PATCH] drm/i915/dp: Link train Fallback on eDP only if fallback link BW can fit panel's native mode

2018-05-17 Thread Jani Nikula
On Wed, 16 May 2018, Manasi Navare wrote: > This patch fixes the original commit c0cfb10d9e1de49 ("drm/i915/edp: > Do not do link training fallback or prune modes on EDP") that causes > a blank screen in case of certain eDP panels (Eg: seen on Dell XPS13 9350) > where