Hi Sujaritha,
[...]
> > +void intel_gt_sysfs_unregister(struct intel_gt *gt)
> > +{
> > +}
>
> Is there a reason for this function to not be populated ?
yes, there is, indeed, something missing here. There has been a
fix bout this floating around from Chris about sysfs_gt kobjects.
I will
On 10/13/2021 5:08 PM, Andi Shyti wrote:
From: Andi Shyti
The GT has its own properties and in sysfs they should be grouped
in the 'gt/' directory.
Create a 'gt/' directory in sysfs which will contain gt0...gtN
directories related to each tile configured in the GPU. Move the
power
Hi Tvrtko,
> > > > + }
> > > > +
> > > > + intel_gt_sysfs_pm_remove(gt, root);
> > > > + kobject_put(root);
> > >
> > > Maybe stick to the same terminology regarding root and parent.
> >
> > yes.
> >
> > > Get/put on the parent looks unbalanced. Both register and unregister
On 14/02/2020 13:18, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2020-02-14 12:54:35)
On 14/02/2020 11:03, Andi Shyti wrote:
+struct intel_gt *intel_gt_sysfs_get_drvdata(struct device *dev)
+{
+ struct kobject *kobj = >kobj;
+ /*
+ * We are interested at knowing from where the
On 14/02/2020 13:16, Andi Shyti wrote:
Hi Tvrtko,
The GT has its own properties and in sysfs they should be grouped
in the 'gt/' directory.
Create the 'gt/' directory in sysfs and move the power management
related files.
Can you paste the new and legacy paths in the commit message?
Quoting Tvrtko Ursulin (2020-02-14 12:54:35)
>
> On 14/02/2020 11:03, Andi Shyti wrote:
> > +struct intel_gt *intel_gt_sysfs_get_drvdata(struct device *dev)
> > +{
> > + struct kobject *kobj = >kobj;
> > + /*
> > + * We are interested at knowing from where the interface
> > + *
Hi Tvrtko,
> > The GT has its own properties and in sysfs they should be grouped
> > in the 'gt/' directory.
> >
> > Create the 'gt/' directory in sysfs and move the power management
> > related files.
>
> Can you paste the new and legacy paths in the commit message?
sure!
> > diff --git
Quoting Andi Shyti (2020-02-14 11:03:08)
> +struct intel_gt *intel_gt_sysfs_get_drvdata(struct device *dev)
> +{
> + struct kobject *kobj = >kobj;
> + /*
> +* We are interested at knowing from where the interface
> +* has been called, whether it's called from gt/ or
On 14/02/2020 11:03, Andi Shyti wrote:
The GT has its own properties and in sysfs they should be grouped
in the 'gt/' directory.
Create the 'gt/' directory in sysfs and move the power management
related files.
Can you paste the new and legacy paths in the commit message?
Signed-off-by:
Hi Jani,
> > void intel_gt_init_early(struct intel_gt *gt, struct drm_i915_private
> > *i915)
> > {
> > @@ -321,6 +322,7 @@ void intel_gt_driver_register(struct intel_gt *gt)
> > intel_rps_driver_register(>rps);
> >
> > debugfs_gt_register(gt);
>
> Yikes, when did this happen? Not
On Sat, 08 Feb 2020, Andi Shyti wrote:
> From: Andi Shyti
>
> The GT has its own properties and in sysfs they should be grouped
> in the 'gt/' directory.
>
> Create the 'gt/' directory in sysfs and move the power management
> related files.
>
> Signed-off-by: Andi Shyti
> ---
>
> > > > > > The GT has its own properties and in sysfs they should be grouped
> > > > > > in the 'gt/' directory.
> > > > > >
> > > > > > Create the 'gt/' directory in sysfs and move the power management
> > > > > > related files.
> > > > >
> > > > > As shown by BAT, we have a conundrum; do we
Hi Chris,
> > > > The GT has its own properties and in sysfs they should be grouped
> > > > in the 'gt/' directory.
> > > >
> > > > Create the 'gt/' directory in sysfs and move the power management
> > > > related files.
> > >
> > > As shown by BAT, we have a conundrum; do we have to preserve
On Sat, Feb 08, 2020 at 04:26:18PM +, Chris Wilson wrote:
> Quoting Andi Shyti (2020-02-08 12:27:59)
> > From: Andi Shyti
> >
> > The GT has its own properties and in sysfs they should be grouped
> > in the 'gt/' directory.
> >
> > Create the 'gt/' directory in sysfs and move the power
Quoting Andi Shyti (2020-02-08 17:01:53)
> Hi Chris,
>
> > > > > The GT has its own properties and in sysfs they should be grouped
> > > > > in the 'gt/' directory.
> > > > >
> > > > > Create the 'gt/' directory in sysfs and move the power management
> > > > > related files.
> > > >
> > > > As
Quoting Andi Shyti (2020-02-08 16:51:39)
> On Sat, Feb 08, 2020 at 04:26:18PM +, Chris Wilson wrote:
> > Quoting Andi Shyti (2020-02-08 12:27:59)
> > > From: Andi Shyti
> > >
> > > The GT has its own properties and in sysfs they should be grouped
> > > in the 'gt/' directory.
> > >
> > >
Quoting Andi Shyti (2020-02-08 12:27:59)
> From: Andi Shyti
>
> The GT has its own properties and in sysfs they should be grouped
> in the 'gt/' directory.
>
> Create the 'gt/' directory in sysfs and move the power management
> related files.
As shown by BAT, we have a conundrum; do we have to
17 matches
Mail list logo
