Re: [Intel-gfx] [PATCH] drm/i915: Preallocate mmu notifier to unbreak cpu hotplug deadlock

2017-10-05 Thread Thomas Gleixner
On Thu, 5 Oct 2017, Daniel Vetter wrote: > On Thu, Oct 05, 2017 at 06:19:30PM +0200, Thomas Gleixner wrote: > > On Thu, 5 Oct 2017, Daniel Vetter wrote: > > > On Thu, Oct 05, 2017 at 05:23:20PM +0200, Thomas Gleixner wrote: > > > > Aside of that, is it really required to use stomp_machine() for

Re: [Intel-gfx] [PATCH] drm/i915: Preallocate mmu notifier to unbreak cpu hotplug deadlock

2017-10-05 Thread Daniel Vetter
On Thu, Oct 05, 2017 at 06:19:30PM +0200, Thomas Gleixner wrote: > On Thu, 5 Oct 2017, Daniel Vetter wrote: > > On Thu, Oct 05, 2017 at 05:23:20PM +0200, Thomas Gleixner wrote: > > > Aside of that, is it really required to use stomp_machine() for this > > > synchronization? We certainly have less

Re: [Intel-gfx] [PATCH] drm/i915: Preallocate mmu notifier to unbreak cpu hotplug deadlock

2017-10-05 Thread Thomas Gleixner
On Thu, 5 Oct 2017, Daniel Vetter wrote: > On Thu, Oct 05, 2017 at 05:23:20PM +0200, Thomas Gleixner wrote: > > Aside of that, is it really required to use stomp_machine() for this > > synchronization? We certainly have less intrusive mechansisms than that. > > Yeah, the stop_machine needs to go,

Re: [Intel-gfx] [PATCH] drm/i915: Preallocate mmu notifier to unbreak cpu hotplug deadlock

2017-10-05 Thread Thomas Gleixner
On Thu, 5 Oct 2017, Daniel Vetter wrote: > 4.14-rc1 gained the fancy new cross-release support in lockdep, which > seems to have uncovered a few more rules about what is allowed and > isn't. > > This one here seems to indicate that allocating a work-queue while > holding mmap_sem is a no-go, so

Re: [Intel-gfx] [PATCH] drm/i915: Preallocate mmu notifier to unbreak cpu hotplug deadlock

2017-10-05 Thread Daniel Vetter
On Thu, Oct 05, 2017 at 05:23:20PM +0200, Thomas Gleixner wrote: > On Thu, 5 Oct 2017, Daniel Vetter wrote: > > > 4.14-rc1 gained the fancy new cross-release support in lockdep, which > > seems to have uncovered a few more rules about what is allowed and > > isn't. > > > > This one here seems to

Re: [Intel-gfx] [PATCH] drm/i915: Preallocate mmu notifier to unbreak cpu hotplug deadlock

2017-10-05 Thread Chris Wilson
Quoting Daniel Vetter (2017-10-05 14:22:06) > 4.14-rc1 gained the fancy new cross-release support in lockdep, which > seems to have uncovered a few more rules about what is allowed and > isn't. > > This one here seems to indicate that allocating a work-queue while > holding mmap_sem is a no-go,

Re: [Intel-gfx] [PATCH] drm/i915: Preallocate mmu notifier to unbreak cpu hotplug deadlock

2017-10-05 Thread Chris Wilson
Quoting Daniel Vetter (2017-10-05 14:22:06) > 4.14-rc1 gained the fancy new cross-release support in lockdep, which > seems to have uncovered a few more rules about what is allowed and > isn't. > > This one here seems to indicate that allocating a work-queue while > holding mmap_sem is a no-go,