Re: [Intel-gfx] [PATCH 0/5] drm/i915/skl: drop pre-production stepping workarounds
On Thu, 22 Sep 2016, Paulo Zanoni wrote: > Em Sex, 2016-09-16 às 16:59 +0300, Jani Nikula escreveu: >> Only production steppings are supported, drop workarounds for >> anything >> else. The series is split by revision so we can bikeshed if there are >> steppings some people still need to use for some reason. > > Bikeshed: in patches 2 and 3 you could have added platform tags to the > workaround tags, while also adding the missing space to a > /* comment*/. > > Jani S., Yann: perhaps we could try to check if our CI/QA systems still > have these machines? Just "lspci -nn | grep VGA" on the SKL systems and > check whether rev <= 5. > > If we conclude our CI system doesn't include these machines: > Reviewed-by: Paulo Zanoni Pushed patches 1-5, thanks for the review, and sent a separate patch to address the bikesheds [1], along with a resend of your pre-production hardware warning patch [2]. BR, Jani. [1] http://patchwork.freedesktop.org/patch/msgid/1474891672-23414-1-git-send-email-jani.nik...@intel.com [2] http://patchwork.freedesktop.org/patch/msgid/1474891672-23414-2-git-send-email-jani.nik...@intel.com > >> >> BR, >> Jani. >> >> Jani Nikula (5): >> drm/i915/skl: drop workarounds for A0 and B0 revisions >> drm/i915/skl: drop workarounds for C0 revision >> drm/i915/skl: drop workarounds for D0 revision >> drm/i915/skl: drop workarounds for E0 revision >> drm/i915/skl: drop workarounds for F0 revision >> >> drivers/gpu/drm/i915/intel_dp.c | 4 -- >> drivers/gpu/drm/i915/intel_dp_link_training.c | 3 -- >> drivers/gpu/drm/i915/intel_guc_loader.c | 8 ++-- >> drivers/gpu/drm/i915/intel_lrc.c | 23 +-- >> drivers/gpu/drm/i915/intel_pm.c | 3 +- >> drivers/gpu/drm/i915/intel_ringbuffer.c | 58 +-- >> >> 6 files changed, 23 insertions(+), 76 deletions(-) >> -- Jani Nikula, Intel Open Source Technology Center ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 0/5] drm/i915/skl: drop pre-production stepping workarounds
> > > From: Zanoni, Paulo R > > Em Sex, 2016-09-16 às 16:59 +0300, Jani Nikula escreveu: > > > Only production steppings are supported, drop workarounds for > > > anything else. The series is split by revision so we can bikeshed if > > > there are steppings some people still need to use for some reason. > > > > Bikeshed: in patches 2 and 3 you could have added platform tags to the > > workaround tags, while also adding the missing space to a > > /* comment*/. > > > > Jani S., Yann: perhaps we could try to check if our CI/QA systems > > still have these machines? Just "lspci -nn | grep VGA" on the SKL > > systems and check whether rev <= 5. > > The CI system doesn't have any pre-production SKL machines. They were > dropped as soon as we got production machines. On QA side, we have mainly switched to production machines here and remaining RVP is > 5. Yann > > Tomi > > > If we conclude our CI system doesn't include these machines: > > Reviewed-by: Paulo Zanoni > > > > Jani Nikula (5): > > > drm/i915/skl: drop workarounds for A0 and B0 revisions > > > drm/i915/skl: drop workarounds for C0 revision > > > drm/i915/skl: drop workarounds for D0 revision > > > drm/i915/skl: drop workarounds for E0 revision > > > drm/i915/skl: drop workarounds for F0 revision > > > > > > drivers/gpu/drm/i915/intel_dp.c | 4 -- > > > drivers/gpu/drm/i915/intel_dp_link_training.c | 3 -- > > > drivers/gpu/drm/i915/intel_guc_loader.c | 8 ++-- > > > drivers/gpu/drm/i915/intel_lrc.c | 23 +-- > > > drivers/gpu/drm/i915/intel_pm.c | 3 +- > > > drivers/gpu/drm/i915/intel_ringbuffer.c | 58 +-- > > > > > > 6 files changed, 23 insertions(+), 76 deletions(-) ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 0/5] drm/i915/skl: drop pre-production stepping workarounds
> From: Zanoni, Paulo R > Em Sex, 2016-09-16 às 16:59 +0300, Jani Nikula escreveu: > > Only production steppings are supported, drop workarounds for > > anything > > else. The series is split by revision so we can bikeshed if there are > > steppings some people still need to use for some reason. > > Bikeshed: in patches 2 and 3 you could have added platform tags to the > workaround tags, while also adding the missing space to a > /* comment*/. > > Jani S., Yann: perhaps we could try to check if our CI/QA systems still > have these machines? Just "lspci -nn | grep VGA" on the SKL systems and > check whether rev <= 5. The CI system doesn't have any pre-production SKL machines. They were dropped as soon as we got production machines. Tomi > If we conclude our CI system doesn't include these machines: > Reviewed-by: Paulo Zanoni > > Jani Nikula (5): > > drm/i915/skl: drop workarounds for A0 and B0 revisions > > drm/i915/skl: drop workarounds for C0 revision > > drm/i915/skl: drop workarounds for D0 revision > > drm/i915/skl: drop workarounds for E0 revision > > drm/i915/skl: drop workarounds for F0 revision > > > > drivers/gpu/drm/i915/intel_dp.c | 4 -- > > drivers/gpu/drm/i915/intel_dp_link_training.c | 3 -- > > drivers/gpu/drm/i915/intel_guc_loader.c | 8 ++-- > > drivers/gpu/drm/i915/intel_lrc.c | 23 +-- > > drivers/gpu/drm/i915/intel_pm.c | 3 +- > > drivers/gpu/drm/i915/intel_ringbuffer.c | 58 +-- > > > > 6 files changed, 23 insertions(+), 76 deletions(-) ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 0/5] drm/i915/skl: drop pre-production stepping workarounds
Em Sex, 2016-09-16 às 16:59 +0300, Jani Nikula escreveu: > Only production steppings are supported, drop workarounds for > anything > else. The series is split by revision so we can bikeshed if there are > steppings some people still need to use for some reason. Bikeshed: in patches 2 and 3 you could have added platform tags to the workaround tags, while also adding the missing space to a /* comment*/. Jani S., Yann: perhaps we could try to check if our CI/QA systems still have these machines? Just "lspci -nn | grep VGA" on the SKL systems and check whether rev <= 5. If we conclude our CI system doesn't include these machines: Reviewed-by: Paulo Zanoni > > BR, > Jani. > > Jani Nikula (5): > drm/i915/skl: drop workarounds for A0 and B0 revisions > drm/i915/skl: drop workarounds for C0 revision > drm/i915/skl: drop workarounds for D0 revision > drm/i915/skl: drop workarounds for E0 revision > drm/i915/skl: drop workarounds for F0 revision > > drivers/gpu/drm/i915/intel_dp.c | 4 -- > drivers/gpu/drm/i915/intel_dp_link_training.c | 3 -- > drivers/gpu/drm/i915/intel_guc_loader.c | 8 ++-- > drivers/gpu/drm/i915/intel_lrc.c | 23 +-- > drivers/gpu/drm/i915/intel_pm.c | 3 +- > drivers/gpu/drm/i915/intel_ringbuffer.c | 58 +-- > > 6 files changed, 23 insertions(+), 76 deletions(-) > ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
