Re: [Intel-gfx] [PATCH 1/5] drm/i915/userptr: Beware recursive lock_page()

2019-11-05 Thread Chris Wilson
Quoting Chris Wilson (2019-07-16 13:49:27) > Following a try_to_unmap() we may want to remove the userptr and so call > put_pages(). However, try_to_unmap() acquires the page lock and so we > must avoid recursively locking the pages ourselves -- which means that > we cannot safely acquire the lock

Re: [Intel-gfx] [PATCH 1/5] drm/i915/userptr: Beware recursive lock_page()

2019-09-11 Thread Tvrtko Ursulin
On 11/09/2019 12:38, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-09-11 12:31:32) On 09/09/2019 14:52, Chris Wilson wrote: Quoting Lionel Landwerlin (2019-07-26 14:38:40) On 17/07/2019 21:09, Tvrtko Ursulin wrote: On 17/07/2019 15:06, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-0

Re: [Intel-gfx] [PATCH 1/5] drm/i915/userptr: Beware recursive lock_page()

2019-09-11 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-09-11 12:31:32) > > On 09/09/2019 14:52, Chris Wilson wrote: > > Quoting Lionel Landwerlin (2019-07-26 14:38:40) > >> On 17/07/2019 21:09, Tvrtko Ursulin wrote: > >>> > >>> On 17/07/2019 15:06, Chris Wilson wrote: > Quoting Tvrtko Ursulin (2019-07-17 14:46:15) > >

Re: [Intel-gfx] [PATCH 1/5] drm/i915/userptr: Beware recursive lock_page()

2019-09-11 Thread Tvrtko Ursulin
On 09/09/2019 14:52, Chris Wilson wrote: Quoting Lionel Landwerlin (2019-07-26 14:38:40) On 17/07/2019 21:09, Tvrtko Ursulin wrote: On 17/07/2019 15:06, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-07-17 14:46:15) On 17/07/2019 14:35, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-0

Re: [Intel-gfx] [PATCH 1/5] drm/i915/userptr: Beware recursive lock_page()

2019-09-09 Thread Chris Wilson
Quoting Lionel Landwerlin (2019-07-26 14:38:40) > On 17/07/2019 21:09, Tvrtko Ursulin wrote: > > > > On 17/07/2019 15:06, Chris Wilson wrote: > >> Quoting Tvrtko Ursulin (2019-07-17 14:46:15) > >>> > >>> On 17/07/2019 14:35, Chris Wilson wrote: > Quoting Tvrtko Ursulin (2019-07-17 14:23:55) >

Re: [Intel-gfx] [PATCH 1/5] drm/i915/userptr: Beware recursive lock_page()

2019-07-26 Thread Lionel Landwerlin
On 17/07/2019 21:09, Tvrtko Ursulin wrote: On 17/07/2019 15:06, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-07-17 14:46:15) On 17/07/2019 14:35, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-07-17 14:23:55) On 17/07/2019 14:17, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-07-1

Re: [Intel-gfx] [PATCH 1/5] drm/i915/userptr: Beware recursive lock_page()

2019-07-17 Thread Tvrtko Ursulin
On 17/07/2019 15:06, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-07-17 14:46:15) On 17/07/2019 14:35, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-07-17 14:23:55) On 17/07/2019 14:17, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-07-17 14:09:00) On 16/07/2019 16:37, Chris Wil

Re: [Intel-gfx] [PATCH 1/5] drm/i915/userptr: Beware recursive lock_page()

2019-07-17 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-07-17 14:46:15) > > On 17/07/2019 14:35, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2019-07-17 14:23:55) > >> > >> On 17/07/2019 14:17, Chris Wilson wrote: > >>> Quoting Tvrtko Ursulin (2019-07-17 14:09:00) > > On 16/07/2019 16:37, Chris Wilson wrote: >

Re: [Intel-gfx] [PATCH 1/5] drm/i915/userptr: Beware recursive lock_page()

2019-07-17 Thread Tvrtko Ursulin
On 17/07/2019 14:35, Chris Wilson wrote: > Quoting Tvrtko Ursulin (2019-07-17 14:23:55) >> >> On 17/07/2019 14:17, Chris Wilson wrote: >>> Quoting Tvrtko Ursulin (2019-07-17 14:09:00) On 16/07/2019 16:37, Chris Wilson wrote: > Quoting Tvrtko Ursulin (2019-07-16 16:25:22) >> >

Re: [Intel-gfx] [PATCH 1/5] drm/i915/userptr: Beware recursive lock_page()

2019-07-17 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-07-17 14:23:55) > > On 17/07/2019 14:17, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2019-07-17 14:09:00) > >> > >> On 16/07/2019 16:37, Chris Wilson wrote: > >>> Quoting Tvrtko Ursulin (2019-07-16 16:25:22) > > On 16/07/2019 13:49, Chris Wilson wrote: >

Re: [Intel-gfx] [PATCH 1/5] drm/i915/userptr: Beware recursive lock_page()

2019-07-17 Thread Tvrtko Ursulin
On 17/07/2019 14:17, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-07-17 14:09:00) On 16/07/2019 16:37, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-07-16 16:25:22) On 16/07/2019 13:49, Chris Wilson wrote: Following a try_to_unmap() we may want to remove the userptr and so call put_

Re: [Intel-gfx] [PATCH 1/5] drm/i915/userptr: Beware recursive lock_page()

2019-07-17 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-07-17 14:09:00) > > On 16/07/2019 16:37, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2019-07-16 16:25:22) > >> > >> On 16/07/2019 13:49, Chris Wilson wrote: > >>> Following a try_to_unmap() we may want to remove the userptr and so call > >>> put_pages(). However, t

Re: [Intel-gfx] [PATCH 1/5] drm/i915/userptr: Beware recursive lock_page()

2019-07-17 Thread Tvrtko Ursulin
On 16/07/2019 16:37, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-07-16 16:25:22) On 16/07/2019 13:49, Chris Wilson wrote: Following a try_to_unmap() we may want to remove the userptr and so call put_pages(). However, try_to_unmap() acquires the page lock and so we must avoid recursively

Re: [Intel-gfx] [PATCH 1/5] drm/i915/userptr: Beware recursive lock_page()

2019-07-16 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-07-16 16:25:22) > > On 16/07/2019 13:49, Chris Wilson wrote: > > Following a try_to_unmap() we may want to remove the userptr and so call > > put_pages(). However, try_to_unmap() acquires the page lock and so we > > must avoid recursively locking the pages ourselves --

Re: [Intel-gfx] [PATCH 1/5] drm/i915/userptr: Beware recursive lock_page()

2019-07-16 Thread Tvrtko Ursulin
On 16/07/2019 13:49, Chris Wilson wrote: Following a try_to_unmap() we may want to remove the userptr and so call put_pages(). However, try_to_unmap() acquires the page lock and so we must avoid recursively locking the pages ourselves -- which means that we cannot safely acquire the lock around