Re: [Intel-gfx] [PATCH 12/15] drm/i915/gem: Cancel non-persistent contexts on close

2019-10-14 Thread Tvrtko Ursulin
On 14/10/2019 14:34, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-10-14 14:10:30) On 14/10/2019 13:21, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-10-14 13:11:46) On 14/10/2019 10:07, Chris Wilson wrote: Normally, we rely on our hangcheck to prevent persistent batches from

Re: [Intel-gfx] [PATCH 12/15] drm/i915/gem: Cancel non-persistent contexts on close

2019-10-14 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-10-14 14:10:30) > > On 14/10/2019 13:21, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2019-10-14 13:11:46) > >> > >> On 14/10/2019 10:07, Chris Wilson wrote: > >>> Normally, we rely on our hangcheck to prevent persistent batches from > >>> hogging the GPU. However,

Re: [Intel-gfx] [PATCH 12/15] drm/i915/gem: Cancel non-persistent contexts on close

2019-10-14 Thread Tvrtko Ursulin
On 14/10/2019 13:21, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-10-14 13:11:46) On 14/10/2019 10:07, Chris Wilson wrote: Normally, we rely on our hangcheck to prevent persistent batches from hogging the GPU. However, if the user disables hangcheck, this mechanism breaks down. Despite

Re: [Intel-gfx] [PATCH 12/15] drm/i915/gem: Cancel non-persistent contexts on close

2019-10-14 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-10-14 13:11:46) > > On 14/10/2019 10:07, Chris Wilson wrote: > > Normally, we rely on our hangcheck to prevent persistent batches from > > hogging the GPU. However, if the user disables hangcheck, this mechanism > > breaks down. Despite our insistence that this is

Re: [Intel-gfx] [PATCH 12/15] drm/i915/gem: Cancel non-persistent contexts on close

2019-10-14 Thread Tvrtko Ursulin
On 14/10/2019 10:07, Chris Wilson wrote: Normally, we rely on our hangcheck to prevent persistent batches from hogging the GPU. However, if the user disables hangcheck, this mechanism breaks down. Despite our insistence that this is unsafe, the users are equally insistent that they want to use