Re: [Intel-gfx] [PATCH 15/36] drm/i915: Mark up Ironlake ips with rpm wakerefs

2018-04-09 Thread Chris Wilson
Quoting Sagar Arun Kamble (2018-03-16 06:04:03) > i915_mch_val() called from i915_emon_status debugfs is not protected > under rpm_get and mchdev_lock. > Can that also be updated as part of this patch. Actually, we can just do that unlocked since we know that debugfs teardown is itself serialised

Re: [Intel-gfx] [PATCH 15/36] drm/i915: Mark up Ironlake ips with rpm wakerefs

2018-04-09 Thread Chris Wilson
Quoting Sagar Arun Kamble (2018-03-16 04:58:22) > > > On 3/14/2018 3:07 PM, Chris Wilson wrote: > > Currently Ironlake operates under the assumption that rpm awake (and its > > error checking is disabled). As such, we have missed a few places where we > > access registers without taking the rpm w

Re: [Intel-gfx] [PATCH 15/36] drm/i915: Mark up Ironlake ips with rpm wakerefs

2018-03-15 Thread Sagar Arun Kamble
i915_mch_val() called from i915_emon_status debugfs is not protected under rpm_get and mchdev_lock. Can that also be updated as part of this patch. Thanks, Sagar On 3/14/2018 3:07 PM, Chris Wilson wrote: Currently Ironlake operates under the assumption that rpm awake (and its error checking is

Re: [Intel-gfx] [PATCH 15/36] drm/i915: Mark up Ironlake ips with rpm wakerefs

2018-03-15 Thread Sagar Arun Kamble
On 3/14/2018 3:07 PM, Chris Wilson wrote: Currently Ironlake operates under the assumption that rpm awake (and its error checking is disabled). As such, we have missed a few places where we access registers without taking the rpm wakeref and thus trigger warnings. intel_ips being one culprit.