Re: [Intel-gfx] [PATCH 2/2] drm/i915: Avoid using rq->engine after free during i915_fence_release

2020-05-21 Thread Tvrtko Ursulin
On 21/05/2020 10:44, Chris Wilson wrote: Quoting Chris Wilson (2020-05-21 10:32:49) Quoting Chris Wilson (2020-05-21 10:27:16) Quoting Tvrtko Ursulin (2020-05-21 10:13:14) On 21/05/2020 09:53, Chris Wilson wrote: In order to be valid to dereference during the i915_fence_release, after

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Avoid using rq->engine after free during i915_fence_release

2020-05-21 Thread Chris Wilson
Quoting Chris Wilson (2020-05-21 10:32:49) > Quoting Chris Wilson (2020-05-21 10:27:16) > > Quoting Tvrtko Ursulin (2020-05-21 10:13:14) > > > > > > On 21/05/2020 09:53, Chris Wilson wrote: > > > > In order to be valid to dereference during the i915_fence_release, after > > > > retiring the fence

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Avoid using rq->engine after free during i915_fence_release

2020-05-21 Thread Chris Wilson
Quoting Chris Wilson (2020-05-21 10:27:16) > Quoting Tvrtko Ursulin (2020-05-21 10:13:14) > > > > On 21/05/2020 09:53, Chris Wilson wrote: > > > In order to be valid to dereference during the i915_fence_release, after > > > retiring the fence and releasing its refererences, we assume that > > >

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Avoid using rq->engine after free during i915_fence_release

2020-05-21 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-05-21 10:13:14) > > On 21/05/2020 09:53, Chris Wilson wrote: > > In order to be valid to dereference during the i915_fence_release, after > > retiring the fence and releasing its refererences, we assume that > > rq->engine can only be a real engine (that stay intact

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Avoid using rq->engine after free during i915_fence_release

2020-05-21 Thread Tvrtko Ursulin
On 21/05/2020 09:53, Chris Wilson wrote: In order to be valid to dereference during the i915_fence_release, after retiring the fence and releasing its refererences, we assume that rq->engine can only be a real engine (that stay intact until the device is shutdown after all fences have been