Re: [Intel-gfx] [PATCH 2/8] drm/i915/uc: Drop superfluous externs in intel_uc.h

[Joonas Lahtinen]

On ke, 2017-02-22 at 13:41 +0100, Arkadiusz Hiler wrote:
> Externs are implicit and we generally try to avoid them.
> 
> Cc: Michal Wajdeczko 
> Signed-off-by: Arkadiusz Hiler 

Yeah, for actual "extern" there's EXPORT_SYMBOL (which is not needed
here).

Reviewed-by: Joonas Lahtinen 

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 2/8] drm/i915/uc: Drop superfluous externs in intel_uc.h

[Arkadiusz Hiler]

On Fri, Feb 17, 2017 at 02:13:06PM +0100, Michal Wajdeczko wrote:
> On Fri, Feb 17, 2017 at 02:05:51PM +0100, Arkadiusz Hiler wrote:
> 
> I think one line with description will not kill us ;)

Comment title is exactly that. If you have something that won't be just
simple restatement of the title / saying what this trivial diff says
then please share.

> Reviewed-by: Michal Wajdeczko 

Thanks.

> > Cc: Michal Wajdeczko 
> > Signed-off-by: Arkadiusz Hiler 
> > ---
> >  drivers/gpu/drm/i915/intel_uc.h | 12 ++--
> >  1 file changed, 6 insertions(+), 6 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_uc.h 
> > b/drivers/gpu/drm/i915/intel_uc.h
> > index dd34a1b..41b7351 100644
> > --- a/drivers/gpu/drm/i915/intel_uc.h
> > +++ b/drivers/gpu/drm/i915/intel_uc.h
> > @@ -189,12 +189,12 @@ int intel_guc_send(struct intel_guc *guc, const u32 
> > *action, u32 len);
> >  int intel_guc_sample_forcewake(struct intel_guc *guc);
> >  
> >  /* intel_guc_loader.c */
> > -extern void intel_guc_init(struct drm_i915_private *dev_priv);
> > -extern int intel_guc_init_hw(struct drm_i915_private *dev_priv);
> > -extern void intel_guc_fini(struct drm_i915_private *dev_priv);
> > -extern const char *intel_uc_fw_status_repr(enum intel_uc_fw_status status);
> > -extern int intel_guc_suspend(struct drm_i915_private *dev_priv);
> > -extern int intel_guc_resume(struct drm_i915_private *dev_priv);
> > +void intel_guc_init(struct drm_i915_private *dev_priv);
> > +int intel_guc_init_hw(struct drm_i915_private *dev_priv);
> > +void intel_guc_fini(struct drm_i915_private *dev_priv);
> > +const char *intel_uc_fw_status_repr(enum intel_uc_fw_status status);
> > +int intel_guc_suspend(struct drm_i915_private *dev_priv);
> > +int intel_guc_resume(struct drm_i915_private *dev_priv);
> >  void intel_uc_fw_fetch(struct drm_i915_private *dev_priv,
> > struct intel_uc_fw *uc_fw);
> >  u32 intel_guc_wopcm_size(struct drm_i915_private *dev_priv);
> > -- 
> > 2.9.3
> > 

-- 
Cheers,
Arek
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 2/8] drm/i915/uc: Drop superfluous externs in intel_uc.h

[Michal Wajdeczko]

On Fri, Feb 17, 2017 at 02:05:51PM +0100, Arkadiusz Hiler wrote:

I think one line with description will not kill us ;)

Reviewed-by: Michal Wajdeczko 

> Cc: Michal Wajdeczko 
> Signed-off-by: Arkadiusz Hiler 
> ---
>  drivers/gpu/drm/i915/intel_uc.h | 12 ++--
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_uc.h b/drivers/gpu/drm/i915/intel_uc.h
> index dd34a1b..41b7351 100644
> --- a/drivers/gpu/drm/i915/intel_uc.h
> +++ b/drivers/gpu/drm/i915/intel_uc.h
> @@ -189,12 +189,12 @@ int intel_guc_send(struct intel_guc *guc, const u32 
> *action, u32 len);
>  int intel_guc_sample_forcewake(struct intel_guc *guc);
>  
>  /* intel_guc_loader.c */
> -extern void intel_guc_init(struct drm_i915_private *dev_priv);
> -extern int intel_guc_init_hw(struct drm_i915_private *dev_priv);
> -extern void intel_guc_fini(struct drm_i915_private *dev_priv);
> -extern const char *intel_uc_fw_status_repr(enum intel_uc_fw_status status);
> -extern int intel_guc_suspend(struct drm_i915_private *dev_priv);
> -extern int intel_guc_resume(struct drm_i915_private *dev_priv);
> +void intel_guc_init(struct drm_i915_private *dev_priv);
> +int intel_guc_init_hw(struct drm_i915_private *dev_priv);
> +void intel_guc_fini(struct drm_i915_private *dev_priv);
> +const char *intel_uc_fw_status_repr(enum intel_uc_fw_status status);
> +int intel_guc_suspend(struct drm_i915_private *dev_priv);
> +int intel_guc_resume(struct drm_i915_private *dev_priv);
>  void intel_uc_fw_fetch(struct drm_i915_private *dev_priv,
>   struct intel_uc_fw *uc_fw);
>  u32 intel_guc_wopcm_size(struct drm_i915_private *dev_priv);
> -- 
> 2.9.3
> 
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx