Re: [Intel-gfx] [PATCH 4/6] drm/i915: Dynamically allocate s0ix struct for VLV

2019-08-16 Thread Daniele Ceraolo Spurio
On 8/16/19 2:35 AM, Jani Nikula wrote: On Thu, 15 Aug 2019, Daniele Ceraolo Spurio wrote: This is only required for a single platform so no need to reserve the memory on all of them. This removes the last direct dependency of i915_drv.h on i915_reg.h (apart from the i915_reg_t definition).

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Dynamically allocate s0ix struct for VLV

2019-08-16 Thread Daniele Ceraolo Spurio
@@ -2229,7 +2320,7 @@ static void vlv_restore_gunit_s0ix_state(struct drm_i915_private *dev_priv) I915_WRITE(GEN7_GFX_PEND_TLB0, s->gfx_pend_tlb0); I915_WRITE(GEN7_GFX_PEND_TLB1, s->gfx_pend_tlb1); - for (i = 0; i < ARRAY_SIZE(s->lra_limits); i++) + for (i =

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Dynamically allocate s0ix struct for VLV

2019-08-16 Thread Jani Nikula
On Fri, 16 Aug 2019, Chris Wilson wrote: > Quoting Jani Nikula (2019-08-16 10:35:08) >> On Thu, 15 Aug 2019, Daniele Ceraolo Spurio >> wrote: >> > @@ -1622,7 +1560,7 @@ struct drm_i915_private { >> > u32 suspend_count; >> > bool power_domains_suspended; >> > struct

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Dynamically allocate s0ix struct for VLV

2019-08-16 Thread Chris Wilson
Quoting Jani Nikula (2019-08-16 10:35:08) > On Thu, 15 Aug 2019, Daniele Ceraolo Spurio > wrote: > > @@ -1622,7 +1560,7 @@ struct drm_i915_private { > > u32 suspend_count; > > bool power_domains_suspended; > > struct i915_suspend_saved_registers regfile; > > - struct

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Dynamically allocate s0ix struct for VLV

2019-08-16 Thread Jani Nikula
On Thu, 15 Aug 2019, Daniele Ceraolo Spurio wrote: > This is only required for a single platform so no need to reserve the > memory on all of them. > > This removes the last direct dependency of i915_drv.h on i915_reg.h > (apart from the i915_reg_t definition). > > Signed-off-by: Daniele Ceraolo

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Dynamically allocate s0ix struct for VLV

2019-08-15 Thread Lucas De Marchi
On Thu, Aug 15, 2019 at 6:24 PM Daniele Ceraolo Spurio wrote: > > This is only required for a single platform so no need to reserve the > memory on all of them. > > This removes the last direct dependency of i915_drv.h on i915_reg.h > (apart from the i915_reg_t definition). > > Signed-off-by: