Re: [Intel-gfx] [PATCH i-g-t v3] tools: Add intel_dp_compliance for DisplayPort 1.2 compliance automation

2017-01-18 Thread Manasi Navare 
On Wed, Jan 11, 2017 at 03:44:12PM +0200, Petri Latvala wrote:
> 
> Hi
> 
> The copyright statements still need the year
> corrected. intel_dp_compliance needs to be added to tools/.gitignore
> 
> Some new comments also:
> 
> - Why do some of the prints have \r\n?

The \r\n is required in some of the prints so that the output prints are 
properly aligned.


> - Building intel_dp_compliance should actually be made conditional upon 
> HAVE_UDEV
>
I didnt find any conditional HAVE_UDEV builds in the existing Makefile.
How can I build intel-dp_compliance conditionally on HAVE_UDEV?
Could you point me to some example in the existing Makefile?

Manasi 
> 
> 
> --
> Petri Latvala
> 
> 
> 
> On Fri, Dec 23, 2016 at 09:47:48AM +0200, Pandiyan, Dhinakaran wrote:
> > I have addressed review comments that Petri, Jim had for this patch along 
> > with making some small changes for error handling. The functionality is 
> > mostly unchanged from Manasi's version.
> > 
> > -DK
> > 
> > From: Pandiyan, Dhinakaran
> > Sent: Thursday, December 22, 2016 11:41 PM
> > To: intel-gfx@lists.freedesktop.org
> > Cc: jim.br...@linux.intel.com; Navare, Manasi D; Latvala, Petri; Vlad, 
> > Marius C; Daniel Vetter; Pandiyan, Dhinakaran
> > Subject: [PATCH i-g-t v3] tools: Add intel_dp_compliance for DisplayPort 
> > 1.2 compliance automation
> > 
> > From: "Navare, Manasi D" 
> > 
> > This is the userspace component of the Displayport Compliance
> > testing software required for compliance testing of the I915
> > Display Port driver. This must be running in order to successfully
> > complete Display Port compliance testing. This app and the kernel
> > code that accompanies it has been written to satify the requirements
> > of the Displayport Link CTS 1.2 rev1.1 specification from VESA.
> > Note that this application does not support eDP compliance testing.
> > This utility has an automation support for the Link training tests
> > (4.3.1.1. - 4.3.2.3), EDID tests (4.2.2.3
> > - 4.2.2.6) and Video Pattern generation tests (4.3.3.1) from CTS
> > specification 1.2 Rev 1.1.
> > 
> > This tool has the support for responding to the hotplug uevents
> > sent by compliance testting unit after each test.
> > 
> > The Linux DUT running this utility must be in text (console) mode
> > and cannot have any other display manager running. Since this uses
> > sysfs nodes for kernel interaction, this utility should be run as
> > Root. Once this user application is up and running, waiting for
> > test requests, the test appliance software on the windows host
> > can now be used to execute the compliance tests.
> > 
> > This app is based on some prior work done in April 2015 (by
> > Todd Previte )
> > 
> > v2:
> > * Add mode unset on hotplug uevent on disconnect (Manasi Navare)
> > 
> > v3:
> > Made capitalization consistent
> > Reduced line lengths
> > Added return value checks
> > Changed how GLib is linked
> > Fixed build warnings
> > 
> > Cc: Petri Latvala 
> > Cc: Marius Vlad 
> > Cc: Daniel Vetter 
> > Signed-off-by: Manasi Navare 
> > Signed-off-by: Dhinakaran Pandiyan 
> > ---
> >  tools/Makefile.am   |1 +
> >  tools/Makefile.sources  |7 +
> >  tools/intel_dp_compliance.c | 1104 
> > +++
> >  tools/intel_dp_compliance.h |   35 ++
> >  tools/intel_dp_compliance_hotplug.c |  123 
> >  5 files changed, 1270 insertions(+)
> >  create mode 100644 tools/intel_dp_compliance.c
> >  create mode 100644 tools/intel_dp_compliance.h
> >  create mode 100644 tools/intel_dp_compliance_hotplug.c
> > 
> > diff --git a/tools/Makefile.am b/tools/Makefile.am
> > index 18f86f6..bd8f512 100644
> > --- a/tools/Makefile.am
> > +++ b/tools/Makefile.am
> > @@ -16,6 +16,7 @@ AM_CFLAGS = $(DEBUG_CFLAGS) $(DRM_CFLAGS) 
> > $(PCIACCESS_CFLAGS) $(CWARNFLAGS) \
> >  LDADD = $(top_builddir)/lib/libintel_tools.la
> >  AM_LDFLAGS = -Wl,--as-needed
> > 
> > +intel_dp_compliance_LDADD = $(top_builddir)/lib/libintel_tools.la 
> > $(GLIB_LIBS)
> > 
> >  # aubdumper
> > 
> > diff --git a/tools/Makefile.sources b/tools/Makefile.sources
> > index e2451ea..e8ce891 100644
> > --- a/tools/Makefile.sources
> > +++ b/tools/Makefile.sources
> > @@ -13,6 +13,7 @@ tools_prog_lists =\
> > intel_bios_reader   \
> > intel_display_crc   \
> > intel_display_poller\
> > +   intel_dp_compliance \
> > intel_forcewaked\
> > intel_gpu_frequency \
> > intel_firmware_decode   \
> > @@ -56,3 +57,9 @@ intel_l3_parity_SOURCES = \
> > intel_l3_parity.h   \
> > intel_l3_udev_listener.c
> > 
> > +intel_dp_compliance_SOURCES = \
> > +intel_dp_compliance.c \
> > +intel_dp_compliance.h \
>

Re: [Intel-gfx] [PATCH i-g-t v3] tools: Add intel_dp_compliance for DisplayPort 1.2 compliance automation

2017-01-11 Thread Petri Latvala 

Hi

The copyright statements still need the year
corrected. intel_dp_compliance needs to be added to tools/.gitignore

Some new comments also:

- Why do some of the prints have \r\n?
- Building intel_dp_compliance should actually be made conditional upon 
HAVE_UDEV



--
Petri Latvala



On Fri, Dec 23, 2016 at 09:47:48AM +0200, Pandiyan, Dhinakaran wrote:
> I have addressed review comments that Petri, Jim had for this patch along 
> with making some small changes for error handling. The functionality is 
> mostly unchanged from Manasi's version.
> 
> -DK
> 
> From: Pandiyan, Dhinakaran
> Sent: Thursday, December 22, 2016 11:41 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: jim.br...@linux.intel.com; Navare, Manasi D; Latvala, Petri; Vlad, Marius 
> C; Daniel Vetter; Pandiyan, Dhinakaran
> Subject: [PATCH i-g-t v3] tools: Add intel_dp_compliance for DisplayPort 1.2 
> compliance automation
> 
> From: "Navare, Manasi D" 
> 
> This is the userspace component of the Displayport Compliance
> testing software required for compliance testing of the I915
> Display Port driver. This must be running in order to successfully
> complete Display Port compliance testing. This app and the kernel
> code that accompanies it has been written to satify the requirements
> of the Displayport Link CTS 1.2 rev1.1 specification from VESA.
> Note that this application does not support eDP compliance testing.
> This utility has an automation support for the Link training tests
> (4.3.1.1. - 4.3.2.3), EDID tests (4.2.2.3
> - 4.2.2.6) and Video Pattern generation tests (4.3.3.1) from CTS
> specification 1.2 Rev 1.1.
> 
> This tool has the support for responding to the hotplug uevents
> sent by compliance testting unit after each test.
> 
> The Linux DUT running this utility must be in text (console) mode
> and cannot have any other display manager running. Since this uses
> sysfs nodes for kernel interaction, this utility should be run as
> Root. Once this user application is up and running, waiting for
> test requests, the test appliance software on the windows host
> can now be used to execute the compliance tests.
> 
> This app is based on some prior work done in April 2015 (by
> Todd Previte )
> 
> v2:
> * Add mode unset on hotplug uevent on disconnect (Manasi Navare)
> 
> v3:
> Made capitalization consistent
> Reduced line lengths
> Added return value checks
> Changed how GLib is linked
> Fixed build warnings
> 
> Cc: Petri Latvala 
> Cc: Marius Vlad 
> Cc: Daniel Vetter 
> Signed-off-by: Manasi Navare 
> Signed-off-by: Dhinakaran Pandiyan 
> ---
>  tools/Makefile.am   |1 +
>  tools/Makefile.sources  |7 +
>  tools/intel_dp_compliance.c | 1104 
> +++
>  tools/intel_dp_compliance.h |   35 ++
>  tools/intel_dp_compliance_hotplug.c |  123 
>  5 files changed, 1270 insertions(+)
>  create mode 100644 tools/intel_dp_compliance.c
>  create mode 100644 tools/intel_dp_compliance.h
>  create mode 100644 tools/intel_dp_compliance_hotplug.c
> 
> diff --git a/tools/Makefile.am b/tools/Makefile.am
> index 18f86f6..bd8f512 100644
> --- a/tools/Makefile.am
> +++ b/tools/Makefile.am
> @@ -16,6 +16,7 @@ AM_CFLAGS = $(DEBUG_CFLAGS) $(DRM_CFLAGS) 
> $(PCIACCESS_CFLAGS) $(CWARNFLAGS) \
>  LDADD = $(top_builddir)/lib/libintel_tools.la
>  AM_LDFLAGS = -Wl,--as-needed
> 
> +intel_dp_compliance_LDADD = $(top_builddir)/lib/libintel_tools.la 
> $(GLIB_LIBS)
> 
>  # aubdumper
> 
> diff --git a/tools/Makefile.sources b/tools/Makefile.sources
> index e2451ea..e8ce891 100644
> --- a/tools/Makefile.sources
> +++ b/tools/Makefile.sources
> @@ -13,6 +13,7 @@ tools_prog_lists =\
> intel_bios_reader   \
> intel_display_crc   \
> intel_display_poller\
> +   intel_dp_compliance \
> intel_forcewaked\
> intel_gpu_frequency \
> intel_firmware_decode   \
> @@ -56,3 +57,9 @@ intel_l3_parity_SOURCES = \
> intel_l3_parity.h   \
> intel_l3_udev_listener.c
> 
> +intel_dp_compliance_SOURCES = \
> +intel_dp_compliance.c \
> +intel_dp_compliance.h \
> +intel_dp_compliance_hotplug.c \
> +$(NULL)
> +
> diff --git a/tools/intel_dp_compliance.c b/tools/intel_dp_compliance.c
> new file mode 100644
> index 000..df1ca10
> --- /dev/null
> +++ b/tools/intel_dp_compliance.c
> @@ -0,0 +1,1104 @@
> +/*
> + * Copyright © 2014 Intel Corporation
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a
> + * copy of this software and associated documentation files (the "Software"),
> + * to deal in the Software without restriction, including without limitation
> + * the rights to use, copy, modify, merge, publish,

Re: [Intel-gfx] [PATCH i-g-t v3] tools: Add intel_dp_compliance for DisplayPort 1.2 compliance automation

2016-12-22 Thread Pandiyan, Dhinakaran 
I have addressed review comments that Petri, Jim had for this patch along with 
making some small changes for error handling. The functionality is mostly 
unchanged from Manasi's version.

-DK

From: Pandiyan, Dhinakaran
Sent: Thursday, December 22, 2016 11:41 PM
To: intel-gfx@lists.freedesktop.org
Cc: jim.br...@linux.intel.com; Navare, Manasi D; Latvala, Petri; Vlad, Marius 
C; Daniel Vetter; Pandiyan, Dhinakaran
Subject: [PATCH i-g-t v3] tools: Add intel_dp_compliance for DisplayPort 1.2 
compliance automation

From: "Navare, Manasi D" 

This is the userspace component of the Displayport Compliance
testing software required for compliance testing of the I915
Display Port driver. This must be running in order to successfully
complete Display Port compliance testing. This app and the kernel
code that accompanies it has been written to satify the requirements
of the Displayport Link CTS 1.2 rev1.1 specification from VESA.
Note that this application does not support eDP compliance testing.
This utility has an automation support for the Link training tests
(4.3.1.1. - 4.3.2.3), EDID tests (4.2.2.3
- 4.2.2.6) and Video Pattern generation tests (4.3.3.1) from CTS
specification 1.2 Rev 1.1.

This tool has the support for responding to the hotplug uevents
sent by compliance testting unit after each test.

The Linux DUT running this utility must be in text (console) mode
and cannot have any other display manager running. Since this uses
sysfs nodes for kernel interaction, this utility should be run as
Root. Once this user application is up and running, waiting for
test requests, the test appliance software on the windows host
can now be used to execute the compliance tests.

This app is based on some prior work done in April 2015 (by
Todd Previte )

v2:
* Add mode unset on hotplug uevent on disconnect (Manasi Navare)

v3:
Made capitalization consistent
Reduced line lengths
Added return value checks
Changed how GLib is linked
Fixed build warnings

Cc: Petri Latvala 
Cc: Marius Vlad 
Cc: Daniel Vetter 
Signed-off-by: Manasi Navare 
Signed-off-by: Dhinakaran Pandiyan 
---
 tools/Makefile.am   |1 +
 tools/Makefile.sources  |7 +
 tools/intel_dp_compliance.c | 1104 +++
 tools/intel_dp_compliance.h |   35 ++
 tools/intel_dp_compliance_hotplug.c |  123 
 5 files changed, 1270 insertions(+)
 create mode 100644 tools/intel_dp_compliance.c
 create mode 100644 tools/intel_dp_compliance.h
 create mode 100644 tools/intel_dp_compliance_hotplug.c

diff --git a/tools/Makefile.am b/tools/Makefile.am
index 18f86f6..bd8f512 100644
--- a/tools/Makefile.am
+++ b/tools/Makefile.am
@@ -16,6 +16,7 @@ AM_CFLAGS = $(DEBUG_CFLAGS) $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) 
$(CWARNFLAGS) \
 LDADD = $(top_builddir)/lib/libintel_tools.la
 AM_LDFLAGS = -Wl,--as-needed

+intel_dp_compliance_LDADD = $(top_builddir)/lib/libintel_tools.la $(GLIB_LIBS)

 # aubdumper

diff --git a/tools/Makefile.sources b/tools/Makefile.sources
index e2451ea..e8ce891 100644
--- a/tools/Makefile.sources
+++ b/tools/Makefile.sources
@@ -13,6 +13,7 @@ tools_prog_lists =\
intel_bios_reader   \
intel_display_crc   \
intel_display_poller\
+   intel_dp_compliance \
intel_forcewaked\
intel_gpu_frequency \
intel_firmware_decode   \
@@ -56,3 +57,9 @@ intel_l3_parity_SOURCES = \
intel_l3_parity.h   \
intel_l3_udev_listener.c

+intel_dp_compliance_SOURCES = \
+intel_dp_compliance.c \
+intel_dp_compliance.h \
+intel_dp_compliance_hotplug.c \
+$(NULL)
+
diff --git a/tools/intel_dp_compliance.c b/tools/intel_dp_compliance.c
new file mode 100644
index 000..df1ca10
--- /dev/null
+++ b/tools/intel_dp_compliance.c
@@ -0,0 +1,1104 @@
+/*
+ * Copyright © 2014 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE