Re: [Intel-gfx] [PATCH v2 2/7] drm/i915: Mark the ggtt_view structs as packed

2017-01-13 Thread Tvrtko Ursulin
On 13/01/2017 08:47, Chris Wilson wrote: On Fri, Jan 13, 2017 at 08:44:34AM +, Tvrtko Ursulin wrote: On 12/01/2017 21:35, Chris Wilson wrote: In the next few patches, we will depend upon there being no uninitialised bits inside the ggtt_view. To ensure this we add the __packed attribute

Re: [Intel-gfx] [PATCH v2 2/7] drm/i915: Mark the ggtt_view structs as packed

2017-01-13 Thread Chris Wilson
On Fri, Jan 13, 2017 at 08:44:34AM +, Tvrtko Ursulin wrote: > > On 12/01/2017 21:35, Chris Wilson wrote: > >In the next few patches, we will depend upon there being no > >uninitialised bits inside the ggtt_view. To ensure this we add the > >__packed attribute and double check with a build on

Re: [Intel-gfx] [PATCH v2 2/7] drm/i915: Mark the ggtt_view structs as packed

2017-01-13 Thread Tvrtko Ursulin
On 12/01/2017 21:35, Chris Wilson wrote: In the next few patches, we will depend upon there being no uninitialised bits inside the ggtt_view. To ensure this we add the __packed attribute and double check with a build on that gcc hasn't expanded the struct to include some padding bytes.