Re: [Intel-gfx] [PATCH v2 6/6] drm/i915/uc: do not free err log on uc_fini

2020-03-25 Thread John Harrison
On 3/25/2020 11:03, Daniele Ceraolo Spurio wrote: On 3/25/20 10:58 AM, John Harrison wrote: On 3/11/2020 18:16, Daniele Ceraolo Spurio wrote: we do call uc_fini if there is an issue while loading the GuC, so we can't delete in there the logs we need to debug the load failure. Moving the log fre

Re: [Intel-gfx] [PATCH v2 6/6] drm/i915/uc: do not free err log on uc_fini

2020-03-25 Thread Daniele Ceraolo Spurio
On 3/25/20 10:58 AM, John Harrison wrote: On 3/11/2020 18:16, Daniele Ceraolo Spurio wrote: we do call uc_fini if there is an issue while loading the GuC, so we can't delete in there the logs we need to debug the load failure. Moving the log free to driver remove ensures the logs stick around

Re: [Intel-gfx] [PATCH v2 6/6] drm/i915/uc: do not free err log on uc_fini

2020-03-25 Thread John Harrison
On 3/11/2020 18:16, Daniele Ceraolo Spurio wrote: we do call uc_fini if there is an issue while loading the GuC, so we can't delete in there the logs we need to debug the load failure. Moving the log free to driver remove ensures the logs stick around ong enough for us to dump them. I think this