Re: [Intel-gfx] [RFC 1/7] drm/i915: Extract sg creation into a helper

2016-10-13 Thread Chris Wilson
On Thu, Oct 13, 2016 at 10:55:12AM +0100, Tvrtko Ursulin wrote: > > On 13/10/2016 10:20, Chris Wilson wrote: > >On Thu, Oct 13, 2016 at 10:03:58AM +0100, Tvrtko Ursulin wrote: > >>From: Tvrtko Ursulin > >> > >>In order to reuse the same logic in several places in the

Re: [Intel-gfx] [RFC 1/7] drm/i915: Extract sg creation into a helper

2016-10-13 Thread Tvrtko Ursulin
On 13/10/2016 10:20, Chris Wilson wrote: On Thu, Oct 13, 2016 at 10:03:58AM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin In order to reuse the same logic in several places in the driver, extract the logic which adds pages to the sg list and does the potential

Re: [Intel-gfx] [RFC 1/7] drm/i915: Extract sg creation into a helper

2016-10-13 Thread Chris Wilson
On Thu, Oct 13, 2016 at 10:03:58AM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > In order to reuse the same logic in several places in the driver, > extract the logic which adds pages to the sg list and does the > potential coalescing, into separate functions.