Re: [Intel-gfx] [RFC v2] drm/i915: Engine discovery query

2018-04-16 Thread Lionel Landwerlin
On 16/04/18 03:11, Tvrtko Ursulin wrote: On 11/04/2018 17:32, Lionel Landwerlin wrote: Looks good to me, a few nits below. I'll try to find some time to display this information in gputop. Reviewed-by: Lionel Landwerlin Thanks! On 11/04/18 02:46, Tvrtko Ursulin wrote: From: Tvrtko Ursuli

Re: [Intel-gfx] [RFC v2] drm/i915: Engine discovery query

2018-04-16 Thread Tvrtko Ursulin
On 11/04/2018 17:32, Lionel Landwerlin wrote: Looks good to me, a few nits below. I'll try to find some time to display this information in gputop. Reviewed-by: Lionel Landwerlin Thanks! On 11/04/18 02:46, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Engine discovery query allows userspac

Re: [Intel-gfx] [RFC v2] drm/i915: Engine discovery query

2018-04-11 Thread Lionel Landwerlin
Looks good to me, a few nits below. I'll try to find some time to display this information in gputop. Reviewed-by: Lionel Landwerlin On 11/04/18 02:46, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Engine discovery query allows userspace to enumerate engines, probe their configuration features,

Re: [Intel-gfx] [RFC v2] drm/i915: Engine discovery query

2018-04-11 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-04-11 12:10:05) > > On 11/04/2018 11:27, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2018-04-11 10:46:31) > >> +/** > >> + * struct drm_i915_engine_info > >> + * > >> + * Describes one engine known to the driver, whether or not is physical > >> engine > >> + * onl

Re: [Intel-gfx] [RFC v2] drm/i915: Engine discovery query

2018-04-11 Thread Tvrtko Ursulin
On 11/04/2018 11:27, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-04-11 10:46:31) +/** + * struct drm_i915_engine_info + * + * Describes one engine known to the driver, whether or not is physical engine + * only, or it can also be targetted from userspace, and what are its + * capabilities

Re: [Intel-gfx] [RFC v2] drm/i915: Engine discovery query

2018-04-11 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-04-11 10:46:31) > +/** > + * struct drm_i915_engine_info > + * > + * Describes one engine known to the driver, whether or not is physical > engine > + * only, or it can also be targetted from userspace, and what are its > + * capabilities where applicable. > + */ > +st