Re: [PATCH 08/16] stop using obsolete xf86BlockSIGIO() and xf86UnblockSIGIO()

2025-04-09 Thread Enrico Weigelt, metux IT consult

On 21.03.25 23:07, Ville Syrjälä wrote:

On Tue, Mar 04, 2025 at 04:58:01PM +0100, Enrico Weigelt, metux IT consult 
wrote:

These are just wrappers for calling input_lock()/input_unlock() and marked
deprecated for quite a while now.


Listing the relevant xserver commit(s) would be nice here too.


28b2c880a9dbfd91e82397a0f22482d258a8b670

These only had been introduced for making transition easier for pre
input-thread drivers (so old source still compile).
Almost 10 years ago.

--
---
All racism is bad. All lives matter.
---
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287



Re: [PATCH 08/16] stop using obsolete xf86BlockSIGIO() and xf86UnblockSIGIO()

2025-03-21 Thread Ville Syrjälä
On Tue, Mar 04, 2025 at 04:58:01PM +0100, Enrico Weigelt, metux IT consult 
wrote:
> These are just wrappers for calling input_lock()/input_unlock() and marked
> deprecated for quite a while now.

Listing the relevant xserver commit(s) would be nice here too.

> 
> Signed-off-by: Enrico Weigelt, metux IT consult 
> ---
>  src/sna/sna_display.c  | 5 +++--
>  src/uxa/intel_driver.c | 4 ++--
>  2 files changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/src/sna/sna_display.c b/src/sna/sna_display.c
> index d33a88af..d4adf34f 100644
> --- a/src/sna/sna_display.c
> +++ b/src/sna/sna_display.c
> @@ -1161,11 +1161,12 @@ static inline void sigio_unblock(int was_blocked)
>  #include 
>  static inline int sigio_block(void)
>  {
> - return xf86BlockSIGIO();
> + input_lock();
> + return 0;
>  }
>  static inline void sigio_unblock(int was_blocked)
>  {
> - xf86UnblockSIGIO(was_blocked);
> + input_unlock();
>  }
>  #endif
> 
> diff --git a/src/uxa/intel_driver.c b/src/uxa/intel_driver.c
> index 9c3fe85f..79105b89 100644
> --- a/src/uxa/intel_driver.c
> +++ b/src/uxa/intel_driver.c
> @@ -641,10 +641,10 @@ redisplay_dirty(ScreenPtr screen, PixmapDirtyUpdatePtr 
> dirty)
>  intel_flush(intel);
>   if (!intel->has_prime_vmap_flush) {
>   drm_intel_bo *bo = 
> intel_uxa_get_pixmap_bo(PixmapDirtyPrimary(dirty));
> - was_blocked = xf86BlockSIGIO();
> + input_lock();
>   drm_intel_bo_map(bo, FALSE);
>   drm_intel_bo_unmap(bo);
> - xf86UnblockSIGIO(was_blocked);
> + input_unlock();
>   }
> 
>   DamageRegionProcessPending(&PixmapDirtyDst(dirty)->drawable);
> --
> 2.39.5

-- 
Ville Syrjälä
Intel