Re: [Intel-wired-lan] [PATCH iwl-next, v3 1/2] igc: Relocate RSS field definitions to igc_defines.h

2025-07-06 Thread Mor Bar-Gabay 

On 20/06/2025 13:02, Song Yoong Siang wrote:

Move the RSS field definitions related to IPv4 and IPv6 UDP from igc.h to
igc_defines.h to consolidate the RSS field definitions in a single header
file, improving code organization and maintainability.

This refactoring does not alter the functionality of the driver but
enhances the logical grouping of related constants

Reviewed-by: Kurt Kanzenbach 
Signed-off-by: Song Yoong Siang 
Reviewed-by: Aleksandr Loktionov 
Reviewed-by: Brett Creeley 
---
  drivers/net/ethernet/intel/igc/igc.h | 4 
  drivers/net/ethernet/intel/igc/igc_defines.h | 3 +++
  2 files changed, 3 insertions(+), 4 deletions(-)


Tested-by: Mor Bar-Gabay

Re: [Intel-wired-lan] [PATCH iwl-next, v3 1/2] igc: Relocate RSS field definitions to igc_defines.h

2025-06-23 Thread Brett Creeley 




On 6/20/2025 3:02 AM, Song Yoong Siang wrote:

Caution: This message originated from an External Source. Use proper caution 
when opening attachments, clicking links, or responding.


Move the RSS field definitions related to IPv4 and IPv6 UDP from igc.h to
igc_defines.h to consolidate the RSS field definitions in a single header
file, improving code organization and maintainability.

This refactoring does not alter the functionality of the driver but
enhances the logical grouping of related constants

Reviewed-by: Kurt Kanzenbach 
Signed-off-by: Song Yoong Siang 
---
  drivers/net/ethernet/intel/igc/igc.h | 4 
  drivers/net/ethernet/intel/igc/igc_defines.h | 3 +++
  2 files changed, 3 insertions(+), 4 deletions(-)


LGTM.

Reviewed-by: Brett Creeley 



diff --git a/drivers/net/ethernet/intel/igc/igc.h 
b/drivers/net/ethernet/intel/igc/igc.h
index 1525ae25fd3e..0b35e593d5ee 100644
--- a/drivers/net/ethernet/intel/igc/igc.h
+++ b/drivers/net/ethernet/intel/igc/igc.h
@@ -406,10 +406,6 @@ extern char igc_driver_name[];
  #define IGC_FLAG_RSS_FIELD_IPV4_UDPBIT(6)
  #define IGC_FLAG_RSS_FIELD_IPV6_UDPBIT(7)

-#define IGC_MRQC_ENABLE_RSS_MQ 0x0002
-#define IGC_MRQC_RSS_FIELD_IPV4_UDP0x0040
-#define IGC_MRQC_RSS_FIELD_IPV6_UDP0x0080
-
  /* RX-desc Write-Back format RSS Type's */
  enum igc_rss_type_num {
 IGC_RSS_TYPE_NO_HASH= 0,
diff --git a/drivers/net/ethernet/intel/igc/igc_defines.h 
b/drivers/net/ethernet/intel/igc/igc_defines.h
index 86b346687196..d80254f2a278 100644
--- a/drivers/net/ethernet/intel/igc/igc_defines.h
+++ b/drivers/net/ethernet/intel/igc/igc_defines.h
@@ -383,11 +383,14 @@
  #define IGC_RXDEXT_STATERR_IPE 0x4000
  #define IGC_RXDEXT_STATERR_RXE 0x8000

+#define IGC_MRQC_ENABLE_RSS_MQ 0x0002
  #define IGC_MRQC_RSS_FIELD_IPV4_TCP0x0001
  #define IGC_MRQC_RSS_FIELD_IPV40x0002
  #define IGC_MRQC_RSS_FIELD_IPV6_TCP_EX 0x0004
  #define IGC_MRQC_RSS_FIELD_IPV60x0010
  #define IGC_MRQC_RSS_FIELD_IPV6_TCP0x0020
+#define IGC_MRQC_RSS_FIELD_IPV4_UDP0x0040
+#define IGC_MRQC_RSS_FIELD_IPV6_UDP0x0080

  /* Header split receive */
  #define IGC_RFCTL_IPV6_EX_DIS  0x0001
--
2.34.1

Re: [Intel-wired-lan] [PATCH iwl-next, v3 1/2] igc: Relocate RSS field definitions to igc_defines.h

2025-06-20 Thread Loktionov, Aleksandr 



> -Original Message-
> From: Intel-wired-lan  On Behalf
> Of Song Yoong Siang
> Sent: Friday, June 20, 2025 12:03 PM
> To: Nguyen, Anthony L ; David S . Miller
> ; Eric Dumazet ; Jakub
> Kicinski ; Paolo Abeni ; Richard
> Cochran ; Alexei Starovoitov
> ; Daniel Borkmann ; Jesper
> Dangaard Brouer ; John Fastabend
> ; Gomes, Vinicius
> ; Jonathan Corbet ; Kitszel,
> Przemyslaw ; Shinas Rasheed
> ; Tian, Kevin ; Brett
> Creeley ; Blanco Alcaine, Hector
> ; Hay, Joshua A
> ; Andrew Lunn ; Keller,
> Jacob E ; Kurt Kanzenbach
> ; Marcin Szycik ;
> Brett Creeley 
> Cc: [email protected]; [email protected]; linux-
> [email protected]
> Subject: [Intel-wired-lan] [PATCH iwl-next, v3 1/2] igc: Relocate RSS
> field definitions to igc_defines.h
> 
> Move the RSS field definitions related to IPv4 and IPv6 UDP from igc.h
> to igc_defines.h to consolidate the RSS field definitions in a single
> header file, improving code organization and maintainability.
> 
> This refactoring does not alter the functionality of the driver but
> enhances the logical grouping of related constants
> 
> Reviewed-by: Kurt Kanzenbach 
> Signed-off-by: Song Yoong Siang 
Reviewed-by: Aleksandr Loktionov 
> ---
>  drivers/net/ethernet/intel/igc/igc.h | 4 
>  drivers/net/ethernet/intel/igc/igc_defines.h | 3 +++
>  2 files changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/igc/igc.h
> b/drivers/net/ethernet/intel/igc/igc.h
> index 1525ae25fd3e..0b35e593d5ee 100644
> --- a/drivers/net/ethernet/intel/igc/igc.h
> +++ b/drivers/net/ethernet/intel/igc/igc.h
> @@ -406,10 +406,6 @@ extern char igc_driver_name[];
>  #define IGC_FLAG_RSS_FIELD_IPV4_UDP  BIT(6)
>  #define IGC_FLAG_RSS_FIELD_IPV6_UDP  BIT(7)
> 
> -#define IGC_MRQC_ENABLE_RSS_MQ   0x0002
> -#define IGC_MRQC_RSS_FIELD_IPV4_UDP  0x0040
> -#define IGC_MRQC_RSS_FIELD_IPV6_UDP  0x0080
> -
>  /* RX-desc Write-Back format RSS Type's */  enum igc_rss_type_num {
>   IGC_RSS_TYPE_NO_HASH= 0,
> diff --git a/drivers/net/ethernet/intel/igc/igc_defines.h
> b/drivers/net/ethernet/intel/igc/igc_defines.h
> index 86b346687196..d80254f2a278 100644
> --- a/drivers/net/ethernet/intel/igc/igc_defines.h
> +++ b/drivers/net/ethernet/intel/igc/igc_defines.h
> @@ -383,11 +383,14 @@
>  #define IGC_RXDEXT_STATERR_IPE   0x4000
>  #define IGC_RXDEXT_STATERR_RXE   0x8000
> 
> +#define IGC_MRQC_ENABLE_RSS_MQ   0x0002
>  #define IGC_MRQC_RSS_FIELD_IPV4_TCP  0x0001
>  #define IGC_MRQC_RSS_FIELD_IPV4  0x0002
>  #define IGC_MRQC_RSS_FIELD_IPV6_TCP_EX   0x0004
>  #define IGC_MRQC_RSS_FIELD_IPV6  0x0010
>  #define IGC_MRQC_RSS_FIELD_IPV6_TCP  0x0020
> +#define IGC_MRQC_RSS_FIELD_IPV4_UDP  0x0040
> +#define IGC_MRQC_RSS_FIELD_IPV6_UDP  0x0080
> 
>  /* Header split receive */
>  #define IGC_RFCTL_IPV6_EX_DIS0x0001
> --
> 2.34.1