Re: [Intel-wired-lan] [iwl-next v3 7/8] iavf: use libie_aq_str

2025-07-24 Thread Loktionov, Aleksandr



> -Original Message-
> From: Romanowski, Rafal 
> Sent: Thursday, July 24, 2025 9:12 AM
> To: Michal Swiatkowski ; intel-
> [email protected]
> Cc: [email protected]; Lobakin, Aleksander
> ; Kitszel, Przemyslaw
> ; Kwapulinski, Piotr
> ; Loktionov, Aleksandr
> ; Jagielski, Jedrzej
> ; Zaremba, Larysa
> ; Nguyen, Anthony L
> 
> Subject: RE: [Intel-wired-lan] [iwl-next v3 7/8] iavf: use
> libie_aq_str
> 
> > -Original Message-
> > From: Intel-wired-lan  On Behalf
> > Of Michal Swiatkowski
> > Sent: Friday, April 25, 2025 8:08 AM
> > To: [email protected]
> > Cc: [email protected]; Lobakin, Aleksander
> > ; Kitszel, Przemyslaw
> > ; Kwapulinski, Piotr
> > ; Loktionov, Aleksandr
> > ; Jagielski, Jedrzej
> > ; Zaremba, Larysa
> > ; Nguyen, Anthony L
> > 
> > Subject: [Intel-wired-lan] [iwl-next v3 7/8] iavf: use libie_aq_str
> >
> > There is no need to store the err string in hw->err_str. Simplify it
> > and use common helper. hw->err_str is still used for other purpouse.
> >
> > It should be marked that previously for unknown error the numeric
> > value was passed as a string. Now the "LIBIE_AQ_RC_UNKNOWN" is used
> for such cases.
> >
> > Add libie_aminq module in iavf Kconfig.
> >
> > Reviewed-by: Przemek Kitszel 
> > Reviewed-by: Larysa Zaremba 
> > Signed-off-by: Michal Swiatkowski
> 
> > ---
> >  drivers/net/ethernet/intel/Kconfig|  1 +
> >  .../net/ethernet/intel/iavf/iavf_prototype.h  |  1 -
> > drivers/net/ethernet/intel/iavf/iavf_common.c | 52 -
> --
> >  drivers/net/ethernet/intel/iavf/iavf_main.c   |  5 +-
> >  .../net/ethernet/intel/iavf/iavf_virtchnl.c   |  2 +-
> >  5 files changed, 5 insertions(+), 56 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/intel/Kconfig
> > b/drivers/net/ethernet/intel/Kconfig
> > index d5de9bc8b1b6..29c03a9ce145 100644
> > --- a/drivers/net/ethernet/intel/Kconfig
> > +++ b/drivers/net/ethernet/intel/Kconfig
> > @@ -260,6 +260,7 @@ config I40E_DCB
> 
> 
> Tested-by: Rafal Romanowski 
> 
Reviewed-by: Aleksandr Loktionov 


Re: [Intel-wired-lan] [iwl-next v3 7/8] iavf: use libie_aq_str

2025-07-24 Thread Romanowski, Rafal
> -Original Message-
> From: Intel-wired-lan  On Behalf Of Michal
> Swiatkowski
> Sent: Friday, April 25, 2025 8:08 AM
> To: [email protected]
> Cc: [email protected]; Lobakin, Aleksander
> ; Kitszel, Przemyslaw
> ; Kwapulinski, Piotr
> ; Loktionov, Aleksandr
> ; Jagielski, Jedrzej 
> ;
> Zaremba, Larysa ; Nguyen, Anthony L
> 
> Subject: [Intel-wired-lan] [iwl-next v3 7/8] iavf: use libie_aq_str
> 
> There is no need to store the err string in hw->err_str. Simplify it and use 
> common
> helper. hw->err_str is still used for other purpouse.
> 
> It should be marked that previously for unknown error the numeric value was
> passed as a string. Now the "LIBIE_AQ_RC_UNKNOWN" is used for such cases.
> 
> Add libie_aminq module in iavf Kconfig.
> 
> Reviewed-by: Przemek Kitszel 
> Reviewed-by: Larysa Zaremba 
> Signed-off-by: Michal Swiatkowski 
> ---
>  drivers/net/ethernet/intel/Kconfig|  1 +
>  .../net/ethernet/intel/iavf/iavf_prototype.h  |  1 -
> drivers/net/ethernet/intel/iavf/iavf_common.c | 52 ---
>  drivers/net/ethernet/intel/iavf/iavf_main.c   |  5 +-
>  .../net/ethernet/intel/iavf/iavf_virtchnl.c   |  2 +-
>  5 files changed, 5 insertions(+), 56 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/Kconfig
> b/drivers/net/ethernet/intel/Kconfig
> index d5de9bc8b1b6..29c03a9ce145 100644
> --- a/drivers/net/ethernet/intel/Kconfig
> +++ b/drivers/net/ethernet/intel/Kconfig
> @@ -260,6 +260,7 @@ config I40E_DCB


Tested-by: Rafal Romanowski