Re: [Interest] Qt 6.4.3 compiler warnings in QTaggedPointer

2023-03-23 Thread Thiago Macieira
On Thursday, 23 March 2023 00:03:24 HST Hamish Moffatt via Interest wrote: > OK. There's a similar issue in QtConcurrent (unchanged since 5.15 > actually) also driving me mad - __int64 resulting from std::distance is > assigned to int. In Qt 6, that should just be qsizetype or plain auto. --

Re: [Interest] Qt 6.4.3 compiler warnings in QTaggedPointer

2023-03-23 Thread Hamish Moffatt via Interest
On 23/3/23 18:15, Thiago Macieira wrote: On Wednesday, 22 March 2023 18:19:59 HST Hamish Moffatt via Interest wrote: static constexpr quint8 tagBits = QtPrivate::qConstexprCountTrailingZeroBits(alignment); So would you fix it with a cast, or by changing the variable type to int to match the

Re: [Interest] Qt 6.4.3 compiler warnings in QTaggedPointer

2023-03-23 Thread Thiago Macieira
On Wednesday, 22 March 2023 18:19:59 HST Hamish Moffatt via Interest wrote: > static constexpr quint8 tagBits = > QtPrivate::qConstexprCountTrailingZeroBits(alignment); > > So would you fix it with a cast, or by changing the variable type to int > to match the function? Either solution is fine.

Re: [Interest] Qt 6.4.3 compiler warnings in QTaggedPointer

2023-03-22 Thread Hamish Moffatt via Interest
On 23/3/23 05:00, Thiago Macieira wrote: I don't see any changes since v6.4 that would fix that. It looks trivial though to apply an explicit cast to silence that warning. Any chance you can contribute it? I started with a bug report, anyway: QTBUG-11. static constexpr quint8 tagBits =

Re: [Interest] Qt 6.4.3 compiler warnings in QTaggedPointer

2023-03-22 Thread Hamish Moffatt via Interest
On 22/3/23 18:12, Thiago Macieira wrote: On Tuesday, 21 March 2023 20:18:17 HST Hamish Moffatt via Interest wrote: I'm porting from Qt 5.15.12 to 6.4.3, and now MSVC 2019 is giving me a ton of compiler warnings about QTaggedPointer. [cut] Any suggestions on how to shut it up? Stop using

Re: [Interest] Qt 6.4.3 compiler warnings in QTaggedPointer

2023-03-22 Thread Thiago Macieira
On Tuesday, 21 March 2023 20:18:17 HST Hamish Moffatt via Interest wrote: > I'm porting from Qt 5.15.12 to 6.4.3, and now MSVC 2019 is giving me a > ton of compiler warnings about QTaggedPointer. [cut] > Any suggestions on how to shut it up? Stop using 2019, please. That compiler has a number of