PHP 4 Bug Database summary - http://bugs.php.net
Num Status Summary (627 total including feature requests)
===[*Configuration Issues]
34604 Feedback ./configure --with-msql fails
===[Arrays
PHP 5 Bug Database summary - http://bugs.php.net
Num Status Summary (359 total including feature requests)
===[*Directory/Filesystem functions]
34552 Open Problems with __FILE__ and realpath()
This seems to fix
http://puggy.symonds.net/~kameshj/ext_pdo_sqlite_sqlite_statement.c.patch
with regards
Kamesh Jayachandran
--
http://www.fastmail.fm - Accessible with your email software
or over the web
--
PHP Internals - PHP Runtime Development Mailing List
To
Hi Sara Golemon, you wrote:
Getting there, but you can make it work for ZTS mode. Just create a proxy
for the gets function which is always set, then have the proxy do a
TSRMLS_FETCH() and examine an extension global (e.g. IMAPG(gets_mode) or
whatever) to determine whether it's in savebody()
Looks basicly alright (with a slight disagreement on how the read loop is
implemented (below). In general you've got my vote (for what it's worth
given my lack of experience with libc-client.
unsigned long i, rest = size % GETS_FETCH_SIZE;
char *buf = emalloc(GETS_FETCH_SIZE+1);
Hi Sara Golemon, you wrote:
Here's how I'd write this block, it assumed that f returns the number of
bytes actually read, but according to the proto for readfn_t it *should*
do that.
Well, unfortunately not. It seems that net_get_buffer() in mail.c is
used as standard readfn_t which only
I'd recommend adopting Sara's suggestion; those memset()s you have
there shouldn't be needed:
char buf[GETS_FETCH_SIZE];
while (ret 0) {
if (!f(stream, sizeof(buf), buf))
break;
php_stream_write_string(IMAPG(gets_stream), buf);
}
return NULL;
--Wez.
On 9/26/05, Michael Wallner
Well, unfortunately not. It seems that net_get_buffer() in mail.c is
used as standard readfn_t which only returns NIL/T i.e. 0/1.
Okay, take two:
char buf[GETS_FETCH_SIZE];
while (size 0) {
in toread = (size GETS_FETCH_SIZE) ? GETS_FETCH_SIZE : size);
if (!f(stream, toread, buf))
Hi Marcus,
This is improved version of your patch.
It breaks only two tests those must be changed. (instead of 10 those
shouldn't)
Please review.
Thanks. Dmitry.
-Original Message-
From: Marcus Boerger [mailto:[EMAIL PROTECTED]
Sent: Sunday, September 25, 2005 4:37 PM
To:
Hello Dmitry,
looks good
Monday, September 26, 2005, 8:55:30 PM, you wrote:
Hi Marcus,
This is improved version of your patch.
It breaks only two tests those must be changed. (instead of 10 those
shouldn't)
Please review.
Thanks. Dmitry.
-Original Message-
From: Marcus
Marcus,
I think you misread my email.
I said that it *should* be commited. I did want an additional two
days to review because we did *have* feedback for the patch (as you
saw). I don't know who All others are, but I don't know many who
can understand this patch to the lowest level of details.
Andi Gutmans writes:
Believe me, from a usability perspective, I think
__toString() working automagically is very nice... I'm just
being less trigger happy and want to make sure we're covered.
Humbly, this is a smart and prudent approach, to a nice piece of work
I might add.
Best,
Mike
12 matches
Mail list logo
