Re: [PHP-DEV] include bug in 5.3

2008-08-09 Thread Christian Stocker
Hi Dmitry On 8.8.2008 17:52 Uhr, Dmitry Stogov wrote: Hi, The attached patch is going to fix the problem. Works also on my OS X 10.4 box now. Thanks a lot for the effort (and if it brings a performance boost, even better :) ) chregu It implements its own realpath() function, so we

Re: [PHP-DEV] include bug in 5.3

2008-08-09 Thread Hannes Magnusson
On Fri, Aug 8, 2008 at 17:52, Dmitry Stogov [EMAIL PROTECTED] wrote: Hi, The attached patch is going to fix the problem. It implements its own realpath() function, so we won't depend on system anymore. It also improve realpath cache usage by caching intermediate results. I tested it on

Re: [PHP-DEV] include bug in 5.3

2008-08-09 Thread Dmitry Stogov
Where is it documented? The realpath() implementation conforming to 4.4BSD and POSIX.1-2001 requires file existence. With the patch it'll work in the same standard way on all systems. Thanks. Dmitry. Hannes Magnusson wrote: On Fri, Aug 8, 2008 at 17:52, Dmitry Stogov [EMAIL PROTECTED]

Re: [PHP-DEV] include bug in 5.3

2008-08-09 Thread Hannes Magnusson
On Sat, Aug 9, 2008 at 12:31, Dmitry Stogov [EMAIL PROTECTED] wrote: Where is it documented? http://php.net/realpath http://www.ipnom.com/FreeBSD-Man-Pages/realpath.3.html -Hannes -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] include bug in 5.3

2008-08-09 Thread Pierre Joye
hi all! On Sat, Aug 9, 2008 at 12:41 PM, Hannes Magnusson [EMAIL PROTECTED] wrote: On Sat, Aug 9, 2008 at 12:31, Dmitry Stogov [EMAIL PROTECTED] wrote: Where is it documented? http://php.net/realpath http://www.ipnom.com/FreeBSD-Man-Pages/realpath.3.html On BSD systems realpath() doesn't

Re: [PHP-DEV] include bug in 5.3

2008-08-09 Thread Stefan Esser
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello Dmitry, while you are at fixing realpath() it might be a good idea to fix the ../ nonsense. What I mean is: fopen(this_is_not_a_dir_but_a_file/../../../../../../../../etc/passwd, r); works because of realpath() and PHP's wrapper. Same for

Re: [PHP-DEV] clearstatcache change

2008-08-09 Thread Arnaud Le Blanc
On Thursday 07 August 2008 11:33:02 Arnaud Le Blanc wrote: On Thursday 07 August 2008 01:50:06 Johannes Schlüter wrote: On Wed, 2008-08-06 at 21:00 +0200, Arnaud Le Blanc wrote: btw. I just noticed chroot() calls this realpath_cache_clean()..intentional? I'd assume that, as /foo

Re: [PHP-DEV] include bug in 5.3

2008-08-09 Thread Dmitry Stogov
The improved patch fixes all the issues I found during testing. However I wasn't able to test it on NETWARE and on Solaris with relative paths. Please test it as much as possible. I'm going to commit it on Tuesday in case of no objections. Thanks. Dmitry. Rasmus Lerdorf wrote: Rasmus

Re: [PHP-DEV] [RFC] Zend Signal Handling

2008-08-09 Thread Arnaud Le Blanc
Hi, As Lucas said the patch seems ready now, could someone please review the patch for inclusion ? http://wiki.php.net/rfc/zendsignals Changes that have been made: - The patch has been ported to HEAD - The patch now supports multithreaded environments, and fixes many problems on non-windows

Re: [PHP-DEV] include bug in 5.3

2008-08-09 Thread Pierre Joye
hi Dmitry, On Sat, Aug 9, 2008 at 5:28 PM, Dmitry Stogov [EMAIL PROTECTED] wrote: The improved patch fixes all the issues I found during testing. However I wasn't able to test it on NETWARE and on Solaris with relative paths. Please test it as much as possible. I run the test suite and the

Re: [PHP-DEV] include bug in 5.3

2008-08-09 Thread Antony Dovgal
On 09.08.2008 19:28, Dmitry Stogov wrote: The improved patch fixes all the issues I found during testing. However I wasn't able to test it on NETWARE and on Solaris with relative paths. Please test it as much as possible. I'm going to commit it on Tuesday in case of no objections.

Re: [PHP-DEV] include bug in 5.3

2008-08-09 Thread Antony Dovgal
On 09.08.2008 19:28, Dmitry Stogov wrote: The improved patch fixes all the issues I found during testing. However I wasn't able to test it on NETWARE and on Solaris with relative paths. Please test it as much as possible. I'm going to commit it on Tuesday in case of no objections. These

[PHP-DEV] fix for a couple zend tests

2008-08-09 Thread Pierre Joye
hi! Please find the patch as attachment. It fixes a couple of tests in Zend (unset, heredoc). Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org ? bug38779.txt Index: heredoc_005.phpt === RCS file:

Re: [PHP-DEV] [RFC] Zend Signal Handling

2008-08-09 Thread Rasmus Lerdorf
Arnaud Le Blanc wrote: Hi, As Lucas said the patch seems ready now, could someone please review the patch for inclusion ? http://wiki.php.net/rfc/zendsignals Changes that have been made: - The patch has been ported to HEAD - The patch now supports multithreaded environments, and fixes many

Re: [PHP-DEV] include bug in 5.3

2008-08-09 Thread Rasmus Lerdorf
Stefan Esser wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello Dmitry, while you are at fixing realpath() it might be a good idea to fix the ../ nonsense. What I mean is: fopen(this_is_not_a_dir_but_a_file/../../../../../../../../etc/passwd, r); works because of realpath() and

Re: [PHP-DEV] fix for a couple zend tests

2008-08-09 Thread Felipe Pena
Em Dom, 2008-08-10 às 01:31 +0200, Pierre Joye escreveu: hi! Please find the patch as attachment. It fixes a couple of tests in Zend (unset, heredoc). Commited in 5_2, 5_3 and HEAD. -- Regards, Felipe Pena. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: