[PHP-DEV] ReflectionMethod::setAccessible()

2009-09-02 Thread Sebastian Bergmann
The patch below adds the ReflectionMethod::setAccessible() method and adds support for the ignore_visibility flag that is controlled by this method to ReflectionMethod::invoke() and ReflectionMethod::invokeArgs(). The patch complements ReflectionProperty::setAccessible() that was added in

Re: [PHP-DEV] ReflectionMethod::setAccessible()

2009-09-02 Thread Guilherme Blanco
This is a BC break and may possibly be rejected. Extended classes may implement a method with same name. Point is that Reflection API misses it and it should be added even prior to 5.3.0 be released. Currently there's no way to achieve such behavior. So I'm +1. Cheers, On Wed, Sep 2, 2009 at

[PHP-DEV] Fix for 49148 (combination of stream_get_line and fseek does not work correctly)

2009-09-02 Thread Garrett Serack
I finally got to the bottom of this bug. It was hiding nice and deep. I thought I'd run this by folks first before committing, as it impacts streams, which are pretty important :D . It passes the current tests, and I wrote test for it too. (below). Index: main/streams/streams.c

Re: [PHP-DEV] Fix for 49148 (combination of stream_get_line and fseek does not work correctly)

2009-09-02 Thread Stanislav Malyshev
Hi! I thought I'd run this by folks first before committing, as it impacts streams, which are pretty important :D . It passes the current tests, and I wrote test for it too. (below). I notice that the bug says it happens only on Windows, while the fix doesn't have anything specific for

[PHP-DEV] Traits Patch available for Testing and Comments on PHP 5.3 and PHP 6

2009-09-02 Thread Stefan Marr
Dear internals: Has been a while since we discussed whether the idea of Traits fits into the programming model of PHP. To encourage further discussion and experiments, I managed to update some tests, to fix some bugs, and eventually to use GitHub to make it accessible to you. Please find a

RE: [PHP-DEV] Fix for 49148 (combination of stream_get_line and fseek does not work correctly)

2009-09-02 Thread Garrett Serack
it happens on Linux and Windows. I've repro'd it in both places. The bug submitter hadn't tested elsewhere. G -Original Message- From: Stanislav Malyshev [mailto:s...@zend.com] Sent: Wednesday, September 02, 2009 2:15 PM To: Garrett Serack Cc: 'PHP Internals' Subject: Re: [PHP-DEV] Fix

[PHP-DEV] Fix for 49148 (combination of stream_get_line and fseek does not work correctly)

2009-09-02 Thread Hans Ã…hlin
I just ran the test on Linux 2.6.29 FC11 Apache 2.2.13 and PHP 5.2.9 Result: string 'line1' (length=5) string '' (length=0) string 'line1' (length=5) string '' (length=0) string 'line1' (length=5) string 'line2' (length=5) string 'line1' (length=5) boolean false string 'line1' (length=5) string