[PHP-DEV] Re: PDO Bug introduced in revision 290786 and released in 5.2.12 and5.3.1

2010-01-16 Thread Karsten Dambekalns
Hi. On 16.01.10 02:54, Matt Read wrote: We are developers from the Habari Project, an open source PHP blogging application; We would like to raise concern with a recent change to the logic of PDO. I fully support what Matt writes. Although we don't use that behaviour in our codebase, the way

[PHP-DEV] Compiling PHP-GTK with PHP-5.3.1

2010-01-16 Thread Thomas Worm
Hello, I tried to compile PHP-GTK 2.0.1 with PHP 5.3.1 on Windows. The first errors I was able to fix. The patch file with my fixes you find as an attachment to this mail. But now I get following error and I don't know why. VC9 doesn't find the SG-definition, but SAPI.h is included in

[PHP-DEV] Debian PHP patches

2010-01-16 Thread Johannes Schlüter
Raphael, I went over your patches from http://patch-tracker.debian.org/package/php5/5.3.1-2 and did quick reviews (didn't apply / test them or anything ...) Here some comments: 004-ldap_fix.patch: Do you have a test for this? when does it happen that ldap_value is NULL happen? - If that's

Re: [PHP-DEV] Throwing an E_DEPRECATED for short_open_tag

2010-01-16 Thread Raphael Geissert
Patrick ALLAERT wrote: 2010/1/13 Derick Rethans der...@php.net: On Tue, 12 Jan 2010, Raphael Geissert wrote: [snip] Would it be possible to force short_open_tag to a specific value for those applications alone? Perhaps through an .htaccess file? That way, Debian keeps the PHP default

Re: [PHP-DEV] Throwing an E_DEPRECATED for short_open_tag

2010-01-16 Thread Rasmus Lerdorf
Raphael Geissert wrote: Patrick ALLAERT wrote: 2010/1/13 Derick Rethans der...@php.net: On Tue, 12 Jan 2010, Raphael Geissert wrote: [snip] Would it be possible to force short_open_tag to a specific value for those applications alone? Perhaps through an .htaccess file? That way, Debian

Re: [PHP-DEV] Debian PHP patches

2010-01-16 Thread Raphael Geissert
Johannes, Johannes Schlüter wrote: Raphael, I went over your patches from http://patch-tracker.debian.org/package/php5/5.3.1-2 and did quick reviews (didn't apply / test them or anything ...) Although I would have preferred you wait for me to submit each patch individually with enough

Re: [PHP-DEV] Debian PHP patches

2010-01-16 Thread Jani Taskinen
16.1.2010 20:10, Raphael Geissert wrote: Some of the other patches include: libdb_is_-ldb Why? Potentially breaks things when you assume db/ being correct place.. 115-autoconf_ftbfs.patch Hell no. You're breaking the configure again with this crap. I already reverted the idiocy once,

Re: [PHP-DEV] Debian PHP patches

2010-01-16 Thread Gwynne Raskind
On Jan 16, 2010, at 4:18 PM, Jani Taskinen wrote: 115-autoconf_ftbfs.patch Hell no. You're breaking the configure again with this crap. I already reverted the idiocy once, don't even think about doing this shit again. PHP configure works properly only with autoconf-2.13 which was the last

Re: [PHP-DEV] Debian PHP patches

2010-01-16 Thread Alexey Zakhlestin
On 17.01.2010, at 1:05, Gwynne Raskind wrote: On Jan 16, 2010, at 4:18 PM, Jani Taskinen wrote: 115-autoconf_ftbfs.patch Hell no. You're breaking the configure again with this crap. I already reverted the idiocy once, don't even think about doing this shit again. PHP configure works

Re: [PHP-DEV] Debian PHP patches

2010-01-16 Thread Jani Taskinen
17.1.2010 0:29, Alexey Zakhlestin wrote: On 17.01.2010, at 1:05, Gwynne Raskind wrote: On Jan 16, 2010, at 4:18 PM, Jani Taskinen wrote: 115-autoconf_ftbfs.patch Hell no. You're breaking the configure again with this crap. I already reverted the idiocy once, don't even think about doing

[PHP-DEV] Can we call Apache 2 API function from a PHP 5 extension module?

2010-01-16 Thread rwe rt
Hi all,I compiled php-5.3.1 with apache 2.2.14 as DSO and wanted to test how to call Apache API from a PHP module:Run ./ext_skel --extname=helloModified ext/hello.c and the function PHP_FUNCTION(confirm_hello_compiled) so that it contains #include SAPI.h #include httpd.h #include http_config.h

Re: [PHP-DEV] Debian PHP patches

2010-01-16 Thread Raphael Geissert
Jani Taskinen wrote: 16.1.2010 20:10, Raphael Geissert wrote: Some of the other patches include: libdb_is_-ldb Why? Potentially breaks things when you assume db/ being correct place.. Do you have an example of any actual case? 115-autoconf_ftbfs.patch Hell no. You're breaking the

Re: [PHP-DEV] Debian PHP patches

2010-01-16 Thread Rasmus Lerdorf
Raphael Geissert wrote: Can you tell me what exactly we are breaking? divert calls should only be used internally by autoconf and the, apparently useless, usage of them in php makes it fail to build with any other autoconf. Have a look in the archives. I tried getting the divert stuff

Re: [PHP-DEV] Can we call Apache 2 API function from a PHP 5 extension module?

2010-01-16 Thread Brian J. France
Try this instead: request_rec *r = (request_rec *)(((SG(server_context) == NULL) ? NULL : ((php_struct*)SG(server_context))-r)); Apache 2.x server_context is not a request_rec, it is a struct with a request rec in it. Brian On Jan 16, 2010, at 7:25 PM, rwe rt wrote: Hi all,I compiled

Re: [PHP-DEV] Inconsistency redesign

2010-01-16 Thread Richard Lynch
Never use empty() I've been burned by this too many times. It's behaviour around '0' and friends changed over the years. Some colleagues at a former job looked at me funny when they first heard my rant about this. Then they tracked down 3 separate bugs and fixed them, all deriving from the use

Re: [PHP-DEV] Can we call Apache 2 API function from a PHP 5 extension module?

2010-01-16 Thread mm w
yep nevermind I don't you post this question on php-internal and don't understand this ugly suggestion, Brian when I read your cv it seems to be something serious ... when I see the line with your type recasting I am not sure you understood something during these 15 years. Best On Sat, Jan 16,