[PHP-DEV] [PATCH] Add missing PHP_ATTRIBUTE_FORMAT to printf style functions

2010-12-27 Thread Cristian Rodríguez
Signed-off-by: Cristian Rodríguez cristian.rodrig...@opensuse.org --- main/snprintf.h | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/main/snprintf.h b/main/snprintf.h index 201a5cb..4371f6a 100644 --- a/main/snprintf.h +++ b/main/snprintf.h @@ -78,12 +78,12

[PHP-DEV] [PATCH] Fix two broken tests

2010-12-27 Thread Cristian Rodríguez
Signed-off-by: Cristian Rodríguez cristian.rodrig...@opensuse.org --- ext/date/tests/bug51819.phpt |1 + ext/phar/tests/bug52013.phpt |2 +- 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/ext/date/tests/bug51819.phpt b/ext/date/tests/bug51819.phpt index afcb9c7..7e9bbec

[PHP-DEV] [PATCH] fix memory leak in fpm_conf_set_array()

2010-12-27 Thread Cristian Rodríguez
Signed-off-by: Cristian Rodríguez cristian.rodrig...@opensuse.org --- sapi/fpm/fpm/fpm_conf.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/sapi/fpm/fpm/fpm_conf.c b/sapi/fpm/fpm/fpm_conf.c index 5d6fe77..5bd7e7c 100644 --- a/sapi/fpm/fpm/fpm_conf.c +++

Re: [PHP-DEV] [PATCH] Fix two broken tests

2010-12-27 Thread Pierre Joye
hi Christian, Please open a bug for each issue and attach the patch there, so it won't be lost :) Thanks for your work! On Mon, Dec 27, 2010 at 11:41 PM, Cristian Rodríguez cristian.rodrig...@opensuse.org wrote: Signed-off-by: Cristian Rodríguez cristian.rodrig...@opensuse.org ---  

Re: [PHP-DEV] [PATCH] fix memory leak in fpm_conf_set_array()

2010-12-27 Thread Antony Dovgal
On 12/28/2010 01:50 AM, Cristian Rodríguez wrote: - if (err) return err; + if (err) { free(kv); return err;} I believe the patch is a bit more complicated than that. Here is new version: http://dev.daylessday.org/diff/fpm_leaks.diff Could you test it please? -- Wbr,