Re: [PHP-DEV] [RFC] GitHub Pull Requests Triage Team

2014-11-17 Thread Stanislav Malyshev
Hi! > I like the label idea, it will help having a nice overall look on the PRs. > > When I myself find some time, I mainly browse through bugs.php.net and > fix things and close issues. As an experiment, I went and added a bunch of labels to github: RFC - for RFC PRs bugfix - for fixes associat

Re: [PHP-DEV] Re: Use zend_string* for op_array->arg_info[].name and class_name

2014-11-17 Thread Stanislav Malyshev
Hi! >> we only need do it in master process, and mark as interned(with hash >> precalculated), no write will be happened, so thanks to COW on fork, we >> won't need lots of extra memory. >> > > It's not true for Windows. > On Linux we would copy arg_info from shared read-only segment into process

[PHP-DEV] Re: Use zend_string* for op_array->arg_info[].name and class_name

2014-11-17 Thread Dmitry Stogov
On Tue, Nov 18, 2014 at 7:49 AM, Xinchen Hui wrote: > > > Sent from my iPhone > > On Nov 18, 2014, at 12:34 PM, Dmitry Stogov wrote: > > > > On Tue, Nov 18, 2014 at 6:01 AM, Xinchen Hui wrote: > >> Hey: >> >> >> >> On Mon, Nov 17, 2014 at 5:25 PM, Dmitry Stogov wrote: >> > Hi, >> > >> > Please

[PHP-DEV] Re: Use zend_string* for op_array->arg_info[].name and class_name

2014-11-17 Thread Xinchen Hui
Sent from my iPhone > On Nov 18, 2014, at 12:34 PM, Dmitry Stogov wrote: > > > >> On Tue, Nov 18, 2014 at 6:01 AM, Xinchen Hui wrote: >> Hey: >> >> >> >> On Mon, Nov 17, 2014 at 5:25 PM, Dmitry Stogov wrote: >> > Hi, >> > >> > Please review the patch >> > https://gist.github.com/dstogo

[PHP-DEV] Re: Use zend_string* for op_array->arg_info[].name and class_name

2014-11-17 Thread Dmitry Stogov
On Tue, Nov 18, 2014 at 6:01 AM, Xinchen Hui wrote: > Hey: > > > > On Mon, Nov 17, 2014 at 5:25 PM, Dmitry Stogov wrote: > > Hi, > > > > Please review the patch > https://gist.github.com/dstogov/47a39aff37f0a6441ea0 > > I am not sure, why can't we build a zend_string arg->name from char * > whi

[PHP-DEV] Re: Use zend_string* for op_array->arg_info[].name and class_name

2014-11-17 Thread Xinchen Hui
Hey: On Mon, Nov 17, 2014 at 5:25 PM, Dmitry Stogov wrote: > Hi, > > Please review the patch https://gist.github.com/dstogov/47a39aff37f0a6441ea0 I am not sure, why can't we build a zend_string arg->name from char * while doing register internal functions? then we can have the same zend_arg_

Re: [PHP-DEV] Re: PHP-FPM state

2014-11-17 Thread Ferenc Kovacs
On Mon, Nov 17, 2014 at 4:24 PM, Remi Collet wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Le 15/11/2014 11:11, Ferenc Kovacs a écrit : > > > Yeah, the test coverage of fpm is lacking, and while this PR > > contained a test for testing the happy path (that you can listen on > > ipv

Re: [PHP-DEV] Re: PHP-FPM state

2014-11-17 Thread Remi Collet
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Le 15/11/2014 11:11, Ferenc Kovacs a écrit : > Yeah, the test coverage of fpm is lacking, and while this PR > contained a test for testing the happy path (that you can listen on > ipv6) but there were no tests which could have helped us to spot > the

Re: [PHP-DEV] Re: PHP-FPM state

2014-11-17 Thread Ferenc Kovacs
On Mon, Nov 17, 2014 at 12:38 PM, Pierre Joye wrote: > > On Nov 17, 2014 4:26 PM, "Matteo Beccati" wrote: > > > > On 15/11/2014 11:11, Ferenc Kovacs wrote: > > > 2014.11.15. 8:28 ezt írta ("Remi Collet" > > > ): > > >> > > > FPM state in 5.5.19 / 5.6.3 is quite bad :( > > > > Maybe I'm saying so

Re: [PHP-DEV] Re: PHP-FPM state

2014-11-17 Thread Pierre Joye
On Nov 17, 2014 4:26 PM, "Matteo Beccati" wrote: > > On 15/11/2014 11:11, Ferenc Kovacs wrote: > > 2014.11.15. 8:28 ezt írta ("Remi Collet" > > ): > >> > > FPM state in 5.5.19 / 5.6.3 is quite bad :( > > Maybe I'm saying something unpopular, but wouldn't it be better to > rollback the fpm changes,

Re: [PHP-DEV] Re: PHP-FPM state

2014-11-17 Thread Matteo Beccati
On 15/11/2014 11:11, Ferenc Kovacs wrote: > 2014.11.15. 8:28 ezt írta ("Remi Collet" > ): >> > FPM state in 5.5.19 / 5.6.3 is quite bad :( Maybe I'm saying something unpopular, but wouldn't it be better to rollback the fpm changes, release 5.5.20 and 5.6.4 and keep fpm+ipv6 for master? Cheers -

[PHP-DEV] Use zend_string* for op_array->arg_info[].name and class_name

2014-11-17 Thread Dmitry Stogov
Hi, Please review the patch https://gist.github.com/dstogov/47a39aff37f0a6441ea0 Thanks. Dmitry.

Re: [PHP-DEV] Re: PHP-FPM state

2014-11-17 Thread Remi Collet
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Le 15/11/2014 08:27, Remi Collet a écrit : I have also fixed: https://bugs.php.net/68428 listen.allowed_clients is IPv4 only > SO PLEASE, everyone who can test these patches, please test and > give feedback [1] Really lot of change

Re: [PHP-DEV] SAPI refactoring

2014-11-17 Thread Florian Margaine
Hi Joe, On Mon, Nov 17, 2014 at 8:42 AM, Joe Watkins wrote: > On Sat, 2014-11-15 at 11:16 +0100, Florian Margaine wrote: > > Hi list, > > > > As of today, most of the SAPIs have a lot of code duplication with > > regards to HTTP headers parsing/handling. > > > > I'm about to completely duplicate