Re: [PHP-DEV] [RFC][Discussion] Return Type Variance Checking

2014-11-26 Thread Simon Schick
On Tue, Nov 25, 2014 at 11:42 PM, Nikita Popov nikita@gmail.com wrote: On Tue, Nov 25, 2014 at 11:13 PM, Marc Bennewitz dev@mabe.berlin wrote: Am 25.11.2014 um 22:43 schrieb Levi Morrison: On Tue, Nov 25, 2014 at 2:07 PM, Marc Bennewitz dev@mabe.berlin wrote: I think it's required to

[PHP-DEV] [VOTE][RFC] Access to aliases definition by reflection

2014-11-26 Thread Miloslav Hůla
Good morning internals, after several weeks, I'm opening voting process for the RFC https://wiki.php.net/rfc/aliases_by_reflection. Thank you, Milo -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] [RFC][Discussion] Return Type Variance Checking

2014-11-26 Thread Lazare Inepologlou
2014-11-25 23:42 GMT+01:00 Nikita Popov nikita@gmail.com: On Tue, Nov 25, 2014 at 11:13 PM, Marc Bennewitz dev@mabe.berlin wrote: Am 25.11.2014 um 22:43 schrieb Levi Morrison: On Tue, Nov 25, 2014 at 2:07 PM, Marc Bennewitz dev@mabe.berlin wrote: I think it's required to do

[PHP-DEV] Popups in the cgi win binaries

2014-11-26 Thread Anatol Belski
Hi, while investigating on https://bugs.php.net/bug.php?id=68297 it turned out, the MessageBox'es we have on several places lead to issues. This particular ticket describes firstly an insufficient error message, but secondly - it goes into a popup which is then automatically logged to the event

Re: [PHP-DEV] Popups in the cgi win binaries

2014-11-26 Thread Rowan Collins
Anatol Belski wrote on 26/11/2014 11:34: While it might look short cut and too late for 5.5, there's indeed no scenario imaginable where such graphical elements could be used even as a feature. Neither on console nor as a server module or CGI. Deciding what releases something lands in is not

Re: [PHP-DEV] Fwd: [php-src] Constant-Time bin2hex() implementation (#909)

2014-11-26 Thread Rasmus Lerdorf
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/25/2014 07:37 AM, Scott Arciszewski wrote: I would like to, at the minimum, suggest making the following functions run in constant time: * bin2hex() * hex2bin() * base64_encode() * base64_decode() * mcrypt_encrypt() -- requires delving

Re: [PHP-DEV] Fwd: [php-src] Constant-Time bin2hex() implementation (#909)

2014-11-26 Thread Scott Arciszewski
http://events.ccc.de/congress/2012/Fahrplan/attachments/2235_29c3-schinzel.pdf No, a random delay is not sufficient. Or, write yourself an extension and mirror the implementations of all these functions. pecl/ts_string or something like that and provide ts_bin2hex() and/or have the extension

Re: [PHP-DEV] Fwd: [php-src] Constant-Time bin2hex() implementation (#909)

2014-11-26 Thread Michael Wallner
On 26/11/14 16:29, Scott Arciszewski wrote: That's a rather extreme reaction to trying to patch string operations that real-world frameworks use to handle crypto secrets, don't you think? Hmm, no. -- Regards, Mike -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe,

Re: [PHP-DEV] Popups in the cgi win binaries

2014-11-26 Thread Anatol Belski
On Wed, November 26, 2014 14:38, Rowan Collins wrote: Anatol Belski wrote on 26/11/2014 11:34: While it might look short cut and too late for 5.5, there's indeed no scenario imaginable where such graphical elements could be used even as a feature. Neither on console nor as a server module

Re: [PHP-DEV] Fwd: [php-src] Constant-Time bin2hex() implementation (#909)

2014-11-26 Thread Ferenc Kovacs
That's a rather extreme reaction to trying to patch string operations that real-world frameworks use to handle crypto secrets, don't you think? and there are at least that much, but probably lot more usages in the wild(see https://github.com/search?l=phpq=bin2hextype=Codeutf8=%E2%9C%93 for

Re: [PHP-DEV] AV on PHP 5.5.18 + Zend Opcache in accel_chdir

2014-11-26 Thread Eric Stenson
​Thank you, Matt. It's not easily repro-able. I'm trying to get an isolated repro. I'll add to the existing bug 68439. Thx! --E. From: Matt Ficken themattfic...@gmail.com Sent: Tuesday, November 25, 2014 10:16 AM To: Eric Stenson Cc:

Re: [PHP-DEV] Fwd: [php-src] Constant-Time bin2hex() implementation (#909)

2014-11-26 Thread Adam Harvey
On 26 November 2014 at 08:49, Ferenc Kovacs tyr...@gmail.com wrote: That's a rather extreme reaction to trying to patch string operations that real-world frameworks use to handle crypto secrets, don't you think? and there are at least that much, but probably lot more usages in the wild(see

Re: [PHP-DEV] Fwd: [php-src] Constant-Time bin2hex() implementation (#909)

2014-11-26 Thread Rasmus Lerdorf
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/26/2014 07:29 AM, Scott Arciszewski wrote: http://events.ccc.de/congress/2012/Fahrplan/attachments/2235_29c3-schinzel.pdf No, a random delay is not sufficient. Sure, I mentioned that if the scenario allows for lots of observations then it

Re: [PHP-DEV] Fwd: [php-src] Constant-Time bin2hex() implementation (#909)

2014-11-26 Thread Anthony Ferrara
That seems like a lot of functions to artificially slow down. Well, in most cases it shouldn't slow it down by a non-trivial margin. It's not like comparison which removes the ability to short circuit, where it can be extremely significantly longer. When doing things like encoding or decoding,

Re: [PHP-DEV] Fwd: [php-src] Constant-Time bin2hex() implementation (#909)

2014-11-26 Thread Rasmus Lerdorf
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/26/2014 11:45 AM, Anthony Ferrara wrote: That seems like a lot of functions to artificially slow down. Well, in most cases it shouldn't slow it down by a non-trivial margin. If that can be shown definitively, then I would have fewer

Re: [PHP-DEV] [VOTE][RFC] Safe Casting Functions

2014-11-26 Thread Andrea Faulds
On 19 Nov 2014, at 20:39, Andrea Faulds a...@ajf.me wrote: I am putting the Safe Casting Functions RFC to a vote. https://wiki.php.net/rfc/safe_cast#vote Voting starts today (2014-11-19) and ends in 10 days’ time (2014-11-29). So far only 15 people have voted, that’s very low for this

Re: [PHP-DEV] Fwd: [php-src] Constant-Time bin2hex() implementation (#909)

2014-11-26 Thread Korvin Szanto
I don't like the idea of any mandatory slow down, trivial or not. This should be opt in. On Wed, Nov 26, 2014, 12:28 PM Rasmus Lerdorf ras...@lerdorf.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/26/2014 11:45 AM, Anthony Ferrara wrote: That seems like a lot of functions

Re: [PHP-DEV] Fwd: [php-src] Constant-Time bin2hex() implementation (#909)

2014-11-26 Thread Scott Arciszewski
That is why I updated the PR and made it add a function (ts_bin2hex()) instead of replacing the existing behavior. I could have sworn I already sent this to the list. On Wed, Nov 26, 2014 at 3:45 PM, Korvin Szanto korvinsza...@gmail.com wrote: I don't like the idea of any mandatory slow down,

Re: [PHP-DEV] Fwd: [php-src] Constant-Time bin2hex() implementation (#909)

2014-11-26 Thread Leigh
I'm of the opinion, this: On 26 November 2014 at 19:45, Anthony Ferrara ircmax...@gmail.com wrote: The two mcrypt functions, IMHO **MUST** be made timing safe, no matter what, since they **always** deal with sensitive information. Extended to any crypto functions too. But for everything

Fwd: [PHP-DEV] Fwd: [php-src] Constant-Time bin2hex() implementation (#909)

2014-11-26 Thread Scott Arciszewski
Forgot to reply all, it seems. -- Forwarded message -- From: Scott Arciszewski sc...@arciszewski.me Date: Wed, Nov 26, 2014 at 11:59 AM Subject: Re: [PHP-DEV] Fwd: [php-src] Constant-Time bin2hex() implementation (#909) To: Ferenc Kovacs tyr...@gmail.com On Wed, Nov 26, 2014 at

Re: [PHP-DEV] [RFC][Discussion] Return Type Variance Checking

2014-11-26 Thread Rowan Collins
On 26 November 2014 10:21:12 GMT, Lazare Inepologlou linep...@gmail.com wrote: http://en.wikipedia.org/wiki/Covariance_and_contravariance_(computer_science)#Covariant_method_return_type Can I just recommend that everyone interested in this discussion read that whole article (at least until it

Re: [PHP-DEV] [VOTE][RFC] Safe Casting Functions

2014-11-26 Thread Rowan Collins
On 26 November 2014 20:42:26 GMT, Andrea Faulds a...@ajf.me wrote: On 19 Nov 2014, at 20:39, Andrea Faulds a...@ajf.me wrote: I am putting the Safe Casting Functions RFC to a vote. https://wiki.php.net/rfc/safe_cast#vote Voting starts today (2014-11-19) and ends in 10 days’ time

Re: [PHP-DEV] [VOTE][RFC] Safe Casting Functions

2014-11-26 Thread Andrea Faulds
On 26 Nov 2014, at 23:00, Rowan Collins rowan.coll...@gmail.com wrote: So far only 15 people have voted, that’s very low for this kind of RFC. I’m tempted to extend voting for another week. It’s not likely to change the outcome, but it would hopefully mean more people vote. I don't

Re: [PHP-DEV] [VOTE][RFC] Safe Casting Functions

2014-11-26 Thread Gwynne Raskind
On Nov 26, 2014, at 17:24, Andrea Faulds a...@ajf.me wrote: On 26 Nov 2014, at 23:00, Rowan Collins rowan.coll...@gmail.com wrote: So far only 15 people have voted, that’s very low for this kind of RFC. I’m tempted to extend voting for another week. It’s not likely to change the outcome, but

Re: [PHP-DEV] [VOTE][RFC] Safe Casting Functions

2014-11-26 Thread Stanislav Malyshev
Hi! I don't know if it would make a difference here, but I wonder if it would be sensible to add an abstain option in votes? That way, someone who has considered an RFC but not formed a strong opinion either way could register that fact. This could even be paired with You could register that

Re: [PHP-DEV] [RFC] IntlChar class and intl_char_*() functions

2014-11-26 Thread Stanislav Malyshev
Hi! While playing around with Andrea's unicode literals syntax proposal, I was reminded of just how little of ICU is exposed. I've put up a short proposal for adding IntlChar exporting these APIs as static methods (with a matching non-oop interface). https://wiki.php.net/rfc/intl.char

[PHP-DEV] [RFC] Abstract final classes

2014-11-26 Thread guilhermebla...@gmail.com
Hi, I worked on an implementation of a somehow controversial concept that exists in hack and C#: abstract final classes. https://wiki.php.net/rfc/abstract_final_class My motivation is to further expand class support to add modifiers (PPP - public, protected, private). I added this change to

Re: [PHP-DEV] [RFC] Abstract final classes

2014-11-26 Thread Marco Pivetta
Except for the H1 on the RFC (needs to be updated), I can really see a lot of cases where I needed this: badly. On Nov 27, 2014 4:48 AM, guilhermebla...@gmail.com guilhermebla...@gmail.com wrote: Hi, I worked on an implementation of a somehow controversial concept that exists in hack and C#:

Re: [PHP-DEV] [RFC] Abstract final classes

2014-11-26 Thread Stanislav Malyshev
Hi! I worked on an implementation of a somehow controversial concept that exists in hack and C#: abstract final classes. https://wiki.php.net/rfc/abstract_final_class In the RFC, I think one phrase needs clarification: Currently, PHP developers' only resource is to create a final class

Re: [PHP-DEV] [RFC][Discussion] Return Type Variance Checking

2014-11-26 Thread Stanislav Malyshev
Hi! class FooFactory { function create(Foo $foo): Foo { return $foo; } } class GooFactory extends FooFactory { function create(Goo $goo): Goo { return $goo; } } OK HHVM allows it - we also allow it but trigger an E_STRICT error @see http://3v4l.org/UhtOb This is because this

Re: AW: [PHP-DEV] [RFC][Discussion] Return Type Variance Checking

2014-11-26 Thread Stanislav Malyshev
Hi! I've also used it because it can adequately show the differences in how each of the following options work: 1. Do covariant return types; check them at definition time 2. Do covariant return types; check them at runtime 3. Do invariant return types; check them at definition time