Re: [PHP-DEV] INDRECT in arrays causes count() to become unpredictable

2015-11-21 Thread Anthony Ferrara
Zeev, On Sat, Nov 21, 2015 at 11:52 PM, Zeev Suraski wrote: > >> On 22 בנוב׳ 2015, at 0:47, Anthony Ferrara wrote: >> >> I think this is significant enough to be a blocker to gold and that we >> should fix it prior to release. >> >> Thoughts? >> > > IMHO, unless we think fixing this would requir

Re: [PHP-DEV] INDRECT in arrays causes count() to become unpredictable

2015-11-21 Thread Xinchen Hui
Hey: On Sun, Nov 22, 2015 at 6:47 AM, Anthony Ferrara wrote: > All, > > It appears that in our efforts to optimize PHP 7 we've introduced an > inconsistency into array handling. This is demonstrated by this > script: https://3v4l.org/hVcAB > > $a = 1; > unset($a); > var_dump(count($GLOBALS), $GL

Re: [PHP-DEV] INDRECT in arrays causes count() to become unpredictable

2015-11-21 Thread Zeev Suraski
> On 22 בנוב׳ 2015, at 0:47, Anthony Ferrara wrote: > > I think this is significant enough to be a blocker to gold and that we > should fix it prior to release. > > Thoughts? > IMHO, unless we think fixing this would require breaking binary compatibility (which I don't think is the case) - t

[PHP-DEV] INDRECT in arrays causes count() to become unpredictable

2015-11-21 Thread Anthony Ferrara
All, It appears that in our efforts to optimize PHP 7 we've introduced an inconsistency into array handling. This is demonstrated by this script: https://3v4l.org/hVcAB $a = 1; unset($a); var_dump(count($GLOBALS), $GLOBALS); The result is that the count doesn't match the contents of the array.

Re: [PHP-DEV] Re: Benchmark Results for PHP Master 2015-11-19

2015-11-21 Thread Rasmus Lerdorf
On Nov 20, 2015, at 15:51, Andone, Bogdan wrote: > > Please ignore the Mandelbrot result. It seems it was a measurement error, as > we were unable to reproduce it on the same commit with additional runs. Perhaps it would be possible to automatically trigger additional runs in case a result show