Re: [PHP-DEV] Native Annotation Syntax

On 11/25/15 10:31 AM, Pedro Cordeiro wrote: 2015-11-25 13:47 GMT-02:00 Lester Caine : Any new system would require every third party tool to be adapted to use it That's not true at all. A new syntax would in no way invalidate parsing annotations from docblocks. The only

Re: [PHP-DEV] Native Annotation Syntax

Pedro Cordeiro wrote on 25/11/2015 16:53: Rowan, even if they are not harder, there is no reason to keep this feature in docblocks. Well, I can think of one reason: backwards compatibility. I don't mean with current frameworks - as you say, these are not currently standardised, so some will

Re: [PHP-DEV] Native Annotation Syntax

Pedro Cordeiro wrote on 25/11/2015 11:04: I'd really like to see something outside the docblock. Comment annotations are a workaround for the lack of native annotations. This is true, but they are now a very widely used workaround, and any native support for them could be polyfilled using the

Re: [PHP-DEV] Native Annotation Syntax

On 25/11/15 16:53, Rowan Collins wrote: > Now, if annotations were being implemented as something brand new to > PHP, like say Traits were, I'd agree that we should look to languages > like Java and C# for syntax ideas. But since a lot of people have > already invented annotations using docblocks,

Re: [PHP-DEV] Native Annotation Syntax

2015-11-25 13:47 GMT-02:00 Lester Caine : > Any new system would require > every third party tool to be adapted to use it > That's not true at all. A new syntax would in no way invalidate parsing annotations from docblocks. The only legacy code that is supported by IDEs (if

Re: [PHP-DEV] Native Annotation Syntax

Larry Garfield wrote on 25/11/2015 17:06: Too, it means that a given annotation directive may have spurious * characters inside its string, if it's multi-line. Sure, that can be filtered out (Doctrine already does), but that's one more complication to have to consider. I would expect that

Re: [PHP-DEV] Native Annotation Syntax

On 25/11/15 11:04, Pedro Cordeiro wrote: > I feel like this is a major feature that's missing, and people are using it > in a suboptimal way (docblocks), so I thought I'd reopen the discussion and > see if someone more familiar with the internals feels like implementing it In previous discussions

Re: [PHP-DEV] Native Annotation Syntax

Rowan, even if they are not harder, there is no reason to keep this feature in docblocks. Even the argument "compatibility with current implementations" is flawed, because there are many different implementations (not only doctrine's) with different syntaxes, so any native option would break SOME

Re: [PHP-DEV] Native Annotation Syntax

Larry Garfield wrote on 25/11/2015 17:06: For me, the "sometimes it's code and sometimes it's not, even though it looks the same" argument is sufficient to reject docblocks as a location for annotations. Annotations aren't code, they're metadata, and docblocks already contain metadata; it's

Re: [PHP-DEV] Native Annotation Syntax

On 11/25/15 10:47 AM, Rowan Collins wrote: Larry Garfield wrote on 25/11/2015 16:42: However, doing so would make static checking more difficult; If annotations become a language-native feature, they should be a first-class citizen to make it easier for IDEs to handle. Could you explain why

Re: [PHP-DEV] Native Annotation Syntax

Pedro Cordeiro wrote on 25/11/2015 17:04: 2015-11-25 14:53 GMT-02:00 Rowan Collins >: If it helps, just think of /** ... */ as not being a comment, but already a first-class piece of syntax. Except that it won't parse some

Re: [PHP-DEV] Native Annotation Syntax

Larry Garfield wrote on 25/11/2015 16:42: However, doing so would make static checking more difficult; If annotations become a language-native feature, they should be a first-class citizen to make it easier for IDEs to handle. Could you explain why docblocks are harder to parse than text

Re: [PHP-DEV] Native Annotation Syntax

Hi, I'm the co-author of RFC of Annotations, co-author of Annotations in docblock which I abandoned for being conceptually wrong and co-author of Doctrine Annotations. Comments such as the one from Lester Caine "In previous discussions it was pointed out that a substantial amount of legacy code

[PHP-DEV] RE: [INTERNALS-WIN] Re: [PHP-DEV] Windows (Visual Studio) compiler stuff

Hi Matt, > -Original Message- > From: Matt Wilmas [mailto:php_li...@realplain.com] > Sent: Monday, November 23, 2015 8:15 AM > To: Anatol Belski ; internals@lists.php.net; internals- > w...@lists.php.net > Cc: 'Dmitry Stogov' ; 'Pierre Joye'

RE: [PHP-DEV] Windows (Visual Studio) compiler stuff

Hi Matt, I wonder really how much research you do :) > -Original Message- > From: Matt Wilmas [mailto:php_li...@realplain.com] > Sent: Monday, November 23, 2015 2:28 AM > To: internals@lists.php.net; internals-...@lists.php.net > Cc: Dmitry Stogov ; Anatol Belski

Re: [PHP-DEV] Native Annotation Syntax

guilhermebla...@gmail.com wrote on 25/11/2015 17:58: I can give you a good argument. opcache.save_comments=0 Make it work. Simple: remove that configuration variable, and always save doc blocks. As mentioned, my view would be that these should no longer be considered "comments", but

Re: [PHP-DEV] Native Annotation Syntax

Hi Rowan, If you're in a shared hosting, you can't "simply" remove the configuration variable. Relying on extensions or configuration flags to support core language features is very bad. We don't have flags that can turn IF support off for example, why we would have that for annotations? I can

RE: [PHP-DEV] Re: Scalar Type Declaration Syntax Weirdness

Hi Andrea, > -Original Message- > From: Andrea Faulds [mailto:a...@ajf.me] > Sent: Wednesday, November 25, 2015 9:00 PM > To: internals@lists.php.net > Subject: Re: [PHP-DEV] Re: Scalar Type Declaration Syntax Weirdness > > Hi, > > Anatol Belski wrote: > > that's my point as well. There

RE: [PHP-DEV] Re: Scalar Type Declaration Syntax Weirdness

Hi Andrea, > -Original Message- > From: Andrea Faulds [mailto:a...@ajf.me] > Sent: Thursday, November 26, 2015 12:47 AM > To: internals@lists.php.net > Subject: Re: [PHP-DEV] Re: Scalar Type Declaration Syntax Weirdness > > Hi Anatol, > > Anatol Belski wrote: > >> > >> It may not be

Re: [PHP-DEV] Re: Scalar Type Declaration Syntax Weirdness

Hi Anatol, Anatol Belski wrote: It may not be documented, but that doesn't put it outside the scope of BC. People will unintentionally rely on bugs. What is the reason to use \int if "class \int{}" is prohibited? A typo :) ? It might be used deliberately since some IDEs (PHPStorm in

Re: [PHP-DEV] Re: Scalar Type Declaration Syntax Weirdness

Hi! > It may not be documented, but that doesn't put it outside the scope of > BC. People will unintentionally rely on bugs. People might, but we are under no obligation to keep bugs around for these people. -- Stas Malyshev smalys...@gmail.com -- PHP Internals - PHP Runtime Development

Re: [PHP-DEV] Native Annotation Syntax

Ok, so I'll explain why it's not "the same way" as you imagine. I've heard this many times already so I'll save you keystrokes. - "Sure, we can do that on docblocks" - "Based on that, it doesn't need to be part of core and can safely be implemented as a PECL extension" IMHO, internals need to

Re: [PHP-DEV] Native Annotation Syntax

Hi Rowan, I'm avoiding drilling down as much as I can to explain every single decision motivation of the 2010's patch, which hints every time why docblocks are bad. Maybe another example may help you to illustrate the problem; all I want is to add a multi-lined text in an annotation (using your

Re: [PHP-DEV] Re: Scalar Type Declaration Syntax Weirdness

Hi, Anatol Belski wrote: that's my point as well. There is a clear documentation about type hints, usage of an undocumented way is out of scope of BC. Using \int means there were a "class int{}" which is prohibited. Of course it is a bug after all, which will be addressed. It may not

Re: [PHP-DEV] Native Annotation Syntax

I can give you a good argument. opcache.save_comments=0 Make it work. On Wed, Nov 25, 2015 at 12:48 PM, Rowan Collins wrote: > Larry Garfield wrote on 25/11/2015 17:39: > >> On 11/25/15 11:00 AM, Rowan Collins wrote: >> >>> I don't feel that strongly in favour of

Re: [PHP-DEV] Native Annotation Syntax

On 11/25/15 11:48 AM, Rowan Collins wrote: Larry Garfield wrote on 25/11/2015 17:39: On 11/25/15 11:00 AM, Rowan Collins wrote: I don't feel that strongly in favour of docblocks, but I don't think the reasons given against are particularly strong. Regards, If you don't feel strongly in

Re: [PHP-DEV] Native Annotation Syntax

Rowan Collins wrote on 25/11/2015 18:47: Simple: remove that configuration variable, and always save doc blocks. Thinking about it, you don't even need to do that, just add a structure in the opcache memory layout for the parsed annotations, allowing you to accelerate access to those.

Re: [PHP-DEV] Native Annotation Syntax

On 11/25/15 11:00 AM, Rowan Collins wrote: I don't feel that strongly in favour of docblocks, but I don't think the reasons given against are particularly strong. Regards, If you don't feel strongly in favor of them, why are you trying to make a case for them so strongly? Just for kicks?

Re: [PHP-DEV] Native Annotation Syntax

On top of it, it'd break obfuscators like Zend Guard. 2015-11-25 15:58 GMT-02:00 guilhermebla...@gmail.com < guilhermebla...@gmail.com>: > I can give you a good argument. > > opcache.save_comments=0 > > Make it work. > > On Wed, Nov 25, 2015 at 12:48 PM, Rowan Collins >

Re: [PHP-DEV] Native Annotation Syntax

Larry Garfield wrote on 25/11/2015 17:39: On 11/25/15 11:00 AM, Rowan Collins wrote: I don't feel that strongly in favour of docblocks, but I don't think the reasons given against are particularly strong. Regards, If you don't feel strongly in favor of them, why are you trying to make a

Re: [PHP-DEV] Scalar Type Declaration Syntax Weirdness

Hi, Xinchen Hui wrote: Hey: On Wed, Nov 25, 2015 at 5:57 PM, Nikita Popov wrote: Imho this additional change is not necessary, it only makes the parser more complicated. However something missing from the original patch is handling of relative names like

Re: [PHP-DEV] Native Annotation Syntax

On 25 November 2015 19:02:37 GMT, "guilhermebla...@gmail.com" wrote: >Hi Rowan, > >If you're in a shared hosting, you can't "simply" remove the >configuration >variable. >Relying on extensions or configuration flags to support core language >features is very bad. We

[PHP-DEV] Re: [PHP-CVS] tag php-src: create tag php-7.0.0RC8

On 11/25/2015 04:10 AM, Anatol Belski wrote: Tag php-7.0.0RC8 in php-src.git was created Tag: 4db85e9fedda7d177737cbfeb1cf3096cb4d3bc4 Tagger: Anatol Belski Wed Nov 25 04:10:51 2015 +0100 Log: Tag for 7.0.0RC8 Why were

RE: [PHP-DEV] Re: Scalar Type Declaration Syntax Weirdness

Hi Stas, > -Original Message- > From: Stanislav Malyshev [mailto:smalys...@gmail.com] > Sent: Tuesday, November 24, 2015 6:28 PM > To: Andrea Faulds ; internals@lists.php.net > Subject: Re: [PHP-DEV] Re: Scalar Type Declaration Syntax Weirdness > > Hi! > > > It can't wait

[PHP-DEV] RE: [PHP-CVS] tag php-src: create tag php-7.0.0RC8

Hi Sebastian, > -Original Message- > From: Sebastian Bergmann [mailto:sebast...@php.net] > Sent: Wednesday, November 25, 2015 10:18 AM > To: Anatol Belsk > Cc: internals@lists.php.net > Subject: Re: [PHP-CVS] tag php-src: create tag php-7.0.0RC8 > > On 11/25/2015 04:10 AM,

Re: [PHP-DEV] Scalar Type Declaration Syntax Weirdness

On Wed, Nov 25, 2015 at 4:47 AM, Xinchen Hui wrote: > Hey: > > > > On Wed, Nov 25, 2015 at 4:49 AM, Bob Weinand wrote: > > > > Am 24.11.2015 um 20:30 schrieb Matteo Beccati : > > > > > > On 24/11/2015 18:50, Andrea Faulds wrote: > > >>

Re: [PHP-DEV] Scalar Type Declaration Syntax Weirdness

Hey: On Wed, Nov 25, 2015 at 5:57 PM, Nikita Popov wrote: > On Wed, Nov 25, 2015 at 4:47 AM, Xinchen Hui wrote: > >> Hey: >> >> >> >> On Wed, Nov 25, 2015 at 4:49 AM, Bob Weinand wrote: >> >> > > Am 24.11.2015 um 20:30 schrieb

Re: [PHP-DEV] 7.0.0 release

On Tue, Nov 24, 2015 at 5:07 PM, guilhermebla...@gmail.com < guilhermebla...@gmail.com> wrote: > +1 on (a) > > It's perfectly normal to have issues fixed between last RC and GA. > > []s, it's not a clear cut. you can get away with doing that but the point of the RCs is that allow the general

Re: [PHP-DEV] Native Annotation Syntax

I'd really like to see something outside the docblock. Comment annotations are a workaround for the lack of native annotations. It makes the environment hard to learn ("What does @param do? And what does @ManyToMany do?"), it makes it impossible for IDEs to hint/autocomplete without

Re: [PHP-DEV] Scalar Type Declaration Syntax Weirdness

Hey: On Wed, Nov 25, 2015 at 5:57 PM, Nikita Popov wrote: > On Wed, Nov 25, 2015 at 4:47 AM, Xinchen Hui wrote: > >> Hey: >> >> >> >> On Wed, Nov 25, 2015 at 4:49 AM, Bob Weinand wrote: >> >> > > Am 24.11.2015 um 20:30 schrieb

[PHP-DEV] Benchmark Results for PHP Master 2015-11-25

Results for project PHP master, build date 2015-11-25 05:26:40+02:00 commit: 283e9ea21bb980513d86c5273bebc01b5eb2b52c revision date: 2015-11-25 03:40:55+01:00 environment:Haswell-EP cpu:Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz 2x18 cores, stepping 2, LLC 45 MB

[PHP-DEV] Re: libtool builds CLI/CGI php from PIC object files

hi, On Wed, Nov 25, 2015 at 3:43 PM, Andone, Bogdan wrote: > Hi Dmitry, > > > > Here is a PR trying to solve the problem: > https://github.com/php/php-src/pull/1650 > > Let me know if I missed something. > Yeah. This approach should work. Using non-PIC object files