Re: [PHP-DEV] Fixing bug #68063

2016-01-15 Thread Julien Pauli
On Fri, Jan 15, 2016 at 1:32 AM, Yasuo Ohgaki wrote: > Hi Julien, > > On Fri, Jan 15, 2016 at 9:10 AM, Yasuo Ohgaki wrote: >> >> On Fri, Jan 15, 2016 at 4:32 AM, Stanislav Malyshev >> wrote: >>> However, previous my fix (Raise

Re: [PHP-DEV] Re: Internals and Newcomers and the Sidelines -- "let's proceed to ideas"

2016-01-15 Thread François Laupretre
Le 14/01/2016 16:47, Stig Bakken a écrit : I agree whole-heartedly with Zeev here! Anyone who has a clue about organizational psychology will tell you to focus on what you want more of, not on what you want to eliminate. Heck, anyone who is a parent today should understand this intuitively.

Re: [PHP-DEV] Re: Internals and Newcomers and the Sidelines -- "let's proceed to ideas"

2016-01-15 Thread François Laupretre
Hi, As we are talking about newcomers and the way we should encourage them, may I suggest you all to read Dustin's 'friend class' RFC (https://wiki.php.net/rfc/friend-classes). That's his first RFC and he got only one (negative) reply. Whether you like it or not, his work deserves being read

Re: [PHP-DEV] Re: Internals and Newcomers and the Sidelines -- "let's proceed to ideas"

2016-01-15 Thread Stig Bakken
On Fri, Jan 15, 2016 at 3:13 PM, François Laupretre wrote: > Le 14/01/2016 16:47, Stig Bakken a écrit : > >> >> I agree whole-heartedly with Zeev here! >> >> Anyone who has a clue about organizational psychology will tell you to >> focus on what you want more of, not on what

[PHP-DEV] Close some old issues

2016-01-15 Thread Dan Ackroyd
Hello, I've been watching the bug database for issues coming in for PHP7, and there have been far fewer than I was expecting, which is nice. However there are lots of issues open from 'a while ago' that are either not really bug requests, or are too old to investigate. I don't think having them

Re: [PHP-DEV] Re: Internals and Newcomers and the Sidelines -- "let's proceed to ideas"

2016-01-15 Thread Derick Rethans
On Wed, 13 Jan 2016, Stanislav Malyshev wrote: > > Right now I can call out your last paragraph. But before I do, > > remember John's point about perception versus reality. I go further. > > With respect to what goes down on a list-serv, there is only > > perception and nothing else matters.

Re: [PHP-DEV] RFC karma request re RFC proposal for alternative list syntax

2016-01-15 Thread Ferenc Kovacs
On Fri, Jan 15, 2016 at 4:45 PM, Julian Rhind wrote: > Hi > > > Thanks all for the feedback - I'm posting back to get some "RFC karma" for > my newly created wiki account please - so I can post my RFC - username is > "julian" > > > Thanks > > > Regards > > > Julian > > >

[PHP-DEV] RFC karma request re RFC proposal for alternative list syntax

2016-01-15 Thread Julian Rhind
Hi Thanks all for the feedback - I'm posting back to get some "RFC karma" for my newly created wiki account please - so I can post my RFC - username is "julian" Thanks Regards Julian From: Kris Craig Sent: 28 December 2015 18:40

Re: [PHP-DEV] Fixing bug #68063

2016-01-15 Thread Yasuo Ohgaki
Hi Julien, On Fri, Jan 15, 2016 at 7:36 PM, Julien Pauli wrote: > > I will cherry pick it for 5.5 , as it is a fix for a security fix. Thank you. > > Is it bfb9307b2d679a91e138fd876880470ece60942b ? It's 8c37a086c78a66517967fcb809fb53297becfe42 Regards, -- Yasuo Ohgaki

Re: [PHP-DEV] Close some old issues

2016-01-15 Thread Stanislav Malyshev
Hi! > However there are lots of issues open from 'a while ago' that are > either not really bug requests, or are too old to investigate. Bug db also has feature requests. Which are fine, even if nobody does them now, people may do in the future. > I don't think having them kept open is

Re: [PHP-DEV] Close some old issues

2016-01-15 Thread Christoph Becker
Stanislav Malyshev wrote: >> I don't think having them kept open is providing any value, and it >> makes it harder to find actual issues that need fixing in the issue >> database, so I'd like to close some of them. > > Bug DB triage is a hard, long and often thankless work. I am very > thankful

Re: [PHP-DEV] Close some old issues

2016-01-15 Thread Stanislav Malyshev
Hi! > For old bug reports it might be reasonable to change the status to > "Feedback" and ask, whether the issue still persists. This way the > report is likely going to end up with "No feedback", what's IMHO better > than "Closed" for such cases. This is a good option too. -- Stas Malyshev

Re: [PHP-DEV] Close some old issues

2016-01-15 Thread François Laupretre
Le 15/01/2016 18:04, Dan Ackroyd a écrit : If anyone thinks they all ought to be kept open, that could be discussed on list, but I would really like to avoid discussing each one individually on list, as I don't think that would be productive. If anyone with wants to keep any of these issues

Re: [PHP-DEV] Close some old issues

2016-01-15 Thread François Laupretre
Le 15/01/2016 19:53, Stanislav Malyshev a écrit : Hi! Those that do require RFC I think is fine to close. Maybe have a standard text for that - like "This request describes a change that is substantial enough to warrant an RFC. Please read and submit an RFC for the consideration for the

[PHP-DEV] Re: [RFC][VOTE] Number Format Separator

2016-01-15 Thread Andrea Faulds
Hi Thomas, Thomas Punt wrote: Hi internals! Voting has opened for the inclusion of a digit separator in PHP[1]. Voting ends in one week's time on January 20th. Thanks, Tom [1]: http://wiki.php.net/rfc/number_format_separator Initially I was going to

Re: [PHP-DEV] Fixing bug #71038 session_start() returns TRUE on failure

2016-01-15 Thread Stanislav Malyshev
Hi! > Read failure is special because old save handler allowed returning false > for read and continued as if there is no errors. I cannot fix this without > braking buggy save handlers compatibility. Ah, you mean when read actually worked but handler returns false? If the session is set up

[PHP-DEV] BAD Benchmark Results for PHP Master 2016-01-15

2016-01-15 Thread lp_benchmark_robot
Results for project PHP master, build date 2016-01-15 06:31:17+02:00 commit: 7e9a6f7 previous commit:092a87c revision date: 2016-01-15 03:08:02+01:00 environment:Haswell-EP cpu:Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz 2x18 cores, stepping 2, LLC 45 MB

Re: [PHP-DEV] Fixing bug #71038 session_start() returns TRUE on failure

2016-01-15 Thread Yasuo Ohgaki
Hi Stas, On Fri, Jan 15, 2016 at 5:22 PM, Stanislav Malyshev wrote: >> Read failure is special because old save handler allowed returning false >> for read and continued as if there is no errors. I cannot fix this without >> braking buggy save handlers compatibility. > > Ah,