Re: [PHP-DEV] Re: [RFC] Warn about invalid strings in arithmetic (moving back todiscussion)

2016-01-27 Thread Michael Wallner
On 27/01/16 01:54, Levi Morrison wrote: > I personally consider the new changes with fractional and scientific > notation strings and integer operators to be the more important > change. Thanks to everyone who identified and fixed this > inconsistency. > > Does anyone have any good ideas on how to

[PHP-DEV] Re: PR1739

2016-01-27 Thread Yasuo Ohgaki
Hi Anatol, On Thu, Jan 28, 2016 at 12:48 PM, Yasuo Ohgaki wrote: > > https://github.com/php/php-src/pull/1739 > This PR is good one. It opens handler first, then proceeds. > It fixes save handler crash also. > > The PR does not break our tests and PHP7 only fix. However, It changes > handler exec

[PHP-DEV] PR1739

2016-01-27 Thread Yasuo Ohgaki
Hi Anatol, https://github.com/php/php-src/pull/1739 This PR is good one. It opens handler first, then proceeds. It fixes save handler crash also. The PR does not break our tests and PHP7 only fix. However, It changes handler execution order. This change will not affect normal operation/code at al

Re: [PHP-DEV] Re: [RFC] Warn about invalid strings in arithmetic(moving back todiscussion)

2016-01-27 Thread Andrea Faulds
Hi Levi, Levi Morrison wrote: I personally consider the new changes with fractional and scientific notation strings and integer operators to be the more important change. Thanks to everyone who identified and fixed this inconsistency. Does anyone have any good ideas on how to prevent strtol and

Re: [PHP-DEV] Bug #67383 exec() leaks file and socket descriptors to called program

2016-01-27 Thread php
Hi all, Am 27.01.2016 um 15:01 schrieb Julien Pauli: > On Wed, Jan 27, 2016 at 1:03 PM, Yasuo Ohgaki wrote: >> Hi all, >> >> This bug comes to my attention. >> https://bugs.php.net/bug.php?id=67383 >> >> This report includes patch that prevents file descriptor leaks. >> https://bugs.php.net/patc

Re: [PHP-DEV] [RFC][VOTE] OpenSSL AEAD support

2016-01-27 Thread Albert Casademont
That's great nees thanks!! On Wednesday, 27 January 2016, Jakub Zelenka wrote: > Hi, > > On Wed, Jan 20, 2016 at 4:40 PM, Jakub Zelenka > wrote: > > > Hi, > > > > The vote is now open: > > > > https://wiki.php.net/rfc/openssl_aead#voting > > > > > > > The voting has ended and the RFC has been a

[PHP-DEV] Re: [RFC][VOTE] OpenSSL AEAD support

2016-01-27 Thread Jakub Zelenka
Hi, On Wed, Jan 20, 2016 at 4:40 PM, Jakub Zelenka wrote: > Hi, > > The vote is now open: > > https://wiki.php.net/rfc/openssl_aead#voting > > > The voting has ended and the RFC has been accepted with 7 votes for and 4 against. I will merge the patch after sorting out another issue with openssl

Re: [PHP-DEV] Re: [RFC] Generalize support of negative string offsets

2016-01-27 Thread Julien Pauli
On Mon, Jan 25, 2016 at 3:45 PM, François Laupretre wrote: > Hi Andrea, > > Le 23/01/2016 22:10, Andrea Faulds a écrit : >> >> >> Er, ignore what I just said. Negative string offsets are actually >> special-cased and always produce an "Unitialized string offset" or >> "Invalid string offset" notic

Re: [PHP-DEV] Bug #67383 exec() leaks file and socket descriptors to called program

2016-01-27 Thread Julien Pauli
On Wed, Jan 27, 2016 at 1:03 PM, Yasuo Ohgaki wrote: > Hi all, > > This bug comes to my attention. > https://bugs.php.net/bug.php?id=67383 > > This report includes patch that prevents file descriptor leaks. > https://bugs.php.net/patch-display.php?bug_id=67383&patch=SOCK_CLOEXEC-and-FD_CLOEXEC&rev

Re: [PHP-DEV] Severe safety fail in file access and stream filters

2016-01-27 Thread François Laupretre
Le 26/01/2016 11:50, Julien Pauli a écrit : I think what we should do is sit around the table with people interested (Daniel Lowrey may be one of them), and plan a full rewrite of streams for PHP next major (PHP 8). I don't think addind stuff to next minors is a good idea, knowing we must preven

Re: [PHP-DEV] Severe safety fail in file access and stream filters

2016-01-27 Thread Yasuo Ohgaki
Hi Pierre, On Tue, Jan 26, 2016 at 8:38 PM, Pierre Joye wrote: > I totally agree with you here. I agree with Julien, too. > > The same applies imho to the session (about the other rfc targetting 7.1 or > other). I can understand your opinion for session RFC you've mentioned. The problem is a l

[PHP-DEV] Bug #67383 exec() leaks file and socket descriptors to called program

2016-01-27 Thread Yasuo Ohgaki
Hi all, This bug comes to my attention. https://bugs.php.net/bug.php?id=67383 This report includes patch that prevents file descriptor leaks. https://bugs.php.net/patch-display.php?bug_id=67383&patch=SOCK_CLOEXEC-and-FD_CLOEXEC&revision=latest There may be cases that CLOEXEC cannot be applied bl

[PHP-DEV] NEUTRAL Benchmark Results for PHP Master 2016-01-27

2016-01-27 Thread lp_benchmark_robot
Results for project PHP master, build date 2016-01-27 06:30:41+02:00 commit: af7174f previous commit:7159f16 revision date: 2016-01-26 16:41:00+01:00 environment:Haswell-EP cpu:Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz 2x18 cores, stepping 2, LLC 45 MB

Re: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - **** BC break ***

2016-01-27 Thread Yasuo Ohgaki
Hi Anatol, On Wed, Jan 27, 2016 at 6:28 PM, Anatol Belski wrote: > If you're willing to work on fixing BC breaches till next minor RC, it might > be the way to proceed. If on the next RC we see no signs of regression, so we > could take it into the next minor. Otherwise, if we see that there ar

RE: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - **** BC break ***

2016-01-27 Thread Anatol Belski
Hi Yasuo, > -Original Message- > From: yohg...@gmail.com [mailto:yohg...@gmail.com] On Behalf Of Yasuo > Ohgaki > Sent: Wednesday, January 27, 2016 9:19 AM > To: Anatol Belski > Cc: Stanislav Malyshev ; Remi Collet > ; internals@lists.php.net; Yasuo Ohgaki > > Subject: Re: [PHP-DEV] PHP

Re: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - **** BC break ***

2016-01-27 Thread Yasuo Ohgaki
Hi Anatol, On Wed, Jan 27, 2016 at 5:06 PM, Anatol Belski wrote: > Thanks for all the investigation (as well Remi, Stas and everyone). At first > glance last week, as for me, it looked like OK to keep at least the 7.0 part, > as the breach was only concerning the unit tests but unlikely the act

Re: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - **** BC break ***

2016-01-27 Thread Remi Collet
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Using 2 patches: https://gist.github.com/smalyshev/4d8435b7993bef80c0ed https://gist.github.com/yohgaki/c3783b22bae9dcb78d69 $ /work/build/php56/sapi/cli/php /usr/bin/phpunit - --include-path=/usr/share/pear . PHPUnit 5.1.4 by Sebastian Bergmann and

Re: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - **** BC break ***

2016-01-27 Thread Yasuo Ohgaki
Hi all and Stas, On Wed, Jan 27, 2016 at 3:53 PM, Stanislav Malyshev wrote: >> The Horde_SessionHandler test suite still fail differently: Both >> are related to "getSessionIDs" (which list active sessions) > > Any way to get a short repro script for that too? > > In general, I start to be more a

RE: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - **** BC break ***

2016-01-27 Thread Anatol Belski
Hi Yasuo, > -Original Message- > From: yohg...@gmail.com [mailto:yohg...@gmail.com] On Behalf Of Yasuo > Ohgaki > Sent: Wednesday, January 27, 2016 7:26 AM > To: Stanislav Malyshev > Cc: Remi Collet ; internals@lists.php.net; Yasuo > Ohgaki > Subject: Re: [PHP-DEV] PHP 7.0.3 RC1 is avail