Re: [PHP-DEV] Tests for null coalescing assignment operator

2016-04-03 Thread Joe Watkins
Hi Midori, I was going to, but then found that comprehensive guide for writing tests, which has it all covered. Current tests covering Zend are in Zend/tests, you can look in there for inspiration, perhaps looking at the tests for a similar feature. As for what to test, I can't say;

Re: [PHP-DEV] Tests for null coalescing assignment operator

2016-04-03 Thread Midori Kocak
Joe, Also that would be more helpful if you wrote some examples or guides, with your advises instead of writing one sentence emails. I would be more happy as a rookie that way. Yours, Midori > On 03 Apr 2016, at 18:17, Midori Kocak wrote: > > Hello Joe, > > Those were

Re: [PHP-DEV] Tests for null coalescing assignment operator

2016-04-03 Thread Midori Kocak
Hello Joe, Those were examples for your feedback. Thanks, Midori > On 03 Apr 2016, at 18:16, Joe Watkins wrote: > > Morning Midori, > > PHP doesn't use PHPUnit tests. > > Please see: https://qa.php.net/write-test.php > > >

Re: [PHP-DEV] Tests for null coalescing assignment operator

2016-04-03 Thread Joe Watkins
Morning Midori, PHP doesn't use PHPUnit tests. Please see: https://qa.php.net/write-test.php Cheers Joe On Sun, Apr 3, 2016 at 3:41 PM, Midori Kocak wrote: > Yes, I think I should too. But still no feedbacks :( > > > On 03 Apr 2016, at 13:15, Björn Larsson

Re: [PHP-DEV] Tests for null coalescing assignment operator

2016-04-03 Thread Midori Kocak
Yes, I think I should too. But still no feedbacks :( > On 03 Apr 2016, at 13:15, Björn Larsson wrote: > > Hi Midori, > > Will you update the RFC also? Even if it's not the normal way of doing > things, one should keep in mind that RFC's are often listed as references

Re: [PHP-DEV] Tests for null coalescing assignment operator

2016-04-03 Thread Björn Larsson
Hi Midori, Will you update the RFC also? Even if it's not the normal way of doing things, one should keep in mind that RFC's are often listed as references in books about PHP, being the first piece of documentation. Two such examples are: -

[PHP-DEV] Re: Object getter method optimization

2016-04-03 Thread Lin Yo-An
I submitted the new benchmark result here: Benchmark ResultGetter Method Only https://gist.github.com/8cd230a5601cbe38439661adf3caca0d Without getter optimization (3 runs): 151.0169506073ms With getter optimization (3 runs) 39.201021194458ms Template Engine Benchmark