Re: [PHP-DEV] Explicit constructor call and polymorphic dispatch

2017-01-11 Thread Sebastian Bergmann
Am 12.01.2017 um 08:11 schrieb Tim Bezhashvyly: > Disallow explicit call of __construct method I am baffled that this (still) works: $ cat /tmp/t.php __construct(); $ php /tmp/t.php C::__construct C::__construct $ php --version PHP 7.1.0 (cli) (built: Dec 1 2016 07:39:00) ( NTS ) Copyright

[PHP-DEV] Explicit constructor call and polymorphic dispatch

2017-01-11 Thread Tim Bezhashvyly
Dear internals, I would like to propose 2 RFCs: - Disallow explicit call of __construct method - Polymorphic dispatch I'm sure I'm not the first who came with those 2 ideas so in case those were already proposed and rejected just let me know. Otherwise please bless me with mana which will

Re: [PHP-DEV] Re: [Discussion] HKDF

2017-01-11 Thread Joe Watkins
Morning Andrey, Please request a VCS account, put my name in it, and holla at me with username. Cheers Joe On Wed, Jan 11, 2017 at 11:04 PM, Kalle Sommer Nielsen wrote: > Hi Niklas > > 2017-01-11 23:18 GMT+01:00 Niklas Keller : > > Could we move documentation

Re: [PHP-DEV] Re: [Discussion] HKDF

2017-01-11 Thread Kalle Sommer Nielsen
Hi Niklas 2017-01-11 23:18 GMT+01:00 Niklas Keller : > Could we move documentation to Git and mirror it on Github, too? I think we > might get more PRs on GitHub than on this strange edit.php.net editor, where > probably most people edit and save, but forget to submit the actual

Re: [PHP-DEV] Re: [RFC][Discussion] - list() reference syntax

2017-01-11 Thread David Walker
On Wed, Jan 11, 2017 at 3:15 PM Andrea Faulds wrote: > Regarding the =& open issue in the RFC, I don't think the =& syntax > makes sense to me. The thing on the right-hand side of a list() > assignment is the array, not its values. It makes no difference for the > purposes of

[PHP-DEV] Re: Change in type-hint representation

2017-01-11 Thread Andrea Faulds
Hey Dmitry, Dmitry Stogov wrote: I propose to introduce a unified type representation (zend_type). Now it's going to be used for typing of arguments and return values. Later we should use it for properties and other things. https://gist.github.com/dstogov/1b25079856afccf0d69f77d499cb0ab1

Re: [PHP-DEV] Change in type-hint representation

2017-01-11 Thread Levi Morrison
On Wed, Jan 11, 2017 at 3:30 PM, Andrea Faulds wrote: > Hi Levi, > > Levi Morrison wrote: >> >> As part of this effort can we refactor the IS_LONG, IS_ARRAY, >> IS_OBJECT, etc macros to use an enum? Maybe `zend_type_code` if you >> like the `code` name for it? Also we already use

Re: [PHP-DEV] Change in type-hint representation

2017-01-11 Thread Andrea Faulds
Hi Levi, Levi Morrison wrote: As part of this effort can we refactor the IS_LONG, IS_ARRAY, IS_OBJECT, etc macros to use an enum? Maybe `zend_type_code` if you like the `code` name for it? Also we already use "kind" in the AST; should it be `ZEND_TYPE_KIND` and `zend_type_kind` instead? C's

Re: [PHP-DEV] Re: [Discussion] HKDF

2017-01-11 Thread Christoph M. Becker
CC'ing the doc list. On 11.01.2017 at 23:18, Niklas Keller wrote: > 2017-01-11 22:06 GMT+01:00 Kalle Sommer Nielsen : > >> Hi Andrey >> >> 2017-01-11 21:48 GMT+01:00 Andrey Andreev : >>> Yes, I've used the online editor in the past. But it feels weird ... and >>

Re: [PHP-DEV] Re: [Discussion] HKDF

2017-01-11 Thread Niklas Keller
2017-01-11 22:06 GMT+01:00 Kalle Sommer Nielsen : > Hi Andrey > > 2017-01-11 21:48 GMT+01:00 Andrey Andreev : > > Yes, I've used the online editor in the past. But it feels weird ... and > I > > can't even see patches I've submitted in the past. > > > > If it has

[PHP-DEV] Re: [RFC][Discussion] - list() reference syntax

2017-01-11 Thread Andrea Faulds
Hi Dave, Regarding the =& open issue in the RFC, I don't think the =& syntax makes sense to me. The thing on the right-hand side of a list() assignment is the array, not its values. It makes no difference for the purposes of assigning from its values if the array is a reference or not, so

Re: [PHP-DEV] Re: [Discussion] HKDF

2017-01-11 Thread Kalle Sommer Nielsen
Hi Andrey 2017-01-11 21:48 GMT+01:00 Andrey Andreev : > Yes, I've used the online editor in the past. But it feels weird ... and I > can't even see patches I've submitted in the past. > > If it has to happen quickly, I'll probably use that, but I'd rather avoid > it. Yeah sadly

Re: [PHP-DEV] Re: [Discussion] HKDF

2017-01-11 Thread Andrey Andreev
Hi Kalle, On Wed, Jan 11, 2017 at 10:38 PM, Kalle Sommer Nielsen wrote: > Hi Andrey > > 2017-01-11 20:39 GMT+01:00 Andrey Andreev : > > But naturally, I do promise to write the docs + a userland compat > package. > > In fact, I have some other docs updates that

[PHP-DEV] Re: Change in type-hint representation

2017-01-11 Thread Nikita Popov
On Wed, Jan 11, 2017 at 1:07 PM, Dmitry Stogov wrote: > Hi, > > > I propose to introduce a unified type representation (zend_type). > > Now it's going to be used for typing of arguments and return values. > > Later we should use it for properties and other things. > > >

Re: [PHP-DEV] Re: [Discussion] HKDF

2017-01-11 Thread Kalle Sommer Nielsen
Hi Andrey 2017-01-11 20:39 GMT+01:00 Andrey Andreev : > But naturally, I do promise to write the docs + a userland compat package. > In fact, I have some other docs updates that I want to do, so I might as > well request VCS access for that ... the docs still being in SVN has

[PHP-DEV] Re: [Discussion] HKDF

2017-01-11 Thread Andrey Andreev
Hi Tom, On Wed, Jan 11, 2017 at 9:16 PM, Tom Worster wrote: > Hi Andrey, > > Is there a draft of end-user docs for the PHP function? > No, not yet. But naturally, I do promise to write the docs + a userland compat package. In fact, I have some other docs updates that I want

Re: [PHP-DEV] Change in type-hint representation

2017-01-11 Thread Nikita Nefedov
> On 11 Jan 2017, at 19:37, Dmitry Stogov wrote: > > The patch was updated according to feedback: added comments, better names and > encapsulation, less magic, better code reuse, keep a free bit in zend_type > for future extension. >

[PHP-DEV] Re: [Discussion] HKDF

2017-01-11 Thread Tom Worster
Hi Andrey, Is there a draft of end-user docs for the PHP function? Tom -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

RE: [PHP-DEV] Change in type-hint representation

2017-01-11 Thread Anatol Belski
Hi Dmitry, > -Original Message- > From: Dmitry Stogov [mailto:dmi...@zend.com] > Sent: Wednesday, January 11, 2017 1:08 PM > To: PHP internals list ; Bob Weinand > ; Joe Watkins > Cc: Zeev Suraski ;

[PHP-DEV] [RFC] libsodium (PHP 7.2)

2017-01-11 Thread Scott Arciszewski
Hi all, I'm resurrecting my RFC to add libsodium as a core extension to PHP 7.2. In response to feedback from Pierre Joye, I've outlined which parts of the existing libsodium API I'd like exposed in the core extension. Most notably: - Removed crypto_aead_aes256gcm_* because OpenSSL offers it -

Re: [PHP-DEV] Change in type-hint representation

2017-01-11 Thread Bob Weinand
> Am 11.01.2017 um 17:37 schrieb Dmitry Stogov : > > The patch was updated according to feedback: added comments, better names and > encapsulation, less magic, better code reuse, keep a free bit in zend_type > for future extension. >

Re: [PHP-DEV] Change in type-hint representation

2017-01-11 Thread Levi Morrison
On Wed, Jan 11, 2017 at 9:37 AM, Dmitry Stogov wrote: > The patch was updated according to feedback: added comments, better names and > encapsulation, less magic, better code reuse, keep a free bit in zend_type > for future extension. >

Re: [PHP-DEV] Change in type-hint representation

2017-01-11 Thread Dmitry Stogov
The patch was updated according to feedback: added comments, better names and encapsulation, less magic, better code reuse, keep a free bit in zend_type for future extension.

[PHP-DEV] UGLY Benchmark Results for PHP Master 2017-01-10

2017-01-11 Thread lp_benchmark_robot
Results for project PHP master, build date 2017-01-10 20:28:57-08:00 commit: 63b36be previous commit:4fb70c7 revision date: 2017-01-10 23:45:01+01:00 environment:Haswell-EP cpu:Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz 2x18 cores, stepping 2, LLC 45 MB

Re: [PHP-DEV] Change in type-hint representation

2017-01-11 Thread Derick Rethans
On Wed, 11 Jan 2017, Dmitry Stogov wrote: > Hi, > > > I propose to introduce a unified type representation (zend_type). > > Now it's going to be used for typing of arguments and return values. > > Later we should use it for properties and other things. > > >

[PHP-DEV] Fwd: [RFC][Discussion] - list() reference syntax

2017-01-11 Thread David Walker
[Sorry if this is a second time you get this, but email issues and all] Hi All, I had mentioned the other day my desire to look at, and attempt implementation of allowing by-reference assignment within list()'s. Andrea had created an RFC for this purpose 2+years ago, but withdrew it due to

[PHP-DEV] [RFC][Post-Discussion]: E_WARNING when using array-index on non valid container

2017-01-11 Thread David Walker
[Sorry if this is a second time you get this, but email issues and all] Hi all, Joe had requested renewed discussion on the accepted RFC[1] and my proposed PR[2] be brought forward again for implementation discussion, and to come up with a resolution. The RFC, though accepted, had concerns with

Re: [PHP-DEV] Change in type-hint representation

2017-01-11 Thread Dmitry Stogov
On Jan 11, 2017 4:51 PM, Michał Brzuchalski wrote: 2017-01-11 14:35 GMT+01:00 Nikita Nefedov >: On Wed, 11 Jan 2017 15:07:39 +0300, Dmitry Stogov > wrote: Hi, I propose to

Re: [PHP-DEV] Change in type-hint representation

2017-01-11 Thread Dmitry Stogov
On Jan 11, 2017 4:36 PM, Nikita Nefedov wrote: On Wed, 11 Jan 2017 15:07:39 +0300, Dmitry Stogov wrote: > Hi, > > > I propose to introduce a unified type representation (zend_type). > > Now it's going to be used for typing of arguments and return values. >

[PHP-DEV] [Discussion] HKDF

2017-01-11 Thread Andrey Andreev
Hi all, There's a pending GitHub pull request of mine to include a HKDF implementation into ext/hash. Mostly anybody who saw it agreed that it probably doesn't require an RFC vote, but I hadn't originally announced it here on the list either, so this is what I'm doing now ... For technical

Re: [PHP-DEV] Change in type-hint representation

2017-01-11 Thread Markus Fischer
On 11.01.17 13:07, Dmitry Stogov wrote: > https://gist.github.com/dstogov/1b25079856afccf0d69f77d499cb0ab1 - there's a typo "/* this is a calss name */" a few times - a few times I see this condition: "if (info->type > 0x3ff) {" Shouldn't we use *some* descriptive constant for this seamingly

Re: [PHP-DEV] Unsubscribe request

2017-01-11 Thread Peter Cowburn
On 11 January 2017 at 13:42, Javier Rubio wrote: > Hello, > > Can you please unsubscribe my email for that list? > Unsubscription is self-service. The two easiest ways to unsubscribe are: 1. Send an email to internals-unsubscr...@lists.php.net from the subscribed email

Re: [PHP-DEV] Change in type-hint representation

2017-01-11 Thread Joe Watkins
Morning Dmitry, I know bob has already requested some additions ... nothing to really say about it ... I just wanted to chime in with VERY NICE :D (shouting intentional) ... Oh and, I think an RFC is pretty pointless ... */me looks forward to master having this* Cheers Joe On Wed, Jan 11,

Re: [PHP-DEV] Change in type-hint representation

2017-01-11 Thread Bob Weinand
> Am 11.01.2017 um 14:35 schrieb Nikita Nefedov : > > On Wed, 11 Jan 2017 15:07:39 +0300, Dmitry Stogov wrote: > >> Hi, >> >> >> I propose to introduce a unified type representation (zend_type). >> >> Now it's going to be used for typing of arguments and

Re: [PHP-DEV] Change in type-hint representation

2017-01-11 Thread Niklas Keller
Michał Brzuchalski schrieb am Mi., 11. Jan. 2017, 14:51: > 2017-01-11 14:35 GMT+01:00 Nikita Nefedov : > > > On Wed, 11 Jan 2017 15:07:39 +0300, Dmitry Stogov > wrote: > > > > Hi, > >> > >> > >> I propose to introduce a unified type

Re: [PHP-DEV] Change in type-hint representation

2017-01-11 Thread Michał Brzuchalski
2017-01-11 14:57 GMT+01:00 Nikita Nefedov : > On Wed, 11 Jan 2017 16:51:22 +0300, Michał Brzuchalski < > mic...@brzuchalski.com> wrote: > > >> >> 2017-01-11 14:35 GMT+01:00 Nikita Nefedov : >> >>> -- snip -- >>> >>> >>> [ ]

Re: [PHP-DEV] Change in type-hint representation

2017-01-11 Thread Nikita Nefedov
On Wed, 11 Jan 2017 16:51:22 +0300, Michał Brzuchalski wrote: 2017-01-11 14:35 GMT+01:00 Nikita Nefedov : -- snip -- [ ] xxy0 - for IS_OBJECT type hint where the ``s are a (zend_string *) pointer and

Re: [PHP-DEV] Change in type-hint representation

2017-01-11 Thread Michał Brzuchalski
2017-01-11 14:35 GMT+01:00 Nikita Nefedov : > On Wed, 11 Jan 2017 15:07:39 +0300, Dmitry Stogov wrote: > > Hi, >> >> >> I propose to introduce a unified type representation (zend_type). >> >> Now it's going to be used for typing of arguments and return

[PHP-DEV] Unsubscribe request

2017-01-11 Thread Javier Rubio
Hello, Can you please unsubscribe my email for that list? Thank you in advance Regards Javier

Re: [PHP-DEV] Change in type-hint representation

2017-01-11 Thread Nikita Nefedov
On Wed, 11 Jan 2017 15:07:39 +0300, Dmitry Stogov wrote: Hi, I propose to introduce a unified type representation (zend_type). Now it's going to be used for typing of arguments and return values. Later we should use it for properties and other things.

[PHP-DEV] Change in type-hint representation

2017-01-11 Thread Dmitry Stogov
Hi, I propose to introduce a unified type representation (zend_type). Now it's going to be used for typing of arguments and return values. Later we should use it for properties and other things. https://gist.github.com/dstogov/1b25079856afccf0d69f77d499cb0ab1 The main changes are in

[PHP-DEV] [RFC][VOTE] Parameter Type Widening (Resume)

2017-01-11 Thread Niklas Keller
Morning Internals, I just resumed the vote on "Parameter Type Widening", initially named "Parameter No Type Variance". RFC: https://wiki.php.net/rfc/parameter-no-type-variance Voting will keep open for three weeks counting from the initial opening on the 9th of January and close on 30th of

[PHP-DEV] RFC Announcement (Resume)

2017-01-11 Thread Joe Watkins
Morning internals, Since our communications appear to be back to normal, RFC's that were effected may now resume. As requested, please discount the period from 1st January, adjust discussion and voting periods to take this into account. Sorry for the inconvenience, and thanks for complying.

[PHP-DEV] Exposing jsonSerialize's depth

2017-01-11 Thread Jani Ollikainen
Hi, I've made a pull request where I was asked to start internal discussion about it.. The pull request can be found: https://github.com/php/php-src/pull/1884 Which relates to request I've also made: https://bugs.php.net/bug.php?id=72073 For short the thing is: "We have objects that do dynamic