[PHP-DEV] NEUTRAL Benchmark Results for PHP Master 2017-05-15

2017-05-16 Thread lp_benchmark_robot
Results for project PHP master, build date 2017-05-15 19:25:35-07:00 commit: 7de2b21 previous commit:8b361f1 revision date: 2017-05-15 20:42:37+02:00 environment:Haswell-EP cpu:Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz 2x18 cores, stepping 2, LLC 45 MB

Re: [PHP-DEV] BC break in master (7.2) - Distinguish betweenunmatchedsubpatterns and empty matches in preg_*()

2017-05-16 Thread Sara Golemon
On Tue, May 16, 2017 at 5:21 PM, Christoph M. Becker wrote: > Personally, I rarely use array_key_exists(), but others may prefer it, > and it appears to be cleaner not to set unmatched subpatterns at all. > And if we're going to add a flag anyway, it appears to be reasonable to > change the behavi

Re: [PHP-DEV] BC break in master (7.2) - Distinguish betweenunmatchedsubpatterns and empty matches in preg_*()

2017-05-16 Thread Christoph M. Becker
On 17.05.2017 at 00:13, Sara Golemon wrote: > On Tue, May 16, 2017 at 5:03 PM, Christoph M. Becker > wrote: > I suggest not to set unmatched subpatterns at all, >>> >>> Can you give an example of expected output ? >>> (I think stable position for matched pattern is important) >>> >>> php -r

Re: [PHP-DEV] BC break in master (7.2) - Distinguish betweenunmatched subpatterns and empty matches in preg_*()

2017-05-16 Thread Sara Golemon
On Tue, May 16, 2017 at 5:03 PM, Christoph M. Becker wrote: >>> I suggest not to set unmatched subpatterns at all, >> >> Can you give an example of expected output ? >> (I think stable position for matched pattern is important) >> >> php -r 'var_dump(preg_match("/(a)?([a-z]*)(\d*)/", "123", $match

Re: [PHP-DEV] BC break in master (7.2) - Distinguish betweenunmatched subpatterns and empty matches in preg_*()

2017-05-16 Thread Christoph M. Becker
On 15.05.2017 at 17:49, Remi Collet: >> I suggest not to set unmatched subpatterns at all, > > Can you give an example of expected output ? > (I think stable position for matched pattern is important) > > php -r 'var_dump(preg_match("/(a)?([a-z]*)(\d*)/", "123", $matches), > $matches);' See the

Re: [PHP-DEV] [Discussion] Dots and spaces in GPC variable names

2017-05-16 Thread Sara Golemon
On Tue, May 2, 2017 at 5:56 AM, Andrey Andreev wrote: > With parse_str() usage without a second parameter being deprecated, I > was looking to possibly drop the behavior where it replaces spaces and > dots with underscores in the result array, and ... As it often turns > out - it's not that simple

Re: [PHP-DEV] Hashtable collision resolution in PHP 7

2017-05-16 Thread Julien Pauli
On Tue, May 16, 2017 at 12:00 PM, Sara Golemon wrote: > https://nikic.github.io/2014/12/22/PHPs-new-hashtable-implementation.html > > On Tue, May 16, 2017 at 4:28 AM, Pawel Por wrote: > > Hi > > > > I'm trying to understand why PHP 7 hashtables are more efficient than > > PHP 5 hashtables. > > I

Re: [PHP-DEV] Hashtable collision resolution in PHP 7

2017-05-16 Thread Dmitry Stogov
PHP 7 still uses a kind of linked list for collision resolution (trough zval.u2.next) and this is still an expensive operation. From: Pawel Por Sent: Tuesday, May 16, 2017 12:28:36 PM To: internals@lists.php.net Subject: [PHP-DEV] Hashtable collision resolution

Re: [PHP-DEV] BC break in master (7.2) - Distinguish between unmatched subpatterns and empty matches in preg_*()

2017-05-16 Thread Nicolas Grekas
2017-05-15 17:21 GMT+02:00 Sara Golemon : > On Mon, May 15, 2017 at 6:36 AM, Nicolas Grekas > wrote: > >> I agree that a minimum 5 years old possible bug, quite small, causing > >> BC breaks is not good. As far as the fix is critical or justified, I > >> think it is sometimes ok to break BC for e

Re: [PHP-DEV] Hashtable collision resolution in PHP 7

2017-05-16 Thread Sara Golemon
https://nikic.github.io/2014/12/22/PHPs-new-hashtable-implementation.html On Tue, May 16, 2017 at 4:28 AM, Pawel Por wrote: > Hi > > I'm trying to understand why PHP 7 hashtables are more efficient than > PHP 5 hashtables. > I'm confused about hashes that are in collision. > In PHP 5 there were a

[PHP-DEV] Hashtable collision resolution in PHP 7

2017-05-16 Thread Pawel Por
Hi I'm trying to understand why PHP 7 hashtables are more efficient than PHP 5 hashtables. I'm confused about hashes that are in collision. In PHP 5 there were a linked lists to resolve collisions. What about PHP 7 ? Are there still linked lists ? I read somewhere that the solution taken in PHP 7