Re: [PHP-DEV] Re: [PHP-CVS] com php-src: ext/sodium: throw exceptions instead of errors: ext/sodium/libsodium.c

To summarize current situation libsodium v2.0.9 pecl extension use E_WARNING sodium extension in php-7.2.0 (tag) use E_WARNING (as in previous RCs) sodium extension in PHP-7.2 (branch) use E_WARNING (all changes have been reverted) Seems consistent. For 7.2.0, I don't think we have to change

Re: [PHP-DEV] Public Tags of Releases

On Tue, Nov 28, 2017 at 7:30 PM, Stanislav Malyshev wrote: >> If there's a mistake that needs to be fixed and that's detected within >> these two days, a re-tag needs to happen. If the old tag is deleted and a >> new modified tag is published, all cloned Git repositories that

Re: [PHP-DEV] Public Tags of Releases

Hi! > If there's a mistake that needs to be fixed and that's detected within > these two days, a re-tag needs to happen. If the old tag is deleted and a > new modified tag is published, all cloned Git repositories that already > received the old tag will keep the old tag and never receive the new

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: ext/sodium: throw exceptionsinstead of errors: ext/sodium/libsodium.c

On 29.11.2017 at 00:03, Nikita Popov wrote: > Previously: First > commit: Second commit: Third commit: > In summary, the first two commits combined were not a BC break -- they only> removed a warning and made an error message nicer. After the third commit> we now *do* have a BC break,

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: ext/sodium: throw exceptions instead of errors: ext/sodium/libsodium.c

2017-11-29 0:03 GMT+01:00 Nikita Popov : > In summary, the first two commits combined were not a BC break -- they only > removed a warning and made an error message nicer. After the third commit > we now *do* have a BC break, because what was previously a SodiumException > is

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: ext/sodium: throw exceptions instead of errors: ext/sodium/libsodium.c

So https://github.com/php/php-src/commit/31d221f9c72f0d0322c84907c5d89a4464667244 landed just now to revert this change, per the request here. This leaves us with the worst variant... so, let's step back a bit: The main commit that landed (for 7.2.1) is

[PHP-DEV] RE: Public Tags of Releases

Hi, > -Original Message- > From: p...@golemon.com [mailto:p...@golemon.com] On Behalf Of Sara > Golemon > Sent: Tuesday, November 28, 2017 6:17 PM > To: Niklas Keller > Cc: PHP Internals ; Joe Watkins > ; Remi Collet

[PHP-DEV] Re: Public Tags of Releases

> > On Tue, Nov 28, 2017 at 10:55 AM, Niklas Keller wrote: > > it's the current practice to tag releases publicly two days before > release > > and then do the final QA phase. Could we please stop that? > > > > If there's a mistake that needs to be fixed and that's detected

[PHP-DEV] Re: Public Tags of Releases

On Tue, Nov 28, 2017 at 10:55 AM, Niklas Keller wrote: > it's the current practice to tag releases publicly two days before release > and then do the final QA phase. Could we please stop that? > > If there's a mistake that needs to be fixed and that's detected within these > two

Re: [PHP-DEV] [PHP-CVS] com php-src: ext/sodium: throw exceptions instead of errors: ext/sodium/libsodium.c

Context: This commit switches some E_ERRORs introduced in a previous commit to throw exceptions, consistently with the rest of the extension. The original change was removing warning for parameters below an "interactive" limit and replacing them with an error below a hard minimum. This addresses

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: ext/sodium: throw exceptions instead of errors: ext/sodium/libsodium.c

On Tue, Nov 28, 2017 at 1:17 PM, Sebastian Bergmann wrote: > Am 28.11.2017 um 13:56 schrieb Frank Denis: > > Commit:c05cbd1e775fa69ed9939796a908390f2bfb4459 > > Author:Frank Denis Tue, 28 Nov 2017 > 13:56:11 +0100 > > Parents:

Re: [PHP-DEV] [PHP-CVS] com php-src: ext/sodium: throw exceptions instead of errors: ext/sodium/libsodium.c

Am 28.11.2017 um 16:44 schrieb Niklas Keller : > 2017-11-28 15:27 GMT+01:00 Christian Schneider : >> Would you still consider an exception a good idea if the minimum value for >> one of the function parameters is increased in a later version of libsodium?

Re: [PHP-DEV] [PHP-CVS] com php-src: ext/sodium: throw exceptions instead of errors: ext/sodium/libsodium.c

Le 28/11/2017 à 15:27, Christian Schneider a écrit : >> >> I am very much in favor of this change. However, making such a change in >> PHP 7.2.1 is a BC break. Any chance to get that into PHP 7.2.0? > > I'm wary of turning errors into exceptions because code which was returning a > result with

[PHP-DEV] Re: Public Tags of Releases

> > Afternoon, > > Tags are created in release branches, these branches should not be part of > any workflow other than our internal one. > I'm not talking about branches, but tags. Updating these release branches doesn't matter and is totally fine, as these are normal branches and thus not

[PHP-DEV] Re: Public Tags of Releases

Oh and private repositories suck, we already have a headache with security fixes because of strange flow and secrecy, we simply don't need or want more of that. Cheers Joe On 28 Nov 2017 5:02 pm, "Joe Watkins" wrote: Afternoon, Tags are created in release branches,

[PHP-DEV] Re: Public Tags of Releases

Afternoon, Tags are created in release branches, these branches should not be part of any workflow other than our internal one. It's problematic to tag other than publicly, anywhere we create these tags is public and presumably would cause the same problem for those people who choose to use

[PHP-DEV] Public Tags of Releases

Morning, it's the current practice to tag releases publicly two days before release and then do the final QA phase. Could we please stop that? If there's a mistake that needs to be fixed and that's detected within these two days, a re-tag needs to happen. If the old tag is deleted and a new

Re: [PHP-DEV] [PHP-CVS] com php-src: ext/sodium: throw exceptions instead of errors: ext/sodium/libsodium.c

2017-11-28 15:27 GMT+01:00 Christian Schneider : > Am 28.11.2017 um 14:17 schrieb Sebastian Bergmann : > > Am 28.11.2017 um 13:56 schrieb Frank Denis: > >> Commit:c05cbd1e775fa69ed9939796a908390f2bfb4459 > >> Author:Frank Denis

Re: [PHP-DEV] [PHP-CVS] com php-src: ext/sodium: throw exceptions instead of errors: ext/sodium/libsodium.c

Am 28.11.2017 um 14:17 schrieb Sebastian Bergmann : > Am 28.11.2017 um 13:56 schrieb Frank Denis: >> Commit:c05cbd1e775fa69ed9939796a908390f2bfb4459 >> Author:Frank Denis Tue, 28 Nov 2017 >> 13:56:11 +0100 >> Parents:

[PHP-DEV] Re: [PHP-CVS] com php-src: ext/sodium: throw exceptions instead of errors: ext/sodium/libsodium.c

Am 28.11.2017 um 13:56 schrieb Frank Denis: > Commit:c05cbd1e775fa69ed9939796a908390f2bfb4459 > Author:Frank Denis Tue, 28 Nov 2017 > 13:56:11 +0100 > Parents: c219991c77e4c68f7d62963e18a1da778de0bbe0 > Branches: PHP-7.2 > > Link: >

Re: [PHP-DEV] Changes in namespace importing

On Mon, 27 Nov 2017, Michael Morris wrote: > I'm sure the internal coders will correct me if I'm wrong on this, but > as I understand it PHP has no notion of packages, yet many calls to > modify how namespace importing works seem to be under the illusion > that packages exist. This is