Re: [PHP-DEV] [RFC] Reclassifying engine warnings

2019-08-30 Thread Thomas Bley
That's a good point, maybe a compromise is this: Matthew Brown hat am 28. August 2019 um 18:21 > geschrieben: > > > FWIW: all the runtime notices in our codebase come from internally-created > code. > > Requiring declare(strict_variables=1) to get this (better) behaviour punishes > future

Re: [PHP-DEV] Bringing Peace to the Galaxy

2019-08-30 Thread Andreas Hennings
On Sat, 31 Aug 2019 at 02:31, Larry Garfield wrote: > [..] > Whether editions is the "right" way to balance "don't break 1 million lines > of 15 year old code" with "this behavior is bad and we all know it" and with > "this behavior leads to sloppy code that is prone to bugs", I don't know. >

Re: [PHP-DEV] Bringing Peace to the Galaxy

2019-08-30 Thread Andreas Hennings
Some clarifications before I get crucified: > "editions" (the way I imagine) I don't want to misrepresent Nikita. His idea of editions might be completely different. > If "editions" (the way I imagine) had been introduced prior to PHP 7, we > might now have a PHP 7 engine that would still

Re: [PHP-DEV] Bringing Peace to the Galaxy

2019-08-30 Thread Andreas Hennings
On Sat, 31 Aug 2019 at 03:40, Reindl Harald wrote: > > > > Am 30.08.19 um 20:56 schrieb Andreas Hennings: > > In one of -these modules I initially used the ?? null coalesce operator. > > Then I had to replace all of the instances of ?? with the more verbose > > old-school code, to make it

Re: [PHP-DEV] Bringing Peace to the Galaxy

2019-08-30 Thread Andreas Hennings
(I hope this exchange is not getting too Drupal-specific. I imagine the same concerns would apply in any project that uses a lot of 3rd party code, and that is affected by framework versions and generations of framework ecosystems.) > Someone running their code on an old and unsupported PHP

Re: [PHP-DEV] Bringing Peace to the Galaxy

2019-08-30 Thread Larry Garfield
On Fri, Aug 30, 2019, at 1:56 PM, Andreas Hennings wrote: > On Fri, 30 Aug 2019 at 19:38, Chase Peeler wrote: > > On Fri, Aug 30, 2019 at 12:39 PM Andreas Hennings > > wrote: > > > The only way to make this possible is to either deny all progress, or > > > to make a distinction on file level (or

Re: [PHP-DEV] Bringing Peace to the Galaxy

2019-08-30 Thread Andreas Hennings
On Fri, 30 Aug 2019 at 19:38, Chase Peeler wrote: > On Fri, Aug 30, 2019 at 12:39 PM Andreas Hennings > wrote: > > The only way to make this possible is to either deny all progress, or > > to make a distinction on file level (or "package level", whatever that > > means). > > So, opt-in BC

Re: [PHP-DEV] Bringing Peace to the Galaxy

2019-08-30 Thread Chase Peeler
On Fri, Aug 30, 2019 at 12:39 PM Andreas Hennings wrote: > I would very much like to see "editions" or "generations". > > The only way to make this possible is to either deny all progress, or > to make a distinction on file level (or "package level", whatever that > means). > So, opt-in BC

Re: [PHP-DEV] Bringing Peace to the Galaxy

2019-08-30 Thread Andreas Hennings
I would very much like to see "editions" or "generations". > I do plan to create an RFC on this topic. I am looking forward to this Proposal from Nikita. So, at the risk of repeating some ideas that Nikita already mentioned elsewhere, I am sharing my own thoughts.. ## Motivation In this

Re: [PHP-DEV] Make error_reporting=E_ALL the default

2019-08-30 Thread Peter Kokot
Hello, On Fri, 30 Aug 2019 at 13:51, G. P. B. wrote: > > On Fri, 30 Aug 2019 at 11:45, Zeev Suraski wrote: > > > > > > On 30 Aug 2019, at 12:33, Nikita Popov wrote: > > > > > > Hi internals, > > > > > > Relating to the recent discussions on undefined variables & co. One thing > > > that is

Re: [PHP-DEV] Make error_reporting=E_ALL the default

2019-08-30 Thread G. P. B.
On Fri, 30 Aug 2019 at 11:45, Zeev Suraski wrote: > > > On 30 Aug 2019, at 12:33, Nikita Popov wrote: > > > > Hi internals, > > > > Relating to the recent discussions on undefined variables & co. One thing > > that is particularly annoying about the undefined variable case is that > our > >

Re: [PHP-DEV] Make error_reporting=E_ALL the default

2019-08-30 Thread Olumide Samson
+1 On Fri, Aug 30, 2019, 11:13 AM Javier Spagnoletti wrote: > Great step! +1 > Thank you so much Nikita. > > El vie., 30 de ago. de 2019 07:02, Arvids Godjuks < > arvids.godj...@gmail.com> > escribió: > > > пт, 30 авг. 2019 г. в 11:33, Nikita Popov : > > > > > Hi internals, > > > > > > Relating

Re: [PHP-DEV] Make error_reporting=E_ALL the default

2019-08-30 Thread Javier Spagnoletti
Great step! +1 Thank you so much Nikita. El vie., 30 de ago. de 2019 07:02, Arvids Godjuks escribió: > пт, 30 авг. 2019 г. в 11:33, Nikita Popov : > > > Hi internals, > > > > Relating to the recent discussions on undefined variables & co. One thing > > that is particularly annoying about the

Re: [PHP-DEV] Make error_reporting=E_ALL the default

2019-08-30 Thread Arvids Godjuks
пт, 30 авг. 2019 г. в 11:33, Nikita Popov : > Hi internals, > > Relating to the recent discussions on undefined variables & co. One thing > that is particularly annoying about the undefined variable case is that our > default error_reporting level (without a php.ini) does not include > E_NOTICE.

Re: [PHP-DEV] Make error_reporting=E_ALL the default

2019-08-30 Thread Zeev Suraski
> On 30 Aug 2019, at 12:33, Nikita Popov wrote: > > Hi internals, > > Relating to the recent discussions on undefined variables & co. One thing > that is particularly annoying about the undefined variable case is that our > default error_reporting level (without a php.ini) does not include

Re: [PHP-DEV] Make error_reporting=E_ALL the default

2019-08-30 Thread Zeev Suraski
> On 30 Aug 2019, at 12:33, Nikita Popov wrote: > > Hi internals, > > Relating to the recent discussions on undefined variables & co. One thing > that is particularly annoying about the undefined variable case is that our > default error_reporting level (without a php.ini) does not include

[PHP-DEV] Make error_reporting=E_ALL the default

2019-08-30 Thread Nikita Popov
Hi internals, Relating to the recent discussions on undefined variables & co. One thing that is particularly annoying about the undefined variable case is that our default error_reporting level (without a php.ini) does not include E_NOTICE. Thankfully distros do tend to have more reasonable