Re: [PHP-DEV] Renaming PhpAttribute to Attribute

2020-04-28 Thread Niklas Keller
Hey Benas, I've also tried to get that change into the original RFC, but wasn't able to. I'm in favor of an amendment RFC to change the name to Attribute. Best, Niklas Am Di., 28. Apr. 2020 um 17:37 Uhr schrieb Benas IML : > > Hey internals, > > Since it's safe to say that the Attributes v2

Re: [PHP-DEV] [VOTE] match expression

2020-04-28 Thread Levi Morrison via internals
On Tue, Apr 28, 2020 at 6:58 PM Larry Garfield wrote: > > On Tue, Apr 28, 2020, at 7:37 PM, Levi Morrison via internals wrote: > > > One issue that was discussed a few weeks ago, and led to the current > > > syntax, was too many variations within the switch syntax; of course, > > > trying to do

Re: [PHP-DEV] [VOTE] match expression

2020-04-28 Thread Larry Garfield
On Tue, Apr 28, 2020, at 7:37 PM, Levi Morrison via internals wrote: > > One issue that was discussed a few weeks ago, and led to the current > > syntax, was too many variations within the switch syntax; of course, trying > > to do it all in one syntax is perpetuating that problem. However, I

Re: [PHP-DEV] [VOTE] match expression

2020-04-28 Thread Levi Morrison via internals
> One issue that was discussed a few weeks ago, and led to the current syntax, > was too many variations within the switch syntax; of course, trying to do it > all in one syntax is perpetuating that problem. However, I think Rowan has > suggested a syntax that may be sufficiently

Re: [PHP-DEV] [RFC] Function pipe operator

2020-04-28 Thread Larry Garfield
On Tue, Apr 21, 2020, at 9:43 AM, Larry Garfield wrote: > On Mon, Apr 20, 2020, at 11:06 PM, Sara Golemon wrote: > > Happy with the revival, and I do want to underline the "Future Work" > > section about Partial Functions. PF will make this version of pipes 100% > > more readable and fluent, and

Re: [PHP-DEV] [VOTE] match expression

2020-04-28 Thread Larry Garfield
On Tue, Apr 28, 2020, at 10:31 AM, Rowan Tommins wrote: > On Tue, 28 Apr 2020 at 16:10, Bob Weinand wrote: > > > I think you should first think about why the "case" needs to exists at > > all. In particular it exists to distinguish goto labels from the case > > expressions in switch. With match,

Re: [PHP-DEV] Re: [RFC] Constructor Property Promotion

2020-04-28 Thread Larry Garfield
On Tue, Apr 28, 2020, at 10:56 AM, Nicolas Grekas wrote: > > > > > I would expect attributes to apply only to the properties on my side. > > > > Parameter annotations could be interesting for dependency injection. > > Symfony currently has some DI magic through parameter names among > > other

[PHP-DEV] Re: RFC karma request

2020-04-28 Thread Benas IML
Hello, Christoph, thank you so much! Best regards, Benas Seliuginas.

[PHP-DEV] Re: RFC karma request

2020-04-28 Thread Christoph M. Becker
On 28.04.2020 at 19:32, Benas IML wrote: > I need RFC karma for creating and proposing the "Renaming PhpAttribute" RFC. > Account's username: moliata RFC karma has been granted. Best of luck with the RFC. :) -- Christoph M. Becker -- PHP Internals - PHP Runtime Development Mailing List To

[PHP-DEV] xmlrpc_errors INI setting

2020-04-28 Thread Benjamin Eberlei
Hey, while working on cleanups for the internal error handling code, specifically extracting different rendering logic into pluggable hooks ( https://github.com/php/php-src/pull/5484) I came across the ini settings "xmlrpc_errors" and "xmlrpc_error_number", prominently integrated and used in

[PHP-DEV] RFC karma request

2020-04-28 Thread Benas IML
Hey internals, I need RFC karma for creating and proposing the "Renaming PhpAttribute" RFC. Account's username: moliata Best regards, Benas Seliuginas. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Renaming PhpAttribute to Attribute

2020-04-28 Thread Benas IML
Hello, > Speaking on the other note, is there any problem on my side but it doesn't > seem that I am able to register for a PHP wiki account [1]. I keep getting an > error message "That wasn't the answer we were expecting". This is no longer a problem, I successfully registered my wiki account.

Re: [PHP-DEV] Renaming PhpAttribute to Attribute

2020-04-28 Thread Benas IML
Hey, > Like many other things in life, just because you don't see something doesn't > mean that it is certainly not there ;-) I do understand your point and I do agree that there may be some minimal collision but stating that `Attribute` is too generic and will needlessly collide with code in

Re: [PHP-DEV] [RFC] [DISCUSSION] Ensure correct magic methods' signatures when typed

2020-04-28 Thread Gabriel Caruso
On Thu, 16 Apr 2020 at 16:22, Guilliam Xavier wrote: > On Sun, Apr 5, 2020 at 4:02 PM Gabriel Caruso > wrote: > > > > Hello, internals. > > > > Hereby you can find the RFC Document that I want to discuss as suggested > > via https://externals.io/message/109416 and > >

Re: [PHP-DEV] Renaming PhpAttribute to Attribute

2020-04-28 Thread Nikita Popov
On Tue, Apr 28, 2020 at 6:21 PM Aaron Piotrowski wrote: > > > On Apr 28, 2020, at 10:37 AM, Benas IML > wrote: > > > > Hey internals, > > > > Since it's safe to say that the Attributes v2 RFC has passed, I wanted to > > make a separate thread based on the comment by Rowan Tommins in the PHP > >

Re: [PHP-DEV] Renaming PhpAttribute to Attribute

2020-04-28 Thread Aaron Piotrowski
> On Apr 28, 2020, at 10:37 AM, Benas IML wrote: > > Hey internals, > > Since it's safe to say that the Attributes v2 RFC has passed, I wanted to > make a separate thread based on the comment by Rowan Tommins in the PHP > namespace policy thread. This is a quote from his comment: > >> One

Re: [PHP-DEV] Renaming PhpAttribute to Attribute

2020-04-28 Thread Marco Pivetta
Hey Benas, On Tue, Apr 28, 2020 at 5:59 PM Benas IML wrote: > > `Attribute` is certainly too generic, and will needlessly collide with > code > > in the wild. > > Could you provide any examples as to where '\Attribute' is being used in > the > wild? I haven't seen a single project that has an

Re: [PHP-DEV] Renaming PhpAttribute to Attribute

2020-04-28 Thread Rowan Tommins
On Tue, 28 Apr 2020 at 16:43, Marco Pivetta wrote: > `Attribute` is certainly too generic, and will needlessly collide with code > in the wild. > I wonder how true that is, precisely because it *is* so generic, so people will likely have used it with a prefix or in their own namespace. It

Re: [PHP-DEV] Renaming PhpAttribute to Attribute

2020-04-28 Thread Benas IML
Hello, > `Attribute` is certainly too generic, and will needlessly collide with code > in the wild. Could you provide any examples as to where '\Attribute' is being used in the wild? I haven't seen a single project that has an Attribute class and uses the global namespace. > I suggest circling

Re: [PHP-DEV] Re: [RFC] Constructor Property Promotion

2020-04-28 Thread Nicolas Grekas
> > > I would expect attributes to apply only to the properties on my side. > > Parameter annotations could be interesting for dependency injection. > Symfony currently has some DI magic through parameter names among > other things. It might be nice to control these through annotations > instead.

Re: [PHP-DEV] Re: [RFC] Constructor Property Promotion

2020-04-28 Thread Ilija Tovilo
Hi Nicolas > I would expect attributes to apply only to the properties on my side. Parameter annotations could be interesting for dependency injection. Symfony currently has some DI magic through parameter names among other things. It might be nice to control these through annotations instead.

Re: [PHP-DEV] Renaming PhpAttribute to Attribute

2020-04-28 Thread Marco Pivetta
Heya, On Tue, Apr 28, 2020 at 5:37 PM Benas IML wrote: > Hey internals, > > Since it's safe to say that the Attributes v2 RFC has passed, I wanted to > make a separate thread based on the comment by Rowan Tommins in the PHP > namespace policy thread. This is a quote from his comment: > > > One

[PHP-DEV] Renaming PhpAttribute to Attribute

2020-04-28 Thread Benas IML
Hey internals, Since it's safe to say that the Attributes v2 RFC has passed, I wanted to make a separate thread based on the comment by Rowan Tommins in the PHP namespace policy thread. This is a quote from his comment: > One prefix doesn't make a trend. "PhpToken" is a different case - it's a >

Re: [PHP-DEV] [VOTE] match expression

2020-04-28 Thread Rowan Tommins
On Tue, 28 Apr 2020 at 16:10, Bob Weinand wrote: > I think you should first think about why the "case" needs to exists at > all. In particular it exists to distinguish goto labels from the case > expressions in switch. With match, match restricting statements (and thus > goto labels) into {

Re: [PHP-DEV] Re: [RFC] Constructor Property Promotion

2020-04-28 Thread Nicolas Grekas
> On Thu, Mar 26, 2020 at 2:30 PM Nikita Popov wrote: > > > Hi internals, > > > > I would like to submit the following RFC for your consideration: > > https://wiki.php.net/rfc/constructor_promotion > > > > This is based on one off the suggestions made in > > https://externals.io/message/109220,

Re: [PHP-DEV] [VOTE] match expression

2020-04-28 Thread Bob Weinand
> Am 28.04.2020 um 12:48 schrieb Rowan Tommins : > > On Tue, 28 Apr 2020 at 11:19, Ilija Tovilo wrote: > >>> for the control-flow statement, it feels awkward and not in >>> keeping with the rest of the language. If they were separate proposals, >> the >>> statement would probably end up

[PHP-DEV] Re: [RFC] Constructor Property Promotion

2020-04-28 Thread Nikita Popov
On Thu, Mar 26, 2020 at 2:30 PM Nikita Popov wrote: > Hi internals, > > I would like to submit the following RFC for your consideration: > https://wiki.php.net/rfc/constructor_promotion > > This is based on one off the suggestions made in > https://externals.io/message/109220, and some existing

[PHP-DEV] Re: [VOTE] Allow trailing comma in parameter lists

2020-04-28 Thread Nikita Popov
On Tue, Apr 14, 2020 at 12:26 PM Nikita Popov wrote: > Hi internals, > > I've opened voting on > https://wiki.php.net/rfc/trailing_comma_in_parameter_list. Voting will > close on 2020-04-28. > This proposal has been accepted with 58 votes in favor and 1 vote against. Regards, Nikita

[PHP-DEV] [8.0] 3-Month Reminder; Feature Freeze is July 28th

2020-04-28 Thread Sara Golemon
Per the current schedule ( https://wiki.php.net/todo/php80 ), PHP 8.0 is set for feature freeze and branching on July 28th which is 3 calendar months from today (13 weeks). I would like to encourage everyone currently working on a proposal to please plan on getting your RFCs into voting no later

Re: [PHP-DEV] [RFC] PHP Namespace Policy

2020-04-28 Thread Rowan Tommins
On Tue, 28 Apr 2020 at 12:52, Max Semenik wrote: > On Tue, Apr 28, 2020 at 11:45 AM Rowan Tommins > wrote: > >> One prefix doesn't make a trend. "PhpToken" is a different case - it's a >> token of PHP source code, so the prefix isn't anything to do with avoiding >> name collisions, it's a

Re: [PHP-DEV] [RFC] PHP Namespace Policy

2020-04-28 Thread Max Semenik
On Tue, Apr 28, 2020 at 11:45 AM Rowan Tommins wrote: > One prefix doesn't make a trend. "PhpToken" is a different case - it's a > token of PHP source code, so the prefix isn't anything to do with avoiding > name collisions, it's a natural clarification. > There's also SPL, with classes like

Re: [PHP-DEV] [VOTE] match expression

2020-04-28 Thread Rowan Tommins
On Tue, 28 Apr 2020 at 11:19, Ilija Tovilo wrote: > > for the control-flow statement, it feels awkward and not in > > keeping with the rest of the language. If they were separate proposals, > the > > statement would probably end up looking very different. > > Can you elaborate? If I made a

Re: [PHP-DEV] [VOTE] match expression

2020-04-28 Thread Ilija Tovilo
Hi Nikita Thank you for your analysis. That's something I should've done as part of the RFC. I can only share my personal motivation for creating this RFC. Some people will disagree. > Is match intended as a replacement for switch? To me, match is primarily a switch alternative with safer

Re: [PHP-DEV] [VOTE] match expression

2020-04-28 Thread Rowan Tommins
On Tue, 28 Apr 2020 at 09:48, Nikita Popov wrote: > Many people in the voting thread are calling for supporting match > expressions only (without support for either statement form, or support for > block expressions). The RFC motivates the match construct as an improved > replacement for switch,

Re: [PHP-DEV] [VOTE] match expression

2020-04-28 Thread Nikita Popov
On Mon, Apr 27, 2020 at 3:57 PM Andrea Faulds wrote: > Hi, > > I share Dan's reasons for voting against. I don't think things should go > to a vote before the dust has settled. > > Regards, > Andrea Faulds > Similar sentiment here. I don't think the concept has been explored sufficiently. Many

Re: [PHP-DEV] [RFC] PHP Namespace Policy

2020-04-28 Thread Rowan Tommins
On Mon, 27 Apr 2020 at 23:22, Mike Schinkel wrote: > > On Apr 27, 2020, at 6:05 PM, Rowan Tommins > wrote: > > > > So you'd be happy with PHP\str_contains and \str_replace next to each > other indefinitely? > > Absolutely. The benefits of having a PHP namespace would outweigh the > lack of

Re: [PHP-DEV] Resurrecting named parameters

2020-04-28 Thread Benjamin Eberlei
On Tue, Apr 7, 2020 at 2:45 PM Nikita Popov wrote: > Hi internals, > > It's been a few years since I originally brought up the named parameters > RFC: https://wiki.php.net/rfc/named_params > > This topic has recently come up as part of > https://externals.io/message/109220 again, in particular