Re: [PHP-DEV] Convert SplFixedArray to Aggregate?

2020-06-26 Thread Alex
Dear Levi Morrison, please see this added test case: https://github.com/php/php-src/pull/5384/files#diff-dc4d304baf106b4a30432f80dae1a538 The iteration behavior of the modified SplFixedArray is quite humane even in the face of changing array size. -- PHP Internals - PHP Runtime Development Maili

[PHP-DEV] PHP Bug #79714 (need advice) + a couple of ideas for the future !

2020-06-26 Thread Henrik Skov
Hi list ! While I am still trying to fix bug 79714 (please see: https://bugs.php.net/bug.php?id=79714), I got a few ideas. First though, let me say that I still need advice about fixing the bug above as per my earlier mail. But now, my new idea: For future versions of PHP (8.1 ?), I woul

Re: [PHP-DEV] Convert SplFixedArray to Aggregate?

2020-06-26 Thread Alex
Dear Levi, I will add a test case to the PR to ensure that things work properly in the described situation. On Fri, Jun 26, 2020 at 3:57 PM Levi Morrison wrote: > > On Fri, Jun 26, 2020 at 12:45 AM Alex wrote: > > > > Dear PHP Internals, > > > > I would like to propose a backwards-incompatible c

Re: [PHP-DEV] Convert SplFixedArray to Aggregate?

2020-06-26 Thread Levi Morrison via internals
On Fri, Jun 26, 2020 at 12:45 AM Alex wrote: > > Dear PHP Internals, > > I would like to propose a backwards-incompatible change to > SplFixedArray which fixes the strange and almost certainly unintended > behavior reported in Bug 79404 > (https://bugs.php.net/bug.php?id=79404). > > In short: Beca

[PHP-DEV] PHP Bug #79714

2020-06-26 Thread Henrik Skov
Hi list ! I am still trying to solve bug 79714 (See: https://bugs.php.net/bug.php?id=79714) I am no expert at C and/or the PHP Core at all so I need a little advice from you guys. Seeing lines 3238-3314 in /ext/phar/phar.c (from php-src repo): static zend_op_array *phar_compile_file(zend_f

[PHP-DEV] Re: [RFC] Permit trailing whitespace in numeric strings (again)

2020-06-26 Thread Björn Larsson
Den 2020-06-24 kl. 15:40, skrev G. P. B.: Greetings internals, I want to bring back the following RFC, written by Andrea Faulds, back to the discussion table: https://wiki.php.net/rfc/trailing_whitespace_numerics As she doesn't have time to move forward with it she allowed me to take it over.