Re: [PHP-DEV] Re: [RFC] throwable_string_param_max_len: Configurable string length in getTraceAsString()

2020-07-02 Thread tyson andre
Hi Nikita, > Thanks for the update. You'll probably want to remove the corresponding > section under future scope now. Fixed, forgot to delete that after copying parts of it. > You may also want to give some more thought about the name of the ini setting > name. > We already have

[PHP-DEV] [RFC] [VOTE] Make constructors and destructors return void

2020-07-02 Thread Benas IML
Hey internals, I have opened the voting for the RFC, let's hope everything is going to be smooth :). If you have any other questions, let me know! RFC: https://wiki.php.net/rfc/make_ctor_ret_void Best regards, Benas Seliuginas -- PHP Internals - PHP Runtime Development Mailing List To

Re: [PHP-DEV] Improve "trying to get property 'id' of non-object" error message

2020-07-02 Thread David Rodrigues
Seems great, but maybe include more information should be better: Warning: Attempt to read property 'property' on bool <> in /in/IGUcS on line 5 Atenciosamente, David Rodrigues Em qui., 2 de jul. de 2020 às 12:27, Máté Kocsis escreveu: > Hi David, > > Please have a look at this example

Re: [PHP-DEV] Improve "trying to get property 'id' of non-object" error message

2020-07-02 Thread Máté Kocsis
Hi David, Please have a look at this example code: https://3v4l.org/IGUcS We've made dozens of error messages more helpful and more consistent for PHP 8. This is one of them. :) Cheers, Máté

[PHP-DEV] Improve "trying to get property 'id' of non-object" error message

2020-07-02 Thread David Rodrigues
Hello! Is it possible to improve this error message? It is much more complicated to identify when we have two occurrences on the same line. For example: $availMasterResults->get($availMaster->id . '@' . $sessionUser->id) -> trying to get property 'id' of non-object Is not possible to identify

Re: [PHP-DEV] Re: [RFC] [VOTE] Shorter Attribute Syntax

2020-07-02 Thread Theodore Brown
On Thu, July 2 2020 at 8:14 AM Nikita Popov wrote: > On Thu, Jul 2, 2020 at 2:13 AM Theodore Brown wrote: > > On Wed, June 17, 2020 at 5:59 PM Theodore Brown wrote: > > > > > I've opened voting on the Shorter Attribute Syntax RFC: > > > https://wiki.php.net/rfc/shorter_attribute_syntax > > > >

Re: [PHP-DEV] Re: [RFC] [VOTE] Shorter Attribute Syntax

2020-07-02 Thread Nikita Popov
On Thu, Jul 2, 2020 at 2:13 AM Theodore Brown wrote: > On Wed, June 17, 2020 at 5:59 PM Theodore Brown wrote: > > > I've opened voting on the Shorter Attribute Syntax RFC: > > https://wiki.php.net/rfc/shorter_attribute_syntax > > > > Since all RFCs require a primary vote with a 2/3 majority,

Re: [PHP-DEV][RFC] Saner numeric strings

2020-07-02 Thread G. P. B.
On Wed, 1 Jul 2020 at 18:44, Rowan Tommins wrote: > Hi George, > > On Wed, 1 Jul 2020 at 15:26, G. P. B. wrote: > >> >>2. Emit the E_WARNING "Illegal string offset" and evaluate to 0 for >>offsets like '2str', and emit the E_WARNING "String offset cast >>occurred" for float numeric

Re: [PHP-DEV] Re: [RFC] Named arguments

2020-07-02 Thread Nikita Popov
On Thu, Jul 2, 2020 at 1:20 PM Andrea Faulds wrote: > Hi, > > Nikita Popov wrote: > > > > Regarding the question of what to do with regard to LSP validation and > > parameter names changing during inheritance: During internal discussion, > > the following option has come up as a possible

[PHP-DEV] Re: [RFC] Named arguments

2020-07-02 Thread Andrea Faulds
Hi, Nikita Popov wrote: Regarding the question of what to do with regard to LSP validation and parameter names changing during inheritance: During internal discussion, the following option has come up as a possible compromise: 1. When calling a method, also allow using parameter names from

Re: [PHP-DEV] Re: [RFC] throwable_string_param_max_len: Configurable string length in getTraceAsString()

2020-07-02 Thread Nikita Popov
On Wed, Jul 1, 2020 at 10:46 PM tyson andre wrote: > Hi Nikita, > > > Why is the lower limit of the ini setting 15 and not 0? > > > > I just saw that you mention this possibility as "future scope". > > I don't think your reasoning there holds up if you take into account > > that we already

Re: [PHP-DEV] Draft RFC callable types + callable type/function autoloading

2020-07-02 Thread Nikita Popov
On Thu, Jul 2, 2020 at 12:26 PM Dan Ackroyd wrote: > On Wed, 1 Jul 2020 at 20:40, Larry Garfield > wrote: > > > it would also offer a way to do effectively the same thing > > One use-case that would need to be covered for that would be for > callables where you don't know how many parameters

Re: [PHP-DEV] Draft RFC callable types + callable type/function autoloading

2020-07-02 Thread Dan Ackroyd
On Wed, 1 Jul 2020 at 20:40, Larry Garfield wrote: > it would also offer a way to do effectively the same thing One use-case that would need to be covered for that would be for callables where you don't know how many parameters there would be in the callable. > duplicate functionality

Re: [PHP-DEV] [RFC] Saner string to number comparisons

2020-07-02 Thread Nikita Popov
On Thu, Jul 2, 2020 at 10:09 AM Nikita Popov wrote: > On Mon, Mar 4, 2019 at 6:00 PM Nikita Popov wrote: > >> On Wed, Feb 27, 2019 at 10:23 AM Zeev Suraski wrote: >> >>> >>> >>> On Tue, Feb 26, 2019 at 2:27 PM Nikita Popov >>> wrote: >>> Hi internals, I think it is well known

Re: [PHP-DEV] [RFC] Saner string to number comparisons

2020-07-02 Thread Nikita Popov
On Mon, Mar 4, 2019 at 6:00 PM Nikita Popov wrote: > On Wed, Feb 27, 2019 at 10:23 AM Zeev Suraski wrote: > >> >> >> On Tue, Feb 26, 2019 at 2:27 PM Nikita Popov >> wrote: >> >>> Hi internals, >>> >>> I think it is well known that == in PHP is a pretty big footgun. It >>> doesn't >>> have to