Re: [PHP-DEV] RFC json_validate() - status: Under Discussion

2022-09-21 Thread juan carlos morales
The RFC is in voting phase now. I want to thank everyone involved in the discussions related to this RFC, the ones who reviewed the code in advance, and the ones that with some emojis in github showed their interest and support. -- PHP Internals - PHP Runtime Development Mailing List To unsubscr

[PHP-DEV] [VOTE] json_validate

2022-09-21 Thread juan carlos morales
I am glad to announce that the RFC for the "json_validate()" function is in voting phase. Voting started 2022-09-22 and will end on 2022-10-07 at 00:00:00 UTC time zone (2 weeks + 1 day). I kindly ask everyone to consider that is the first time I do an RFC, if there is something wrong with it, I

Re: [PHP-DEV] Issues with readonly classes

2022-09-21 Thread Yasuo Ohgaki
2022年9月3日(土) 2:31 Nicolas Grekas : > Hello everybody, hi Mate > > I played with readonly classes recently, to add support for them to > lazy-loading proxy generation and I struggled upon what I see as serious > issues. > > As noted in the RFC, and because the readonly flag must be set on child > c

Re: [PHP-DEV] RFC [Discussion]: Improve unserialize() error handling

2022-09-21 Thread Tim Düsterhus
Hi On 9/20/22 21:24, Tim Düsterhus wrote: My understanding is that this attempts to gracefully handle broken cache entries and force a rebuild if the payload is invalid. This will fail if the serialized payload contains a malformed DateTimeImmutable, because DateTimeImmutable will throw an Erro

Re: [PHP-DEV] Re: Issues with readonly classes

2022-09-21 Thread Tim Düsterhus
Hi On 9/21/22 11:48, Nicolas Grekas wrote: What's your take about 8.2? As I demonstrated, readonly classes are broken because of this propagation to child classes. s/broken/working as expected broken. see thread Working as expected (or: working as designed). The behavior with regard to

Re: [PHP-DEV] make install overwriting php.ini

2022-09-21 Thread Mark “Dygear” Tomlin
Thanks for the reply Ben, once I get home I’ll send what I did exactly. Sent from my iPad > On Sep 17, 2022, at 11:42 AM, Ben Ramsey wrote: > >  >> >>> On Sep 16, 2022, at 20:27, Mark Tomlin wrote: >>> >> To the release managers of PHP, please make sure that you do not overwrite >> the php

Re: [PHP-DEV] Re: Issues with readonly classes

2022-09-21 Thread Nicolas Grekas
> > > When I was working on the readonly class RFC, I realized that the >> readonly >> > keyword very naturally fits services besides value objects. So my >> > expectation has been that until we can fix the issue with cloning, >> people >> > would mainly apply readonly to services. Not that it is v

Re: [PHP-DEV] Re: Issues with readonly classes

2022-09-21 Thread Marco Pivetta
On Wed, 21 Sept 2022 at 11:30, Nicolas Grekas wrote: > Hi all, > > > > When I was working on the readonly class RFC, I realized that the > readonly > > keyword very naturally fits services besides value objects. So my > > expectation has been that until we can fix the issue with cloning, people >

Re: [PHP-DEV] Re: Issues with readonly classes

2022-09-21 Thread Nicolas Grekas
Hi all, > When I was working on the readonly class RFC, I realized that the readonly > keyword very naturally fits services besides value objects. So my > expectation has been that until we can fix the issue with cloning, people > would mainly apply readonly to services. Not that it is very usefu